* [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup
@ 2021-10-21 14:02 Florian Westphal
2021-10-21 14:20 ` Antoine Tenart
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Florian Westphal @ 2021-10-21 14:02 UTC (permalink / raw)
To: netdev; +Cc: dsahern, Florian Westphal
On my box I see a bunch of ping/nettest processes hanging
around after fcntal-test.sh is done.
Clean those up before netns deletion.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
tools/testing/selftests/net/fcnal-test.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 13350cd5c8ac..5aba16c52c2b 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -439,10 +439,13 @@ cleanup()
ip -netns ${NSA} link set dev ${NSA_DEV} down
ip -netns ${NSA} link del dev ${NSA_DEV}
+ ip netns pids ${NSA} | xargs kill 2>/dev/null
ip netns del ${NSA}
fi
+ ip netns pids ${NSB} | xargs kill 2>/dev/null
ip netns del ${NSB}
+ ip netns pids ${NSC} | xargs kill 2>/dev/null
ip netns del ${NSC} >/dev/null 2>&1
}
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup
2021-10-21 14:02 [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup Florian Westphal
@ 2021-10-21 14:20 ` Antoine Tenart
2021-10-21 14:42 ` David Ahern
2021-10-22 21:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Antoine Tenart @ 2021-10-21 14:20 UTC (permalink / raw)
To: Florian Westphal, netdev; +Cc: dsahern, Florian Westphal
Hi Florian,
Quoting Florian Westphal (2021-10-21 16:02:47)
>
> + ip netns pids ${NSA} | xargs kill 2>/dev/null
> ip netns del ${NSA}
> fi
>
> + ip netns pids ${NSB} | xargs kill 2>/dev/null
> ip netns del ${NSB}
> + ip netns pids ${NSC} | xargs kill 2>/dev/null
> ip netns del ${NSC} >/dev/null 2>&1
Alternatively you can use `xargs -r` (`--no-run-if-empty`) to avoid
redirecting stderr to /dev/null.
Thanks!
Antoine
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup
2021-10-21 14:02 [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup Florian Westphal
2021-10-21 14:20 ` Antoine Tenart
@ 2021-10-21 14:42 ` David Ahern
2021-10-22 21:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: David Ahern @ 2021-10-21 14:42 UTC (permalink / raw)
To: Florian Westphal, netdev; +Cc: dsahern
On 10/21/21 8:02 AM, Florian Westphal wrote:
> On my box I see a bunch of ping/nettest processes hanging
> around after fcntal-test.sh is done.
>
> Clean those up before netns deletion.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> tools/testing/selftests/net/fcnal-test.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
> index 13350cd5c8ac..5aba16c52c2b 100755
> --- a/tools/testing/selftests/net/fcnal-test.sh
> +++ b/tools/testing/selftests/net/fcnal-test.sh
> @@ -439,10 +439,13 @@ cleanup()
> ip -netns ${NSA} link set dev ${NSA_DEV} down
> ip -netns ${NSA} link del dev ${NSA_DEV}
>
> + ip netns pids ${NSA} | xargs kill 2>/dev/null
> ip netns del ${NSA}
> fi
>
> + ip netns pids ${NSB} | xargs kill 2>/dev/null
> ip netns del ${NSB}
> + ip netns pids ${NSC} | xargs kill 2>/dev/null
> ip netns del ${NSC} >/dev/null 2>&1
> }
>
>
Acked-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup
2021-10-21 14:02 [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup Florian Westphal
2021-10-21 14:20 ` Antoine Tenart
2021-10-21 14:42 ` David Ahern
@ 2021-10-22 21:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-22 21:10 UTC (permalink / raw)
To: Florian Westphal; +Cc: netdev, dsahern
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 21 Oct 2021 16:02:47 +0200 you wrote:
> On my box I see a bunch of ping/nettest processes hanging
> around after fcntal-test.sh is done.
>
> Clean those up before netns deletion.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
>
> [...]
Here is the summary with links:
- [net] fcnal-test: kill hanging ping/nettest binaries on cleanup
https://git.kernel.org/netdev/net/c/1f83b835a3ea
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-22 21:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-21 14:02 [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup Florian Westphal
2021-10-21 14:20 ` Antoine Tenart
2021-10-21 14:42 ` David Ahern
2021-10-22 21:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.