All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Hector Martin <marcan@marcan.st>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mark Kettenis <kettenis@openbsd.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Arnd Bergmann <arnd@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v2 3/8] dt-bindings: power: Add apple,pmgr-pwrstate binding
Date: Mon, 25 Oct 2021 13:16:53 -0500	[thread overview]
Message-ID: <1635185813.771483.824869.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211025144718.157794-4-marcan@marcan.st>

On Mon, 25 Oct 2021 23:47:13 +0900, Hector Martin wrote:
> This syscon child node represents a single SoC device controlled by the
> PMGR block. This layout allows us to declare all device power state
> controls (power/clock gating and reset) in the device tree, including
> dependencies, instead of hardcoding it into the driver. The register
> layout is uniform.
> 
> Each pmgr-pwrstate node provides genpd and reset features, to be
> consumed by downstream device nodes.
> 
> Future SoCs are expected to use backwards compatible registers, and the
> "apple,pmgr-pwrstate" represents any such interfaces (possibly with
> additional features gated by the more specific compatible), allowing
> them to be bound without driver updates. If a backwards incompatible
> change is introduced in future SoCs, it will require a new compatible,
> such as "apple,pmgr-pwrstate-v2".
> 
> Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  .../bindings/power/apple,pmgr-pwrstate.yaml   | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml: Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml

See https://patchwork.ozlabs.org/patch/1545800

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Hector Martin <marcan@marcan.st>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mark Kettenis <kettenis@openbsd.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Arnd Bergmann <arnd@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v2 3/8] dt-bindings: power: Add apple, pmgr-pwrstate binding
Date: Mon, 25 Oct 2021 13:16:53 -0500	[thread overview]
Message-ID: <1635185813.771483.824869.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211025144718.157794-4-marcan@marcan.st>

On Mon, 25 Oct 2021 23:47:13 +0900, Hector Martin wrote:
> This syscon child node represents a single SoC device controlled by the
> PMGR block. This layout allows us to declare all device power state
> controls (power/clock gating and reset) in the device tree, including
> dependencies, instead of hardcoding it into the driver. The register
> layout is uniform.
> 
> Each pmgr-pwrstate node provides genpd and reset features, to be
> consumed by downstream device nodes.
> 
> Future SoCs are expected to use backwards compatible registers, and the
> "apple,pmgr-pwrstate" represents any such interfaces (possibly with
> additional features gated by the more specific compatible), allowing
> them to be bound without driver updates. If a backwards incompatible
> change is introduced in future SoCs, it will require a new compatible,
> such as "apple,pmgr-pwrstate-v2".
> 
> Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  .../bindings/power/apple,pmgr-pwrstate.yaml   | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml: Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml

See https://patchwork.ozlabs.org/patch/1545800

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-25 18:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 14:47 [PATCH v2 0/8] Apple SoC PMGR device power states driver Hector Martin
2021-10-25 14:47 ` Hector Martin
2021-10-25 14:47 ` [PATCH v2 1/8] MAINTAINERS: Add PMGR power state files to ARM/APPLE MACHINE Hector Martin
2021-10-25 14:47   ` Hector Martin
2021-10-25 14:47 ` [PATCH v2 2/8] dt-bindings: arm: apple: Add apple,pmgr binding Hector Martin
2021-10-25 14:47   ` Hector Martin
2021-10-25 18:16   ` Rob Herring
2021-10-25 18:16     ` Rob Herring
2021-10-25 18:21     ` Hector Martin
2021-10-25 18:21       ` Hector Martin
2021-10-26 18:25   ` Rob Herring
2021-10-26 18:25     ` Rob Herring
2021-10-27  3:38     ` Hector Martin
2021-10-27  3:38       ` Hector Martin
2021-10-27 14:43       ` Rob Herring
2021-10-27 14:43         ` Rob Herring
2021-10-27 14:51         ` Krzysztof Kozlowski
2021-10-27 14:51           ` Krzysztof Kozlowski
2021-10-29  7:09           ` Hector Martin
2021-10-29  7:09             ` Hector Martin
2021-10-25 14:47 ` [PATCH v2 3/8] dt-bindings: power: Add apple,pmgr-pwrstate binding Hector Martin
2021-10-25 14:47   ` Hector Martin
2021-10-25 18:16   ` Rob Herring [this message]
2021-10-25 18:16     ` [PATCH v2 3/8] dt-bindings: power: Add apple, pmgr-pwrstate binding Rob Herring
2021-10-26 18:27   ` [PATCH v2 3/8] dt-bindings: power: Add apple,pmgr-pwrstate binding Rob Herring
2021-10-26 18:27     ` Rob Herring
2021-10-25 14:47 ` [PATCH v2 4/8] soc: apple: Add driver for Apple PMGR power state controls Hector Martin
2021-10-25 14:47   ` Hector Martin
2021-10-25 14:47 ` [PATCH v2 5/8] arm64: dts: apple: t8103: Rename clk24 to clkref Hector Martin
2021-10-25 14:47   ` Hector Martin
2021-10-25 14:47 ` [PATCH v2 6/8] arm64: dts: apple: t8103: Add the UART PMGR tree Hector Martin
2021-10-25 14:47   ` Hector Martin
2021-10-25 14:47 ` [PATCH v2 7/8] tty: serial: samsung_tty: Support runtime PM Hector Martin
2021-10-25 14:47   ` Hector Martin
2021-10-25 14:47 ` [PATCH v2 8/8] arm64: dts: apple: t8103: Add UART2 Hector Martin
2021-10-25 14:47   ` Hector Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1635185813.771483.824869.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alyssa@rosenzweig.io \
    --cc=arnd@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=kettenis@openbsd.org \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=mark.kettenis@xs4all.nl \
    --cc=maz@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.