* [Bridge] [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
@ 2021-10-28 15:58 ` Ivan Vecera
0 siblings, 0 replies; 6+ messages in thread
From: Ivan Vecera @ 2021-10-28 15:58 UTC (permalink / raw)
To: netdev
Cc: moderated list:ETHERNET BRIDGE, open list, Horatiu Vultur,
Henrik Bjoernlund, Nikolay Aleksandrov, Roopa Prabhu,
Jakub Kicinski, David S. Miller
Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
that return a count. When BRIDGE_CFM is not enabled these functions
simply return -EOPNOTSUPP but do not modify count parameter and
calling function then works with uninitialized variables.
Modify these inline functions to return zero in count parameter.
Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
net/bridge/br_private.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 37ca76406f1e..fd5e7e74573c 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -1911,11 +1911,13 @@ static inline int br_cfm_status_fill_info(struct sk_buff *skb,
static inline int br_cfm_mep_count(struct net_bridge *br, u32 *count)
{
+ *count = 0;
return -EOPNOTSUPP;
}
static inline int br_cfm_peer_mep_count(struct net_bridge *br, u32 *count)
{
+ *count = 0;
return -EOPNOTSUPP;
}
#endif
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
@ 2021-10-28 15:58 ` Ivan Vecera
0 siblings, 0 replies; 6+ messages in thread
From: Ivan Vecera @ 2021-10-28 15:58 UTC (permalink / raw)
To: netdev
Cc: Henrik Bjoernlund, Roopa Prabhu, Nikolay Aleksandrov,
David S. Miller, Jakub Kicinski, Horatiu Vultur,
moderated list:ETHERNET BRIDGE, open list
Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
that return a count. When BRIDGE_CFM is not enabled these functions
simply return -EOPNOTSUPP but do not modify count parameter and
calling function then works with uninitialized variables.
Modify these inline functions to return zero in count parameter.
Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
net/bridge/br_private.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 37ca76406f1e..fd5e7e74573c 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -1911,11 +1911,13 @@ static inline int br_cfm_status_fill_info(struct sk_buff *skb,
static inline int br_cfm_mep_count(struct net_bridge *br, u32 *count)
{
+ *count = 0;
return -EOPNOTSUPP;
}
static inline int br_cfm_peer_mep_count(struct net_bridge *br, u32 *count)
{
+ *count = 0;
return -EOPNOTSUPP;
}
#endif
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Bridge] [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
2021-10-28 15:58 ` Ivan Vecera
@ 2021-10-28 16:00 ` Nikolay Aleksandrov
-1 siblings, 0 replies; 6+ messages in thread
From: Nikolay Aleksandrov @ 2021-10-28 16:00 UTC (permalink / raw)
To: Ivan Vecera, netdev
Cc: moderated list:ETHERNET BRIDGE, open list, David S. Miller,
Henrik Bjoernlund, Roopa Prabhu, Jakub Kicinski, Horatiu Vultur
On 28/10/2021 18:58, Ivan Vecera wrote:
> Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
> that return a count. When BRIDGE_CFM is not enabled these functions
> simply return -EOPNOTSUPP but do not modify count parameter and
> calling function then works with uninitialized variables.
> Modify these inline functions to return zero in count parameter.
>
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> net/bridge/br_private.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 37ca76406f1e..fd5e7e74573c 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1911,11 +1911,13 @@ static inline int br_cfm_status_fill_info(struct sk_buff *skb,
>
> static inline int br_cfm_mep_count(struct net_bridge *br, u32 *count)
> {
> + *count = 0;
> return -EOPNOTSUPP;
> }
>
> static inline int br_cfm_peer_mep_count(struct net_bridge *br, u32 *count)
> {
> + *count = 0;
> return -EOPNOTSUPP;
> }
> #endif
>
Thank you,
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
@ 2021-10-28 16:00 ` Nikolay Aleksandrov
0 siblings, 0 replies; 6+ messages in thread
From: Nikolay Aleksandrov @ 2021-10-28 16:00 UTC (permalink / raw)
To: Ivan Vecera, netdev
Cc: Henrik Bjoernlund, Roopa Prabhu, David S. Miller, Jakub Kicinski,
Horatiu Vultur, moderated list:ETHERNET BRIDGE, open list
On 28/10/2021 18:58, Ivan Vecera wrote:
> Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
> that return a count. When BRIDGE_CFM is not enabled these functions
> simply return -EOPNOTSUPP but do not modify count parameter and
> calling function then works with uninitialized variables.
> Modify these inline functions to return zero in count parameter.
>
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> net/bridge/br_private.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 37ca76406f1e..fd5e7e74573c 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1911,11 +1911,13 @@ static inline int br_cfm_status_fill_info(struct sk_buff *skb,
>
> static inline int br_cfm_mep_count(struct net_bridge *br, u32 *count)
> {
> + *count = 0;
> return -EOPNOTSUPP;
> }
>
> static inline int br_cfm_peer_mep_count(struct net_bridge *br, u32 *count)
> {
> + *count = 0;
> return -EOPNOTSUPP;
> }
> #endif
>
Thank you,
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
2021-10-28 15:58 ` Ivan Vecera
@ 2021-10-29 12:50 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-29 12:50 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, bridge, linux-kernel, horatiu.vultur, henrik.bjoernlund,
nikolay, roopa, kuba, davem
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 28 Oct 2021 17:58:35 +0200 you wrote:
> Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
> that return a count. When BRIDGE_CFM is not enabled these functions
> simply return -EOPNOTSUPP but do not modify count parameter and
> calling function then works with uninitialized variables.
> Modify these inline functions to return zero in count parameter.
>
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>
> [...]
Here is the summary with links:
- [net,v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
https://git.kernel.org/netdev/net/c/829e050eea69
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
@ 2021-10-29 12:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-29 12:50 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, henrik.bjoernlund, roopa, nikolay, davem, kuba,
horatiu.vultur, bridge, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 28 Oct 2021 17:58:35 +0200 you wrote:
> Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
> that return a count. When BRIDGE_CFM is not enabled these functions
> simply return -EOPNOTSUPP but do not modify count parameter and
> calling function then works with uninitialized variables.
> Modify these inline functions to return zero in count parameter.
>
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>
> [...]
Here is the summary with links:
- [net,v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled
https://git.kernel.org/netdev/net/c/829e050eea69
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-29 12:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-28 15:58 [Bridge] [PATCH net v2] net: bridge: fix uninitialized variables when BRIDGE_CFM is disabled Ivan Vecera
2021-10-28 15:58 ` Ivan Vecera
2021-10-28 16:00 ` [Bridge] " Nikolay Aleksandrov
2021-10-28 16:00 ` Nikolay Aleksandrov
2021-10-29 12:50 ` [Bridge] " patchwork-bot+netdevbpf
2021-10-29 12:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.