[PATCH] docs/grub.texi: Fix build warnings in libgcrypt and blsuki doc

[PATCH] docs/grub.texi: Fix build warnings in libgcrypt and blsuki doc

[Sridhar Markonda]

Following warnings thrown during build libgrcypt and bluski doc

grub.texi:4744: warning: node next pointer for `gcry_arcfour_module' is `gcry_blake2_module' but next is `gcry_aria_module' in menu
grub.texi:4744: warning: node prev pointer for `gcry_arcfour_module' is `gcry_aria_module' but prev is `functional_test_module' in menu
grub.texi:4751: warning: node prev pointer for `gcry_blake2_module' is `gcry_arcfour_module' but prev is `gcry_aria_module' in menu
grub.texi:8532: warning: node next pointer for `trust' is `unset' but next is `uki' in menu
grub.texi:8549: warning: node next pointer for `unset' is `uki' but next is `verify_detached' in menu
grub.texi:8549: warning: node prev pointer for `unset' is `trust' but prev is `uki' in menu
grub.texi:8557: warning: node next pointer for `uki' is `verify_detached' but next is `unset' in menu
grub.texi:8557: warning: node prev pointer for `uki' is `unset' but prev is `trust' in menu
grub.texi:8600: warning: node prev pointer for `verify_detached' is `uki' but prev is `unset' in menu

Fix order of gcry_aria_module and unset nodes

Signed-off-by: Sridhar Markonda <sridharm@linux.ibm.com>
---
 docs/grub.texi | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/docs/grub.texi b/docs/grub.texi
index b81eb1d93..d67aeb886 100644
--- a/docs/grub.texi
+++ b/docs/grub.texi
@@ -4710,11 +4710,6 @@ This module provides support functions (helper functions) for file systems.
 This module provides support for running the GRUB functional tests using
 commands @command{functional_test} and @command{all_functional_test}.
 
-@node gcry_aria_module
-@section gcry_aria
-This module provides support for the ARIA cipher.
-This GRUB module is based on libgcrypt.
-
 @node gcry_arcfour_module
 @section gcry_arcfour
 This module provides support for the arcfour stream cipher also known as RC4.
@@ -4722,6 +4717,11 @@ If security is a concern, RC4 / arcfour cipher is consider broken (multiple
 known vulnerabilities make this insecure).
 This GRUB module is based on libgcrypt.
 
+@node gcry_aria_module
+@section gcry_aria
+This module provides support for the ARIA cipher.
+This GRUB module is based on libgcrypt.
+
 @node gcry_blake2_module
 @section gcry_blake2
 This module provides support for the BLAKE2b and BLAKE2s message digests.
@@ -8372,14 +8372,6 @@ information.
 @end deffn
 
 
-@node unset
-@subsection unset
-
-@deffn Command unset envvar
-Unset the environment variable @var{envvar}.
-@end deffn
-
-
 @node uki
 @subsection uki
 
@@ -8412,6 +8404,14 @@ will be added to the GRUB menu.
 For more information on UKI, see: @uref{https://uapi-group.org/specifications/specs/unified_kernel_image/, The Unified Kernel Image Specification}
 @end deffn
 
+@node unset
+@subsection unset
+
+@deffn Command unset envvar
+Unset the environment variable @var{envvar}.
+@end deffn
+
+
 @ignore
 @node vbeinfo
 @subsection vbeinfo
-- 
2.51.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] docs/grub.texi: Fix build warnings in libgcrypt and blsuki doc

[Andrew Hamilton]

Looks good to me.

Reviewed-by: Andrew Hamilton <adhamilt@gmail.com>

On Mon, Sep 15, 2025 at 10:13 AM Sridhar Markonda
<sridharm@linux.ibm.com> wrote:
>
> Following warnings thrown during build libgrcypt and bluski doc
>
> grub.texi:4744: warning: node next pointer for `gcry_arcfour_module' is `gcry_blake2_module' but next is `gcry_aria_module' in menu
> grub.texi:4744: warning: node prev pointer for `gcry_arcfour_module' is `gcry_aria_module' but prev is `functional_test_module' in menu
> grub.texi:4751: warning: node prev pointer for `gcry_blake2_module' is `gcry_arcfour_module' but prev is `gcry_aria_module' in menu
> grub.texi:8532: warning: node next pointer for `trust' is `unset' but next is `uki' in menu
> grub.texi:8549: warning: node next pointer for `unset' is `uki' but next is `verify_detached' in menu
> grub.texi:8549: warning: node prev pointer for `unset' is `trust' but prev is `uki' in menu
> grub.texi:8557: warning: node next pointer for `uki' is `verify_detached' but next is `unset' in menu
> grub.texi:8557: warning: node prev pointer for `uki' is `unset' but prev is `trust' in menu
> grub.texi:8600: warning: node prev pointer for `verify_detached' is `uki' but prev is `unset' in menu
>
> Fix order of gcry_aria_module and unset nodes
>
> Signed-off-by: Sridhar Markonda <sridharm@linux.ibm.com>
> ---
>  docs/grub.texi | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index b81eb1d93..d67aeb886 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4710,11 +4710,6 @@ This module provides support functions (helper functions) for file systems.
>  This module provides support for running the GRUB functional tests using
>  commands @command{functional_test} and @command{all_functional_test}.
>
> -@node gcry_aria_module
> -@section gcry_aria
> -This module provides support for the ARIA cipher.
> -This GRUB module is based on libgcrypt.
> -
>  @node gcry_arcfour_module
>  @section gcry_arcfour
>  This module provides support for the arcfour stream cipher also known as RC4.
> @@ -4722,6 +4717,11 @@ If security is a concern, RC4 / arcfour cipher is consider broken (multiple
>  known vulnerabilities make this insecure).
>  This GRUB module is based on libgcrypt.
>
> +@node gcry_aria_module
> +@section gcry_aria
> +This module provides support for the ARIA cipher.
> +This GRUB module is based on libgcrypt.
> +
>  @node gcry_blake2_module
>  @section gcry_blake2
>  This module provides support for the BLAKE2b and BLAKE2s message digests.
> @@ -8372,14 +8372,6 @@ information.
>  @end deffn
>
>
> -@node unset
> -@subsection unset
> -
> -@deffn Command unset envvar
> -Unset the environment variable @var{envvar}.
> -@end deffn
> -
> -
>  @node uki
>  @subsection uki
>
> @@ -8412,6 +8404,14 @@ will be added to the GRUB menu.
>  For more information on UKI, see: @uref{https://uapi-group.org/specifications/specs/unified_kernel_image/, The Unified Kernel Image Specification}
>  @end deffn
>
> +@node unset
> +@subsection unset
> +
> +@deffn Command unset envvar
> +Unset the environment variable @var{envvar}.
> +@end deffn
> +
> +
>  @ignore
>  @node vbeinfo
>  @subsection vbeinfo
> --
> 2.51.0
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] docs/grub.texi: Fix build warnings in libgcrypt and blsuki doc

[Sudhakar Kuppusamy]

> On 15 Sep 2025, at 12:52 PM, Sridhar Markonda <sridharm@linux.ibm.com> wrote:
> 
> Following warnings thrown during build libgrcypt and bluski doc
> 
> grub.texi:4744: warning: node next pointer for `gcry_arcfour_module' is `gcry_blake2_module' but next is `gcry_aria_module' in menu
> grub.texi:4744: warning: node prev pointer for `gcry_arcfour_module' is `gcry_aria_module' but prev is `functional_test_module' in menu
> grub.texi:4751: warning: node prev pointer for `gcry_blake2_module' is `gcry_arcfour_module' but prev is `gcry_aria_module' in menu
> grub.texi:8532: warning: node next pointer for `trust' is `unset' but next is `uki' in menu
> grub.texi:8549: warning: node next pointer for `unset' is `uki' but next is `verify_detached' in menu
> grub.texi:8549: warning: node prev pointer for `unset' is `trust' but prev is `uki' in menu
> grub.texi:8557: warning: node next pointer for `uki' is `verify_detached' but next is `unset' in menu
> grub.texi:8557: warning: node prev pointer for `uki' is `unset' but prev is `trust' in menu
> grub.texi:8600: warning: node prev pointer for `verify_detached' is `uki' but prev is `unset' in menu
> 
> Fix order of gcry_aria_module and unset nodes
> 
> Signed-off-by: Sridhar Markonda <sridharm@linux.ibm.com>

Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>

> ---
> docs/grub.texi | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/docs/grub.texi b/docs/grub.texi
> index b81eb1d93..d67aeb886 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4710,11 +4710,6 @@ This module provides support functions (helper functions) for file systems.
> This module provides support for running the GRUB functional tests using
> commands @command{functional_test} and @command{all_functional_test}.
> 
> -@node gcry_aria_module
> -@section gcry_aria
> -This module provides support for the ARIA cipher.
> -This GRUB module is based on libgcrypt.
> -
> @node gcry_arcfour_module
> @section gcry_arcfour
> This module provides support for the arcfour stream cipher also known as RC4.
> @@ -4722,6 +4717,11 @@ If security is a concern, RC4 / arcfour cipher is consider broken (multiple
> known vulnerabilities make this insecure).
> This GRUB module is based on libgcrypt.
> 
> +@node gcry_aria_module
> +@section gcry_aria
> +This module provides support for the ARIA cipher.
> +This GRUB module is based on libgcrypt.
> +
> @node gcry_blake2_module
> @section gcry_blake2
> This module provides support for the BLAKE2b and BLAKE2s message digests.
> @@ -8372,14 +8372,6 @@ information.
> @end deffn
> 
> 
> -@node unset
> -@subsection unset
> -
> -@deffn Command unset envvar
> -Unset the environment variable @var{envvar}.
> -@end deffn
> -
> -
> @node uki
> @subsection uki
> 
> @@ -8412,6 +8404,14 @@ will be added to the GRUB menu.
> For more information on UKI, see: @uref{https://uapi-group.org/specifications/specs/unified_kernel_image/, The Unified Kernel Image Specification}
> @end deffn
> 
> +@node unset
> +@subsection unset
> +
> +@deffn Command unset envvar
> +Unset the environment variable @var{envvar}.
> +@end deffn
> +
> +
> @ignore
> @node vbeinfo
> @subsection vbeinfo
> -- 
> 2.51.0
> 


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] docs/grub.texi: Fix build warnings in libgcrypt and blsuki doc

[Avnish Chouhan]

On 2025-09-16 17:33, grub-devel-request@gnu.org wrote:
> Message: 1
> Date: Mon, 15 Sep 2025 11:58:32 -0500
> From: Andrew Hamilton <adhamilt@gmail.com>
> To: The development of GNU GRUB <grub-devel@gnu.org>
> Cc: daniel.kiper@oracle.com, phcoder@gmail.com,
> 	sudhakar@linux.ibm.com,  stefanb@linux.ibm.com, nayna@linux.ibm.com,
> 	ssrish@linux.ibm.com
> Subject: Re: [PATCH] docs/grub.texi: Fix build warnings in libgcrypt
> 	and blsuki doc
> Message-ID:
> 	<CA+04=DaRWxJQ5bfs4knb2iCy1tmBvqTOUN8rUuWyzfWGQcY2EQ@mail.gmail.com>
> Content-Type: text/plain; charset="UTF-8"
> 
> Looks good to me.
> 
> Reviewed-by: Andrew Hamilton <adhamilt@gmail.com>

Reviewed-by: Avnish Chouhan <avnish@linux.ibm.com>

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] getroot: Skip mount points in grub_find_device

[Avnish Chouhan]

On 2025-09-16 17:33, grub-devel-request@gnu.org wrote:
> Message: 3
> Date: Tue, 16 Sep 2025 14:38:05 +0800
> From: Michael Chang <mchang@suse.com>
> To: The development of GNU GRUB <grub-devel@gnu.org>
> Subject: [PATCH] getroot: Skip mount points in grub_find_device
> Message-ID: <20250916063805.181388-1-mchang@suse.com>
> 
> The grub_find_device function scans a starting directory, typically
> /dev, for device files with matching major and minor numbers. During
> this process, it recursively descends into subdirectories.
> 
> However, this can significantly slow down the scan if a subdirectory is
> a mount point not related to devtmpfs, especially if it contains a 
> large
> number of files.
> 
> This patch modifies grub_find_device() to skip subdirectories that are
> mount points. A mount point is detected by comparing the st_dev of the
> subdirectory against that of the parent or starting directory. While
> this method does not catch all types of mounts, for eg bind mounts, it
> is a practical solution that avoids the need to parse 
> /proc/self/mounts.
> 
> Signed-off-by: Michael Chang <mchang@suse.com>

Reviewed-by: Avnish Chouhan <avnish@linux.ibm.com>

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel