From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
eddie.cai.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: Kate Stewart
<kstewart-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Greg KH
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org
Subject: Re: [v8, 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface
Date: Fri, 18 Jan 2019 13:34:47 +0100 [thread overview]
Message-ID: <1636679.fMryThW7k8@phil> (raw)
In-Reply-To: <alpine.DEB.2.21.1901180131510.1647-ecDvlHI5BZPZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
Hi Thomas,
Am Freitag, 18. Januar 2019, 01:40:03 CET schrieb Thomas Gleixner:
> On Thu, 30 Aug 2018, Heiko Stuebner wrote:
> > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c
> > @@ -0,0 +1,173 @@
> > +//SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
> > + * Author:
> > + * Sandy Huang <hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
>
> The licensing in this file and in the corresponding header is broken.
>
> > --- /dev/null
> > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.h
> > @@ -0,0 +1,20 @@
> > +//SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
> > + * Author:
> > + * Sandy Huang <hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + */
>
> Both files use the SPDX license identifier for GPL v2 or later, but the
> license notice is clearly v2 only.
>
> So the copyright holder needs to decide which one. And please remove the
> boiler plate text. It's redundant.
Not sure how to proceed as I haven't seen Sandy around for quite a bit,
but the first versions didn't have a SPDX header and were GPL2-only (v1-v4)
and the SPDX header was added in v5.
So as a stopgap measure, I'd guess we could assume that the copyright
intended GPL2-only?
> Please fix ASAP, add a Fixes tag and cc stable so the inconsistency is
> fixed in 4.20 as well.
ok, once we have the direction of change set.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Thomas Gleixner <tglx@linutronix.de>, eddie.cai.linux@gmail.com
Cc: hjc@rock-chips.com, linux-rockchip@lists.infradead.org,
seanpaul@chromium.org, LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Greg KH <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>
Subject: Re: [v8, 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface
Date: Fri, 18 Jan 2019 13:34:47 +0100 [thread overview]
Message-ID: <1636679.fMryThW7k8@phil> (raw)
In-Reply-To: <alpine.DEB.2.21.1901180131510.1647@nanos.tec.linutronix.de>
Hi Thomas,
Am Freitag, 18. Januar 2019, 01:40:03 CET schrieb Thomas Gleixner:
> On Thu, 30 Aug 2018, Heiko Stuebner wrote:
> > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c
> > @@ -0,0 +1,173 @@
> > +//SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
> > + * Author:
> > + * Sandy Huang <hjc@rock-chips.com>
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
>
> The licensing in this file and in the corresponding header is broken.
>
> > --- /dev/null
> > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.h
> > @@ -0,0 +1,20 @@
> > +//SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
> > + * Author:
> > + * Sandy Huang <hjc@rock-chips.com>
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + */
>
> Both files use the SPDX license identifier for GPL v2 or later, but the
> license notice is clearly v2 only.
>
> So the copyright holder needs to decide which one. And please remove the
> boiler plate text. It's redundant.
Not sure how to proceed as I haven't seen Sandy around for quite a bit,
but the first versions didn't have a SPDX header and were GPL2-only (v1-v4)
and the SPDX header was added in v5.
So as a stopgap measure, I'd guess we could assume that the copyright
intended GPL2-only?
> Please fix ASAP, add a Fixes tag and cc stable so the inconsistency is
> fixed in 4.20 as well.
ok, once we have the direction of change set.
Heiko
next prev parent reply other threads:[~2019-01-18 12:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 21:12 [PATCH v8 0/3] Add support rockchip RGB output interface Heiko Stuebner
2018-08-30 21:12 ` Heiko Stuebner
2018-08-30 21:12 ` [PATCH v8 1/3] drm/rockchip: add function to check if endpoint is a subdriver Heiko Stuebner
2018-08-30 21:12 ` Heiko Stuebner
2018-08-31 1:41 ` Sandy Huang
2018-08-31 1:41 ` Sandy Huang
2018-08-30 21:12 ` [PATCH v8 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface Heiko Stuebner
[not found] ` <20180830211207.10480-3-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2019-01-18 0:40 ` [v8, " Thomas Gleixner
2019-01-18 0:40 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1901180131510.1647-ecDvlHI5BZPZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
2019-01-18 12:34 ` Heiko Stuebner [this message]
2019-01-18 12:34 ` Heiko Stuebner
2019-01-24 11:41 ` sandy.huang
2019-01-24 11:41 ` sandy.huang
2018-08-30 21:12 ` [PATCH v8 3/3] drm/rockchip: Add directly output rgb feature for px30 Heiko Stuebner
2018-09-05 11:05 ` [PATCH v8 0/3] Add support rockchip RGB output interface Heiko Stuebner
2018-09-05 11:05 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636679.fMryThW7k8@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=eddie.cai.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=kstewart-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.