From: Thomas Monjalon <thomas@monjalon.net>
To: Levend Sayar <levendsayar@gmail.com>
Cc: dev@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] service: support C++ linkage
Date: Thu, 09 Jul 2020 16:24:46 +0200 [thread overview]
Message-ID: <1639172.O9IATTsscN@thomas> (raw)
In-Reply-To: <CAGDw98=bKEt7Ny9bWwWnh5DCCi3nx7qDdODvmgZyabgCsP7D2g@mail.gmail.com>
09/07/2020 15:56, Levend Sayar:
> On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 09/07/2020 14:32, levendsayar@gmail.com:
> > > From: Levend Sayar <levendsayar@gmail.com>
> > >
> > > "extern C" define is added to rte_service_component.h file
> > > to be able to use in C++ context
> >
> > It is a bug.
> > The title should be "service: fix C++ linkage"
> > And these tags must be added:
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Cc: stable@dpdk.org
> >
> > If you agree, I can do the change while merging.
>
> Sure I agree Thomas.
>
> Thanks in advance.
Applied, thanks
prev parent reply other threads:[~2020-07-09 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 12:25 [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file levendsayar
2020-07-07 14:19 ` Thomas Monjalon
2020-07-07 15:00 ` Van Haaren, Harry
2020-07-07 15:31 ` Levend Sayar
2020-07-09 12:32 ` [dpdk-dev] [PATCH v3] service: support C++ linkage levendsayar
2020-07-09 13:21 ` Thomas Monjalon
2020-07-09 13:56 ` Levend Sayar
2020-07-09 14:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1639172.O9IATTsscN@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=levendsayar@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.