All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: levendsayar@gmail.com
Cc: dev@dpdk.org, harry.van.haaren@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file
Date: Tue, 07 Jul 2020 16:19:12 +0200	[thread overview]
Message-ID: <6757103.nzWn3hy6JQ@thomas> (raw)
In-Reply-To: <20200707122516.28630-1-levendsayar@gmail.com>

07/07/2020 14:25, levendsayar@gmail.com:
> From: Levend Sayar <levendsayar@gmail.com>

Would be good to have a short explanation, even if obvious.

> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
>  lib/librte_eal/include/rte_service_component.h | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Is it the only file missing such C++ guard?



> --- a/lib/librte_eal/include/rte_service_component.h
> +++ b/lib/librte_eal/include/rte_service_component.h
> @@ -9,6 +9,11 @@
>   * Include this file if you are writing a component that requires CPU cycles to
>   * operate, and you wish to run the component using service cores
>   */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #include <rte_compat.h>
>  #include <rte_service.h>
>  
> @@ -130,4 +135,8 @@ int32_t rte_service_init(void);
>   */
>  void rte_service_finalize(void);
>  
> -#endif /* _SERVICE_PRIVATE_H_ */
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_SERVICE_PRIVATE_H_ */
> 






  reply	other threads:[~2020-07-07 14:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 12:25 [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file levendsayar
2020-07-07 14:19 ` Thomas Monjalon [this message]
2020-07-07 15:00   ` Van Haaren, Harry
2020-07-07 15:31     ` Levend Sayar
2020-07-09 12:32 ` [dpdk-dev] [PATCH v3] service: support C++ linkage levendsayar
2020-07-09 13:21   ` Thomas Monjalon
2020-07-09 13:56     ` Levend Sayar
2020-07-09 14:24       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6757103.nzWn3hy6JQ@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=levendsayar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.