* [PATCH] Fill speed_capa for virtio [not found] <20170202092357.58508-1-ibarnea@cisco.com> @ 2017-02-02 12:05 ` Ido Barnea (ibarnea) 2017-02-09 16:19 ` Thomas Monjalon 0 siblings, 1 reply; 6+ messages in thread From: Ido Barnea (ibarnea) @ 2017-02-02 12:05 UTC (permalink / raw) To: dev@dpdk.org From: Ido Barnea <ibarnea@cisco.com> Signed-off-by: Ido Barnea <ibarnea@cisco.com> --- drivers/net/virtio/virtio_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index d1ff234..1d572b5 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1869,6 +1869,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) (1ULL << VIRTIO_NET_F_HOST_TSO6); if ((hw->guest_features & tso_mask) == tso_mask) dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO; + dev_info->speed_capa = ETH_LINK_SPEED_10G; }/* -- 2.8.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fill speed_capa for virtio 2017-02-02 12:05 ` [PATCH] Fill speed_capa for virtio Ido Barnea (ibarnea) @ 2017-02-09 16:19 ` Thomas Monjalon 2017-02-10 7:49 ` Ido Barnea (ibarnea) 0 siblings, 1 reply; 6+ messages in thread From: Thomas Monjalon @ 2017-02-09 16:19 UTC (permalink / raw) To: Ido Barnea (ibarnea); +Cc: dev, Yuanhan Liu 2017-02-02 12:05, Ido Barnea: > From: Ido Barnea <ibarnea@cisco.com> > > Signed-off-by: Ido Barnea <ibarnea@cisco.com> > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index d1ff234..1d572b5 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1869,6 +1869,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > (1ULL << VIRTIO_NET_F_HOST_TSO6); > if ((hw->guest_features & tso_mask) == tso_mask) > dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO; > + dev_info->speed_capa = ETH_LINK_SPEED_10G; Why 10G ? Yuanhan, any opinion? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fill speed_capa for virtio 2017-02-09 16:19 ` Thomas Monjalon @ 2017-02-10 7:49 ` Ido Barnea (ibarnea) 2017-02-10 8:41 ` Thomas Monjalon 0 siblings, 1 reply; 6+ messages in thread From: Ido Barnea (ibarnea) @ 2017-02-10 7:49 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev@dpdk.org, Yuanhan Liu Just wanted this to be consistent with below (From virtio_dev_link_update): link.link_speed = SPEED_10G; Need to put some value in speed_capa. Ido On 09/02/2017, 6:19 PM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote: >2017-02-02 12:05, Ido Barnea: >> From: Ido Barnea <ibarnea@cisco.com> >> >> Signed-off-by: Ido Barnea <ibarnea@cisco.com> >> --- >> drivers/net/virtio/virtio_ethdev.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >> index d1ff234..1d572b5 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -1869,6 +1869,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) >> (1ULL << VIRTIO_NET_F_HOST_TSO6); >> if ((hw->guest_features & tso_mask) == tso_mask) >> dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO; >> + dev_info->speed_capa = ETH_LINK_SPEED_10G; > >Why 10G ? >Yuanhan, any opinion? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fill speed_capa for virtio 2017-02-10 7:49 ` Ido Barnea (ibarnea) @ 2017-02-10 8:41 ` Thomas Monjalon 2017-02-10 11:05 ` [PATCH v2] net/virtio: add speed capability Thomas Monjalon 0 siblings, 1 reply; 6+ messages in thread From: Thomas Monjalon @ 2017-02-10 8:41 UTC (permalink / raw) To: Ido Barnea (ibarnea); +Cc: dev, Yuanhan Liu 2017-02-10 07:49, Ido Barnea: > On 09/02/2017, 6:19 PM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote: > >2017-02-02 12:05, Ido Barnea: > >> From: Ido Barnea <ibarnea@cisco.com> > >> > >> Signed-off-by: Ido Barnea <ibarnea@cisco.com> > >> --- > >> drivers/net/virtio/virtio_ethdev.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > >> index d1ff234..1d572b5 100644 > >> --- a/drivers/net/virtio/virtio_ethdev.c > >> +++ b/drivers/net/virtio/virtio_ethdev.c > >> @@ -1869,6 +1869,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > >> (1ULL << VIRTIO_NET_F_HOST_TSO6); > >> if ((hw->guest_features & tso_mask) == tso_mask) > >> dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO; > >> + dev_info->speed_capa = ETH_LINK_SPEED_10G; > > > >Why 10G ? > >Yuanhan, any opinion? > > Just wanted this to be consistent with below (From virtio_dev_link_update): > link.link_speed = SPEED_10G; OK, that's the kind of justification which are good to have in the commit message. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] net/virtio: add speed capability 2017-02-10 8:41 ` Thomas Monjalon @ 2017-02-10 11:05 ` Thomas Monjalon 2017-02-10 11:06 ` Thomas Monjalon 0 siblings, 1 reply; 6+ messages in thread From: Thomas Monjalon @ 2017-02-10 11:05 UTC (permalink / raw) To: ibarnea; +Cc: dev From: Ido Barnea <ibarnea@cisco.com> The chosen fake capability (10G) is consistent with the reported link speed in virtio_dev_link_update(): link.link_speed = SPEED_10G; The feature is not marked in doc/guides/nics/features/virtio.ini as it is only a fake value. Signed-off-by: Ido Barnea <ibarnea@cisco.com> [Thomas: comments added] Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index d1ff234..4dc03b9 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1835,6 +1835,8 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) uint64_t tso_mask, host_features; struct virtio_hw *hw = dev->data->dev_private; + dev_info->speed_capa = ETH_LINK_SPEED_10G; /* fake value */ + dev_info->pci_dev = dev->device ? RTE_DEV_TO_PCI(dev->device) : NULL; dev_info->max_rx_queues = RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES); -- 2.7.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net/virtio: add speed capability 2017-02-10 11:05 ` [PATCH v2] net/virtio: add speed capability Thomas Monjalon @ 2017-02-10 11:06 ` Thomas Monjalon 0 siblings, 0 replies; 6+ messages in thread From: Thomas Monjalon @ 2017-02-10 11:06 UTC (permalink / raw) To: ibarnea; +Cc: dev 2017-02-10 12:05, Thomas Monjalon: > From: Ido Barnea <ibarnea@cisco.com> > > The chosen fake capability (10G) is consistent with the reported > link speed in virtio_dev_link_update(): > link.link_speed = SPEED_10G; > > The feature is not marked in doc/guides/nics/features/virtio.ini > as it is only a fake value. > > Signed-off-by: Ido Barnea <ibarnea@cisco.com> > [Thomas: comments added] > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> Applied, thanks ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-10 11:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170202092357.58508-1-ibarnea@cisco.com>
2017-02-02 12:05 ` [PATCH] Fill speed_capa for virtio Ido Barnea (ibarnea)
2017-02-09 16:19 ` Thomas Monjalon
2017-02-10 7:49 ` Ido Barnea (ibarnea)
2017-02-10 8:41 ` Thomas Monjalon
2017-02-10 11:05 ` [PATCH v2] net/virtio: add speed capability Thomas Monjalon
2017-02-10 11:06 ` Thomas Monjalon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.