[PATCH net-next] ref_tracker: remove filter_irq_stacks() call

[PATCH net-next] ref_tracker: remove filter_irq_stacks() call

[Eric Dumazet]

From: Eric Dumazet <edumazet@google.com>

After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
in stack_depot_save()") it became unnecessary to filter the stack
before calling stack_depot_save().

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Marco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
---
 lib/ref_tracker.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
index 9c0c2e09df666d19aba441f568762afbd1cad4d0..dc7b14aa3431e2bf7a97a7e78220f04da144563d 100644
--- a/lib/ref_tracker.c
+++ b/lib/ref_tracker.c
@@ -89,7 +89,6 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
 		return -ENOMEM;
 	}
 	nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
-	nr_entries = filter_irq_stacks(entries, nr_entries);
 	tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
 
 	spin_lock_irqsave(&dir->lock, flags);
@@ -120,7 +119,6 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
 		return -EEXIST;
 	}
 	nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
-	nr_entries = filter_irq_stacks(entries, nr_entries);
 	stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
 
 	spin_lock_irqsave(&dir->lock, flags);
-- 
2.35.0.263.gb82422642f-goog

Re: [PATCH net-next] ref_tracker: remove filter_irq_stacks() call

[Marco Elver]

On Sat, 5 Feb 2022 at 18:27, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
> in stack_depot_save()") it became unnecessary to filter the stack
> before calling stack_depot_save().
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Marco Elver <elver@google.com>

Reviewed-by: Marco Elver <elver@google.com>


> Cc: Alexander Potapenko <glider@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> ---
>  lib/ref_tracker.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
> index 9c0c2e09df666d19aba441f568762afbd1cad4d0..dc7b14aa3431e2bf7a97a7e78220f04da144563d 100644
> --- a/lib/ref_tracker.c
> +++ b/lib/ref_tracker.c
> @@ -89,7 +89,6 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
>                 return -ENOMEM;
>         }
>         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
> -       nr_entries = filter_irq_stacks(entries, nr_entries);
>         tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
>
>         spin_lock_irqsave(&dir->lock, flags);
> @@ -120,7 +119,6 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
>                 return -EEXIST;
>         }
>         nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
> -       nr_entries = filter_irq_stacks(entries, nr_entries);
>         stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
>
>         spin_lock_irqsave(&dir->lock, flags);
> --
> 2.35.0.263.gb82422642f-goog
>

Re: [PATCH net-next] ref_tracker: remove filter_irq_stacks() call

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Sat,  5 Feb 2022 09:27:11 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
> in stack_depot_save()") it became unnecessary to filter the stack
> before calling stack_depot_save().
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Marco Elver <elver@google.com>
> Cc: Alexander Potapenko <glider@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> 
> [...]

Here is the summary with links:
  - [net-next] ref_tracker: remove filter_irq_stacks() call
    https://git.kernel.org/netdev/net-next/c/c2d1e3df4af5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html