All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: lxu <liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v7] eal: map uio resources after hugepages.
Date: Fri, 07 Nov 2014 16:15:06 +0100	[thread overview]
Message-ID: <1646488.MLiSkxW7Wj@xps13> (raw)
In-Reply-To: <1415372269-8723-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>

Hi Liang,

I see you are learning how to send a patch. It's a good thing.
I don't know if the idea of your patch will be accepted but here are more tips
about formatting:
- You should use checkpatch.pl from kernel.org and fix the most important issues
- The commit log should be wrapped to avoid long lines
- The title is important. You didn't update it for vfio.
And there should be no point at the end of the title.
- You should use your real name in Signed-off-by.
- You should annotate each new version to show the changes

See http://dpdk.org/dev#send and 
https://www.kernel.org/doc/Documentation/SubmittingPatches

Looking at other submissions could be inspiring also.

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-11-07 15:15 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 13:25 [PATCH] eal: map uio resources after hugepages when the base_virtaddr is configured lxu
2014-11-05 15:49 ` 答复： " XU Liang
     [not found]   ` <01d6ff37-3473-43af-aff3-1183d4c4768a-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-05 15:59     ` Burakov, Anatoly
2014-11-05 16:10   ` 答复：答复： " XU Liang
     [not found]     ` <7600981e-fc3a-454b-a269-51dd3b9d535b-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-05 16:19       ` Burakov, Anatoly
2014-11-26  1:46     ` Qiu, Michael
     [not found]       ` <533710CFB86FA344BFBF2D6802E60286C9A738-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-26  9:58         ` Burakov, Anatoly
     [not found] ` <1415193919-17361-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-05 15:10   ` Burakov, Anatoly
2014-11-06 14:11   ` [PATCH v2] " lxu
     [not found]     ` <1415283104-29970-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-06 14:27       ` Burakov, Anatoly
2014-11-06 14:48     ` 答复：[PATCH " 徐亮
2014-11-06 14:47   ` [PATCH v3] " lxu
     [not found]     ` <1415285223-7662-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-06 14:58       ` Burakov, Anatoly
2014-11-06 15:06       ` De Lara Guarch, Pablo
2014-11-06 15:07   ` [PATCH v4] " lxu
     [not found]     ` <1415286460-14337-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-06 15:12       ` Thomas Monjalon
2014-11-06 15:11   ` lxu
2014-11-06 15:32   ` [PATCH v5] " lxu
     [not found]     ` <1415287928-14513-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-06 15:41       ` Burakov, Anatoly
     [not found]         ` <C6ECDF3AB251BE4894318F4E4512369780C07670-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-06 15:58           ` Thomas Monjalon
2014-11-06 16:10             ` Burakov, Anatoly
     [not found]               ` <C6ECDF3AB251BE4894318F4E4512369780C0769D-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-06 17:30                 ` Bruce Richardson
2014-11-07  8:01   ` [PATCH v6] " lxu
2014-11-07  9:57     ` XU Liang
     [not found]       ` <2c2ad9a4-1c04-4641-9667-249617ae2c56-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-07 10:00         ` Burakov, Anatoly
2014-11-07 14:37       ` XU Liang
     [not found]     ` <1415347284-15468-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-07  9:42       ` Bruce Richardson
2014-11-07  9:47       ` Burakov, Anatoly
2014-11-10 11:34       ` [PATCH v7] eal: map PCI memory resources after hugepages Anatoly Burakov
     [not found]         ` <1415619272-8281-1-git-send-email-anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-10 13:33           ` Burakov, Anatoly
2014-11-11 10:09           ` [PATCH v8] " Anatoly Burakov
     [not found]             ` <1415700565-19157-1-git-send-email-anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-13 11:34               ` Burakov, Anatoly
     [not found]                 ` <C6ECDF3AB251BE4894318F4E4512369780C08733-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-13 12:58                   ` Bruce Richardson
2014-11-13 13:44                     ` Burakov, Anatoly
2014-11-13 13:46               ` Bruce Richardson
2014-11-25 17:17                 ` Thomas Monjalon
2014-11-11  3:53         ` [PATCH v7] " XU Liang
2014-11-07 14:57   ` [PATCH v7] eal: map uio " lxu
     [not found]     ` <1415372269-8723-1-git-send-email-liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org>
2014-11-07 15:14       ` Burakov, Anatoly
2014-11-07 15:15       ` Thomas Monjalon [this message]
2014-11-07 15:19     ` XU Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1646488.MLiSkxW7Wj@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=liang.xu-uqgZSDCUmcY3TOWNJCPdyQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.