From: patchwork-bot+netdevbpf@kernel.org <patchwork-bot+netdevbpf@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] iavf: Fix hang during reboot/shutdown
Date: Thu, 17 Mar 2022 17:30:10 +0000 [thread overview]
Message-ID: <164753821041.18148.18371834724218825935.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220317104524.2802848-1-ivecera@redhat.com>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Mar 2022 11:45:24 +0100 you wrote:
> Recent commit 974578017fc1 ("iavf: Add waiting so the port is
> initialized in remove") adds a wait-loop at the beginning of
> iavf_remove() to ensure that port initialization is finished
> prior unregistering net device. This causes a regression
> in reboot/shutdown scenario because in this case callback
> iavf_shutdown() is called and this callback detaches the device,
> makes it down if it is running and sets its state to __IAVF_REMOVE.
> Later shutdown callback of associated PF driver (e.g. ice_shutdown)
> is called. That callback calls among other things sriov_disable()
> that calls indirectly iavf_remove() (see stack trace below).
> As the adapter state is already __IAVF_REMOVE then the mentioned
> loop is end-less and shutdown process hangs.
>
> [...]
Here is the summary with links:
- iavf: Fix hang during reboot/shutdown
https://git.kernel.org/netdev/net/c/b04683ff8f08
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, poros@redhat.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
slawomirx.laba@intel.com, mateusz.palczewski@intel.com,
jacob.e.keller@intel.com, phani.r.burra@intel.com,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iavf: Fix hang during reboot/shutdown
Date: Thu, 17 Mar 2022 17:30:10 +0000 [thread overview]
Message-ID: <164753821041.18148.18371834724218825935.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220317104524.2802848-1-ivecera@redhat.com>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Mar 2022 11:45:24 +0100 you wrote:
> Recent commit 974578017fc1 ("iavf: Add waiting so the port is
> initialized in remove") adds a wait-loop at the beginning of
> iavf_remove() to ensure that port initialization is finished
> prior unregistering net device. This causes a regression
> in reboot/shutdown scenario because in this case callback
> iavf_shutdown() is called and this callback detaches the device,
> makes it down if it is running and sets its state to __IAVF_REMOVE.
> Later shutdown callback of associated PF driver (e.g. ice_shutdown)
> is called. That callback calls among other things sriov_disable()
> that calls indirectly iavf_remove() (see stack trace below).
> As the adapter state is already __IAVF_REMOVE then the mentioned
> loop is end-less and shutdown process hangs.
>
> [...]
Here is the summary with links:
- iavf: Fix hang during reboot/shutdown
https://git.kernel.org/netdev/net/c/b04683ff8f08
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2022-03-17 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 10:45 [Intel-wired-lan] [PATCH] iavf: Fix hang during reboot/shutdown Ivan Vecera
2022-03-17 10:45 ` Ivan Vecera
2022-03-17 16:11 ` [Intel-wired-lan] " Jakub Kicinski
2022-03-17 16:11 ` Jakub Kicinski
2022-03-17 17:03 ` [Intel-wired-lan] " Tony Nguyen
2022-03-17 17:03 ` Tony Nguyen
2022-03-17 17:18 ` [Intel-wired-lan] " Jakub Kicinski
2022-03-17 17:30 ` patchwork-bot+netdevbpf [this message]
2022-03-17 17:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164753821041.18148.18371834724218825935.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.