Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies

[Nicolas Frattaroli <frattaroli.nicolas@gmail.com>]

On Dienstag, 19. Oktober 2021 15:06:31 CEST Christian König wrote:
> 
> Am 19.10.21 um 14:35 schrieb Daniel Vetter:
> > On Tue, Oct 19, 2021 at 01:27:06PM +0200, Christian König wrote:
> >> Trivial fix since we now need to grab a reference to the fence we have
> >> added. Previously the dma_resv function where doing that for us.
> >>
> >> Signed-off-by: Christian König <christian.koenig@amd.com>
> >> Fixes: 9c2ba265352a drm/scheduler: ("use new iterator in drm_sched_job_add_implicit_dependencies v2")
> > Uh I completely missed checking for that. Did you review all other
> > conversions you've pushed for this kind of bug?
> 
> Yeah, currently double checking that.
> 
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Also
> >
> > Reported-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbook/
> >
> > It's important to credit bug reporters! Also upgrade to t-b if Nicolas
> > gets around to testing quickly.
> 
> Yeah, the credit part is certainly correct. I just usually ask people 
> before adding their mail address to kernel commits because of the spam 
> you get :)
> 
> Cheers,
> Christian.

No worries, I made this e-mail address specifically for kernel work due
to this. I wouldn't even dare posting on public mailing lists with my
regular e-mail address.

Regards,
Nicolas Frattaroli

> 
> >
> > Cheers, Daniel
> >
> >> ---
> >>   drivers/gpu/drm/scheduler/sched_main.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> >> index 5bc5f775abe1..94fe51b3caa2 100644
> >> --- a/drivers/gpu/drm/scheduler/sched_main.c
> >> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> >> @@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job,
> >>   		ret = drm_sched_job_add_dependency(job, fence);
> >>   		if (ret)
> >>   			return ret;
> >> +
> >> +		/* Make sure to grab an additional ref on the added fence */
> >> +		dma_fence_get(fence);
> >>   	}
> >>   	return 0;
> >>   }
> >>
> 
>