From: patchwork-bot+netdevbpf@kernel.org
To: dccp@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] ipv4: First steps toward removing RTO_ONLINK
Date: Fri, 22 Apr 2022 12:50:12 +0000 [thread overview]
Message-ID: <165063181235.24908.15151109016653470553.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <cover.1650470610.git.gnault@redhat.com>
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 21 Apr 2022 01:21:19 +0200 you wrote:
> RTO_ONLINK is a flag that allows to reduce the scope of route lookups.
> It's stored in a normally unused bit of the ->flowi4_tos field, in
> struct flowi4. However it has several problems:
>
> * This bit is also used by ECN. Although ECN bits are supposed to be
> cleared before doing a route lookup, it happened that some code
> paths didn't properly sanitise their ->flowi4_tos. So this mechanism
> is fragile and we had bugs in the past where ECN bits slipped in and
> could end up being erroneously interpreted as RTO_ONLINK.
>
> [...]
Here is the summary with links:
- [net-next,1/3] ipv4: Don't reset ->flowi4_scope in ip_rt_fix_tos().
https://git.kernel.org/netdev/net-next/c/16a28267774c
- [net-next,2/3] ipv4: Avoid using RTO_ONLINK with ip_route_connect().
https://git.kernel.org/netdev/net-next/c/67e1e2f4854b
- [net-next,3/3] ipv4: Initialise ->flowi4_scope properly in ICMP handlers.
https://git.kernel.org/netdev/net-next/c/b1ad41384866
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Guillaume Nault <gnault@redhat.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
dsahern@kernel.org, dccp@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] ipv4: First steps toward removing RTO_ONLINK
Date: Fri, 22 Apr 2022 12:50:12 +0000 [thread overview]
Message-ID: <165063181235.24908.15151109016653470553.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <cover.1650470610.git.gnault@redhat.com>
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 21 Apr 2022 01:21:19 +0200 you wrote:
> RTO_ONLINK is a flag that allows to reduce the scope of route lookups.
> It's stored in a normally unused bit of the ->flowi4_tos field, in
> struct flowi4. However it has several problems:
>
> * This bit is also used by ECN. Although ECN bits are supposed to be
> cleared before doing a route lookup, it happened that some code
> paths didn't properly sanitise their ->flowi4_tos. So this mechanism
> is fragile and we had bugs in the past where ECN bits slipped in and
> could end up being erroneously interpreted as RTO_ONLINK.
>
> [...]
Here is the summary with links:
- [net-next,1/3] ipv4: Don't reset ->flowi4_scope in ip_rt_fix_tos().
https://git.kernel.org/netdev/net-next/c/16a28267774c
- [net-next,2/3] ipv4: Avoid using RTO_ONLINK with ip_route_connect().
https://git.kernel.org/netdev/net-next/c/67e1e2f4854b
- [net-next,3/3] ipv4: Initialise ->flowi4_scope properly in ICMP handlers.
https://git.kernel.org/netdev/net-next/c/b1ad41384866
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2022-04-22 12:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 23:21 [PATCH net-next 0/3] ipv4: First steps toward removing RTO_ONLINK Guillaume Nault
2022-04-20 23:21 ` Guillaume Nault
2022-04-20 23:21 ` [PATCH net-next 3/3] ipv4: Initialise ->flowi4_scope properly in ICMP handlers Guillaume Nault
2022-04-22 3:08 ` David Ahern
2022-04-22 3:10 ` [PATCH net-next 0/3] ipv4: First steps toward removing RTO_ONLINK David Ahern
2022-04-22 3:10 ` David Ahern
2022-04-22 11:02 ` Guillaume Nault
2022-04-22 11:02 ` Guillaume Nault
2022-04-22 12:50 ` patchwork-bot+netdevbpf [this message]
2022-04-22 12:50 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-04-20 23:21 [PATCH net-next 1/3] ipv4: Don't reset ->flowi4_scope in ip_rt_fix_tos() Guillaume Nault
2022-04-20 23:21 ` Guillaume Nault
2022-04-22 2:30 ` David Ahern
2022-04-22 2:30 ` David Ahern
2022-04-22 10:53 ` Guillaume Nault
2022-04-22 10:53 ` Guillaume Nault
2022-04-22 14:40 ` David Ahern
2022-04-22 14:40 ` David Ahern
2022-04-25 10:04 ` Guillaume Nault
2022-04-25 10:04 ` Guillaume Nault
2022-04-20 23:21 [PATCH net-next 2/3] ipv4: Avoid using RTO_ONLINK with ip_route_connect() Guillaume Nault
2022-04-20 23:21 ` Guillaume Nault
2022-04-22 2:32 ` David Ahern
2022-04-22 2:32 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165063181235.24908.15151109016653470553.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.