Re: [PATCH v5 0/3] OMAP 3 CSI-2 configuration

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thanks for the patches.

For the whole series,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Tony, do you want to take patch 1/3 in your tree, or can I push the whole 
series through mine ?

On Sunday 14 October 2012 13:31:22 Sakari Ailus wrote:
> Hi all,
> 
> This is an update to an old patchset for CSI-2 configuration for OMAP 3430
> and 3630. The patches have been tested on the 3630 only so far, and I don't
> plan to test them on 3430 in the near future.
> 
> I've made changes according to Laurent's suggestions to the patches, with
> the exception of alignment of a certain line. I think it's exactly as it
> should be. :-)
> 
> I'm not quite certain about the comment regarding the control register state
> dependency to the CORE power domain, and why exactly this isn't an issue.
> We know the MPU must stay powered since the ISP can't wake up MPU, but how
> is this related to CORE? In the end it seems to work.
> 
> If you think this should be changed and you also know how, please provide me
> the text. :-)
> 
> 	/*
> 	 * The PHY configuration is lost in off mode, that's not an
> 	 * issue since the MPU power domain is forced on whilst the
> 	 * ISP is in use.
> 	 */
> 
> Comments, questions and other kind of feedback is very welcome.
> 
> Kind regards,

-- 
Regards,

Laurent Pinchart