From: patchwork-bot+netdevbpf@kernel.org
To: Lina Wang <lina.wang@mediatek.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
shuah@kernel.org, matthias.bgg@gmail.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, hawk@kernel.org,
nathan@kernel.org, ndesaulniers@google.com, edumazet@google.com,
willemb@google.com, maze@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, llvm@lists.linux.dev
Subject: Re: [PATCH v6 1/2] net: fix wrong network header length
Date: Mon, 09 May 2022 10:00:12 +0000 [thread overview]
Message-ID: <165209041219.866.7810964831911496184.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220505054850.4878-1-lina.wang@mediatek.com>
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 5 May 2022 13:48:49 +0800 you wrote:
> When clatd starts with ebpf offloaing, and NETIF_F_GRO_FRAGLIST is enable,
> several skbs are gathered in skb_shinfo(skb)->frag_list. The first skb's
> ipv6 header will be changed to ipv4 after bpf_skb_proto_6_to_4,
> network_header\transport_header\mac_header have been updated as ipv4 acts,
> but other skbs in frag_list didnot update anything, just ipv6 packets.
>
> udp_queue_rcv_skb will call skb_segment_list to traverse other skbs in
> frag_list and make sure right udp payload is delivered to user space.
> Unfortunately, other skbs in frag_list who are still ipv6 packets are
> updated like the first skb and will have wrong transport header length.
>
> [...]
Here is the summary with links:
- [v6,1/2] net: fix wrong network header length
https://git.kernel.org/netdev/net/c/cf3ab8d4a797
- [v6,2/2] selftests net: add UDP GRO fraglist + bpf self-tests
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Lina Wang <lina.wang@mediatek.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
shuah@kernel.org, matthias.bgg@gmail.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, hawk@kernel.org,
nathan@kernel.org, ndesaulniers@google.com, edumazet@google.com,
willemb@google.com, maze@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, llvm@lists.linux.dev
Subject: Re: [PATCH v6 1/2] net: fix wrong network header length
Date: Mon, 09 May 2022 10:00:12 +0000 [thread overview]
Message-ID: <165209041219.866.7810964831911496184.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220505054850.4878-1-lina.wang@mediatek.com>
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 5 May 2022 13:48:49 +0800 you wrote:
> When clatd starts with ebpf offloaing, and NETIF_F_GRO_FRAGLIST is enable,
> several skbs are gathered in skb_shinfo(skb)->frag_list. The first skb's
> ipv6 header will be changed to ipv4 after bpf_skb_proto_6_to_4,
> network_header\transport_header\mac_header have been updated as ipv4 acts,
> but other skbs in frag_list didnot update anything, just ipv6 packets.
>
> udp_queue_rcv_skb will call skb_segment_list to traverse other skbs in
> frag_list and make sure right udp payload is delivered to user space.
> Unfortunately, other skbs in frag_list who are still ipv6 packets are
> updated like the first skb and will have wrong transport header length.
>
> [...]
Here is the summary with links:
- [v6,1/2] net: fix wrong network header length
https://git.kernel.org/netdev/net/c/cf3ab8d4a797
- [v6,2/2] selftests net: add UDP GRO fraglist + bpf self-tests
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Lina Wang <lina.wang@mediatek.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
shuah@kernel.org, matthias.bgg@gmail.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, hawk@kernel.org,
nathan@kernel.org, ndesaulniers@google.com, edumazet@google.com,
willemb@google.com, maze@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, llvm@lists.linux.dev
Subject: Re: [PATCH v6 1/2] net: fix wrong network header length
Date: Mon, 09 May 2022 10:00:12 +0000 [thread overview]
Message-ID: <165209041219.866.7810964831911496184.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220505054850.4878-1-lina.wang@mediatek.com>
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 5 May 2022 13:48:49 +0800 you wrote:
> When clatd starts with ebpf offloaing, and NETIF_F_GRO_FRAGLIST is enable,
> several skbs are gathered in skb_shinfo(skb)->frag_list. The first skb's
> ipv6 header will be changed to ipv4 after bpf_skb_proto_6_to_4,
> network_header\transport_header\mac_header have been updated as ipv4 acts,
> but other skbs in frag_list didnot update anything, just ipv6 packets.
>
> udp_queue_rcv_skb will call skb_segment_list to traverse other skbs in
> frag_list and make sure right udp payload is delivered to user space.
> Unfortunately, other skbs in frag_list who are still ipv6 packets are
> updated like the first skb and will have wrong transport header length.
>
> [...]
Here is the summary with links:
- [v6,1/2] net: fix wrong network header length
https://git.kernel.org/netdev/net/c/cf3ab8d4a797
- [v6,2/2] selftests net: add UDP GRO fraglist + bpf self-tests
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-09 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 5:48 [PATCH v6 1/2] net: fix wrong network header length Lina Wang
2022-05-05 5:48 ` [PATCH v6 2/2] selftests net: add UDP GRO fraglist + bpf self-tests Lina Wang
2022-05-09 10:00 ` patchwork-bot+netdevbpf [this message]
2022-05-09 10:00 ` [PATCH v6 1/2] net: fix wrong network header length patchwork-bot+netdevbpf
2022-05-09 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165209041219.866.7810964831911496184.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=lina.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=maze@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.