From: Rob Herring <robh@kernel.org>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Cc: wenst@chromium.org, linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
chunkuang.hu@kernel.org, daniel@ffwll.ch, matthias.bgg@gmail.com,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
granquet@baylibre.com, airlied@linux.ie, p.zabel@pengutronix.de,
linux-fbdev@vger.kernel.org, ck.hu@mediatek.com,
tzimmermann@suse.de, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, mripard@kernel.org,
dri-devel@lists.freedesktop.org, deller@gmx.de, msp@baylibre.com,
jitao.shi@mediatek.com
Subject: Re: [PATCH v11 01/10] dt-bindings: mediatek,dp: Add Display Port binding
Date: Fri, 10 Jun 2022 07:12:35 -0600 [thread overview]
Message-ID: <1654866755.768151.1529406.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220610105522.13449-2-rex-bc.chen@mediatek.com>
On Fri, 10 Jun 2022 18:55:13 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This controller is present on several mediatek hardware. Currently
> mt8195 and mt8395 have this controller without a functional difference,
> so only one compatible field is added.
>
> The controller can have two forms, as a normal display port and as an
> embedded display port.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> [Bo-Chen: Fix reviewers' comment]
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> .../display/mediatek/mediatek,dp.yaml | 101 ++++++++++++++++++
> 1 file changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-lanes: b'\x04' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-linkrate: b'\x1f\xa4' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Cc: wenst@chromium.org, linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
chunkuang.hu@kernel.org, daniel@ffwll.ch, matthias.bgg@gmail.com,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
granquet@baylibre.com, airlied@linux.ie, p.zabel@pengutronix.de,
linux-fbdev@vger.kernel.org, ck.hu@mediatek.com,
tzimmermann@suse.de, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, mripard@kernel.org,
dri-devel@lists.freedesktop.org, deller@gmx.de, msp@baylibre.com,
jitao.shi@mediatek.com
Subject: Re: [PATCH v11 01/10] dt-bindings: mediatek,dp: Add Display Port binding
Date: Fri, 10 Jun 2022 07:12:35 -0600 [thread overview]
Message-ID: <1654866755.768151.1529406.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220610105522.13449-2-rex-bc.chen@mediatek.com>
On Fri, 10 Jun 2022 18:55:13 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This controller is present on several mediatek hardware. Currently
> mt8195 and mt8395 have this controller without a functional difference,
> so only one compatible field is added.
>
> The controller can have two forms, as a normal display port and as an
> embedded display port.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> [Bo-Chen: Fix reviewers' comment]
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> .../display/mediatek/mediatek,dp.yaml | 101 ++++++++++++++++++
> 1 file changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-lanes: b'\x04' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-linkrate: b'\x1f\xa4' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Cc: wenst@chromium.org, linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
chunkuang.hu@kernel.org, daniel@ffwll.ch, matthias.bgg@gmail.com,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
granquet@baylibre.com, airlied@linux.ie, p.zabel@pengutronix.de,
linux-fbdev@vger.kernel.org, ck.hu@mediatek.com,
tzimmermann@suse.de, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, mripard@kernel.org,
dri-devel@lists.freedesktop.org, deller@gmx.de, msp@baylibre.com,
jitao.shi@mediatek.com
Subject: Re: [PATCH v11 01/10] dt-bindings: mediatek,dp: Add Display Port binding
Date: Fri, 10 Jun 2022 07:12:35 -0600 [thread overview]
Message-ID: <1654866755.768151.1529406.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220610105522.13449-2-rex-bc.chen@mediatek.com>
On Fri, 10 Jun 2022 18:55:13 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This controller is present on several mediatek hardware. Currently
> mt8195 and mt8395 have this controller without a functional difference,
> so only one compatible field is added.
>
> The controller can have two forms, as a normal display port and as an
> embedded display port.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> [Bo-Chen: Fix reviewers' comment]
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> .../display/mediatek/mediatek,dp.yaml | 101 ++++++++++++++++++
> 1 file changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-lanes: b'\x04' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-linkrate: b'\x1f\xa4' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Cc: linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
krzysztof.kozlowski+dt@linaro.org, deller@gmx.de,
Project_Global_Chrome_Upstream_Group@mediatek.com,
wenst@chromium.org, chunkuang.hu@kernel.org,
jitao.shi@mediatek.com, msp@baylibre.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com, granquet@baylibre.com,
linux-kernel@vger.kernel.org, tzimmermann@suse.de
Subject: Re: [PATCH v11 01/10] dt-bindings: mediatek, dp: Add Display Port binding
Date: Fri, 10 Jun 2022 07:12:35 -0600 [thread overview]
Message-ID: <1654866755.768151.1529406.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220610105522.13449-2-rex-bc.chen@mediatek.com>
On Fri, 10 Jun 2022 18:55:13 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This controller is present on several mediatek hardware. Currently
> mt8195 and mt8395 have this controller without a functional difference,
> so only one compatible field is added.
>
> The controller can have two forms, as a normal display port and as an
> embedded display port.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> [Bo-Chen: Fix reviewers' comment]
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
> .../display/mediatek/mediatek,dp.yaml | 101 ++++++++++++++++++
> 1 file changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-lanes: b'\x04' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.example.dtb: dp_tx@1c600000: max-linkrate: b'\x1f\xa4' is not of type 'object', 'array', 'boolean', 'null'
From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/dt-core.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-06-10 13:12 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 10:55 [PATCH v11 00/10] drm/mediatek: Add MT8195 DisplayPort driver Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 01/10] dt-bindings: mediatek,dp: Add Display Port binding Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 13:12 ` Rob Herring [this message]
2022-06-10 13:12 ` [PATCH v11 01/10] dt-bindings: mediatek, dp: " Rob Herring
2022-06-10 13:12 ` [PATCH v11 01/10] dt-bindings: mediatek,dp: " Rob Herring
2022-06-10 13:12 ` Rob Herring
2022-06-14 20:23 ` Rob Herring
2022-06-14 20:23 ` Rob Herring
2022-06-14 20:23 ` Rob Herring
2022-06-14 20:23 ` Rob Herring
2022-06-16 13:22 ` Rex-BC Chen
2022-06-16 13:22 ` Rex-BC Chen
2022-06-16 13:22 ` Rex-BC Chen
2022-06-16 21:28 ` Rob Herring
2022-06-16 21:28 ` Rob Herring
2022-06-16 21:28 ` Rob Herring
2022-06-17 2:45 ` Rex-BC Chen
2022-06-17 2:45 ` Rex-BC Chen
2022-06-17 2:45 ` Rex-BC Chen
2022-06-10 10:55 ` [PATCH v11 02/10] drm/edid: Convert cea_sad helper struct to kernelDoc Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 03/10] drm/edid: Add cea_sad helpers for freq/length Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 04/10] video/hdmi: Add audio_infoframe packing for DP Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-15 2:58 ` CK Hu
2022-06-15 2:58 ` CK Hu
2022-06-15 2:58 ` CK Hu
2022-06-15 2:58 ` CK Hu
2022-06-17 8:26 ` Rex-BC Chen
2022-06-17 8:26 ` Rex-BC Chen
2022-06-17 8:26 ` Rex-BC Chen
2022-06-15 3:06 ` CK Hu
2022-06-15 3:06 ` CK Hu
2022-06-15 3:06 ` CK Hu
2022-06-15 3:06 ` CK Hu
2022-06-17 8:27 ` Rex-BC Chen
2022-06-17 8:27 ` Rex-BC Chen
2022-06-17 8:27 ` Rex-BC Chen
2022-06-15 5:50 ` CK Hu
2022-06-15 5:50 ` CK Hu
2022-06-15 5:50 ` CK Hu
2022-06-15 5:50 ` CK Hu
2022-06-15 6:33 ` CK Hu
2022-06-15 6:33 ` CK Hu
2022-06-15 6:33 ` CK Hu
2022-06-15 6:33 ` CK Hu
2022-06-17 8:28 ` Rex-BC Chen
2022-06-17 8:28 ` Rex-BC Chen
2022-06-17 8:28 ` Rex-BC Chen
2022-06-15 5:53 ` CK Hu
2022-06-15 5:53 ` CK Hu
2022-06-15 5:53 ` CK Hu
2022-06-15 5:53 ` CK Hu
2022-06-17 8:29 ` Rex-BC Chen
2022-06-17 8:29 ` Rex-BC Chen
2022-06-17 8:29 ` Rex-BC Chen
2022-06-15 6:52 ` CK Hu
2022-06-15 6:52 ` CK Hu
2022-06-15 6:52 ` CK Hu
2022-06-15 6:52 ` CK Hu
2022-06-20 3:12 ` CK Hu
2022-06-20 3:12 ` CK Hu
2022-06-20 3:12 ` CK Hu
2022-06-20 3:19 ` CK Hu
2022-06-20 3:19 ` CK Hu
2022-06-20 3:19 ` CK Hu
2022-06-21 12:21 ` Rex-BC Chen
2022-06-21 12:21 ` Rex-BC Chen
2022-06-21 12:21 ` Rex-BC Chen
2022-06-21 12:19 ` Rex-BC Chen
2022-06-21 12:19 ` Rex-BC Chen
2022-06-21 12:19 ` Rex-BC Chen
2022-06-20 3:29 ` CK Hu
2022-06-20 3:29 ` CK Hu
2022-06-20 3:29 ` CK Hu
2022-06-20 3:45 ` CK Hu
2022-06-20 3:45 ` CK Hu
2022-06-20 3:45 ` CK Hu
2022-06-20 3:54 ` CK Hu
2022-06-20 3:54 ` CK Hu
2022-06-20 3:54 ` CK Hu
2022-06-21 12:36 ` Rex-BC Chen
2022-06-21 12:36 ` Rex-BC Chen
2022-06-21 12:36 ` Rex-BC Chen
2022-06-20 6:49 ` CK Hu
2022-06-20 6:49 ` CK Hu
2022-06-20 6:49 ` CK Hu
2022-06-21 6:12 ` CK Hu
2022-06-21 6:12 ` CK Hu
2022-06-21 6:12 ` CK Hu
2022-06-21 7:27 ` CK Hu
2022-06-21 7:27 ` CK Hu
2022-06-21 7:27 ` CK Hu
2022-06-21 7:30 ` CK Hu
2022-06-21 7:30 ` CK Hu
2022-06-21 7:30 ` CK Hu
2022-06-21 8:05 ` CK Hu
2022-06-21 8:05 ` CK Hu
2022-06-21 8:05 ` CK Hu
2022-06-10 10:55 ` [PATCH v11 06/10] drm/mediatek: Add MT8195 External DisplayPort support Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 07/10] drm/mediatek: add hpd debounce Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 08/10] drm/mediatek: set monitor to DP_SET_POWER_D3 to avoid garbage Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 09/10] drm/mediatek: DP audio support for MT8195 Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` [PATCH v11 10/10] drm/mediatek: fix no audio when resolution change Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
2022-06-10 10:55 ` Bo-Chen Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1654866755.768151.1529406.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.