* [PATCH -next] octeontx2-af: fix error return code in rvu_npc_exact_init()
@ 2022-07-13 9:56 Yang Yingliang
2022-07-13 14:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-07-13 9:56 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: rkannoth, sgoutham, davem
If rvu_npc_exact_save_drop_rule_chan_and_mask() returns false,
the 'err' is uninitialized, return -EINVAL instead.
Fixes: c6238bc0614d ("octeontx2-af: Drop rules for NPC MCAM")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
index ed8b9afbf731..563bf1497fd0 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
@@ -1961,7 +1961,7 @@ int rvu_npc_exact_init(struct rvu *rvu)
dev_err(rvu->dev,
"%s: failed to set drop info for cgx=%d, lmac=%d, chan=%llx\n",
__func__, cgx_id, lmac_id, chan_val);
- return err;
+ return -EINVAL;
}
err = npc_install_mcam_drop_rule(rvu, *drop_mcam_idx,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] octeontx2-af: fix error return code in rvu_npc_exact_init()
2022-07-13 9:56 [PATCH -next] octeontx2-af: fix error return code in rvu_npc_exact_init() Yang Yingliang
@ 2022-07-13 14:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-13 14:00 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, rkannoth, sgoutham, davem
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 13 Jul 2022 17:56:00 +0800 you wrote:
> If rvu_npc_exact_save_drop_rule_chan_and_mask() returns false,
> the 'err' is uninitialized, return -EINVAL instead.
>
> Fixes: c6238bc0614d ("octeontx2-af: Drop rules for NPC MCAM")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> [...]
Here is the summary with links:
- [-next] octeontx2-af: fix error return code in rvu_npc_exact_init()
https://git.kernel.org/netdev/net-next/c/6a605eb1d71e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-13 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-13 9:56 [PATCH -next] octeontx2-af: fix error return code in rvu_npc_exact_init() Yang Yingliang
2022-07-13 14:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.