From: Tomasz Figa <t.figa@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linaro-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: Disable I2C controllers by default on Exynos5250
Date: Thu, 12 Sep 2013 17:55:59 +0200 [thread overview]
Message-ID: <1657964.f1bIFjAZ98@amdc1227> (raw)
In-Reply-To: <20130912135233.GS29403@sirena.org.uk>
On Thursday 12 of September 2013 14:52:33 Mark Brown wrote:
> On Thu, Sep 12, 2013 at 02:58:59PM +0200, Tomasz Figa wrote:
> > On Thursday 12 of September 2013 11:40:27 Mark Brown wrote:
> Please delete unneeded context from your mails, it makes it much easier
> to find the new content.
I always snip unnecessary parts of quoted message if its really long, but
if its length is in acceptable range then I try to keep the whole message
just for reference.
> > > + i2c@12CA0000 {
> > > + status = "okay";
> >
> > Hmm, no other properties needed here?
>
> Apparently not, it looks like the binding for the aribtrator doesn't sit
> as a child of the bus it's arbitrating - this is the controller
> referenced from the arbitrator node.
i2c@12CA0000 does look like a normal hardware I2C controller, which needs
some extra properties like samsung,i2c-sda-delay or samsung,i2c-max-bus-
freq. However they are specified in cros5250-common.dtsi, so I'd say that
this might be better place for the status override as well.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-09-12 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 10:40 [PATCH 1/3] ARM: dts: Disable Exynos5250 I2S controllers by default Mark Brown
2013-09-12 10:40 ` [PATCH 2/3] ARM: dts: Leave Exynos5250 SPI controller disabled " Mark Brown
2013-09-12 11:56 ` Tomasz Figa
2013-09-12 13:50 ` Mark Brown
2013-09-12 15:51 ` Tomasz Figa
2013-09-12 20:00 ` Mark Brown
2013-09-12 10:40 ` [PATCH 3/3] ARM: dts: Disable I2C controllers by default on Exynos5250 Mark Brown
2013-09-12 12:58 ` Tomasz Figa
2013-09-12 13:52 ` Mark Brown
2013-09-12 15:55 ` Tomasz Figa [this message]
2013-09-12 20:00 ` Mark Brown
[not found] ` <20130912200013.GU29403-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-12 23:02 ` Tomasz Figa
2013-09-12 23:42 ` Mark Brown
2013-09-12 15:03 ` Stephen Warren
2013-09-12 15:59 ` Tomasz Figa
2013-09-12 11:24 ` [PATCH 1/3] ARM: dts: Disable Exynos5250 I2S controllers by default Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1657964.f1bIFjAZ98@amdc1227 \
--to=t.figa@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.