From: Stephen Warren <swarren@wwwdotorg.org>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Mark Brown <broonie@kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linaro-kernel@vger.kernel.org, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 3/3] ARM: dts: Disable I2C controllers by default on Exynos5250
Date: Thu, 12 Sep 2013 09:03:23 -0600 [thread overview]
Message-ID: <5231D7BB.6050702@wwwdotorg.org> (raw)
In-Reply-To: <2175767.kktjrZWOAr@amdc1227>
On 09/12/2013 06:58 AM, Tomasz Figa wrote:
> Hi Mark,
>
> On Thursday 12 of September 2013 11:40:27 Mark Brown wrote:
>> From: Mark Brown <broonie@linaro.org>
>>
>> Ensure that unused I2C controllers are not activated, causing problems
>> due to inappropriate pinmuxing or similar, by marking the controllers as
>> disabled by default and requiring boards to explicitly enable those that
>> are in use.
>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
>> i2c@12C60000 {
>> + status = "okay";
>
> I would keep the status properties at the end of all properties, indicating
> that at this point the description is complete and also to be consistent
> with other dts files around.
DT doesn't define any kind of ordering for the properties AFAIK, so the
order shouldn't matter in practice; it conveys no semantic
representation as far as the parsing code is concerned even if a human
may be influenced otherwise:-)
Just as an FYI, the rule I've been trying to follow in Tegra DT files is
that properties that are overridden from any included .dtsi file come
first, followed by any new properties. Still, there's no particular
reason anyone else has to follow that layout.
next prev parent reply other threads:[~2013-09-12 15:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 10:40 [PATCH 1/3] ARM: dts: Disable Exynos5250 I2S controllers by default Mark Brown
2013-09-12 10:40 ` [PATCH 2/3] ARM: dts: Leave Exynos5250 SPI controller disabled " Mark Brown
2013-09-12 11:56 ` Tomasz Figa
2013-09-12 13:50 ` Mark Brown
2013-09-12 15:51 ` Tomasz Figa
2013-09-12 20:00 ` Mark Brown
2013-09-12 10:40 ` [PATCH 3/3] ARM: dts: Disable I2C controllers by default on Exynos5250 Mark Brown
2013-09-12 12:58 ` Tomasz Figa
2013-09-12 13:52 ` Mark Brown
2013-09-12 15:55 ` Tomasz Figa
2013-09-12 20:00 ` Mark Brown
[not found] ` <20130912200013.GU29403-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-12 23:02 ` Tomasz Figa
2013-09-12 23:42 ` Mark Brown
2013-09-12 15:03 ` Stephen Warren [this message]
2013-09-12 15:59 ` Tomasz Figa
2013-09-12 11:24 ` [PATCH 1/3] ARM: dts: Disable Exynos5250 I2S controllers by default Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5231D7BB.6050702@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.