From: Rob Herring <robh@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Andrew Lunn <andrew@lunn.ch>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, Heiner Kallweit <hkallweit1@gmail.com>,
devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH net-next 1/5] dt-bindings: net: Convert Altera TSE bindings to yaml
Date: Sun, 28 Aug 2022 09:21:16 -0500 [thread overview]
Message-ID: <1661696476.844936.3159698.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220826135451.526756-2-maxime.chevallier@bootlin.com>
On Fri, 26 Aug 2022 15:54:47 +0200, Maxime Chevallier wrote:
> This converts the bindings for the Altera Triple-Speed Ethernet to yaml.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> .../devicetree/bindings/net/altera_tse.txt | 113 ---------------
> .../devicetree/bindings/net/altr,tse.yaml | 134 ++++++++++++++++++
> 2 files changed, 134 insertions(+), 113 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/altera_tse.txt
> create mode 100644 Documentation/devicetree/bindings/net/altr,tse.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: allOf:1:then:properties:reg-names: {'maxItems': 4, 'items': [{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'tx_csr'}, {'const': 's1'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: allOf:2:then:properties:reg-names: 'oneOf' conditional failed, one must be fixed:
[{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'rx_desc'}, {'const': 'rx_resp'}, {'const': 'tx_csr'}, {'const': 'tx_desc'}] is too long
[{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'rx_desc'}, {'const': 'rx_resp'}, {'const': 'tx_csr'}, {'const': 'tx_desc'}] is too short
False schema does not allow 6
1 was expected
6 is greater than the maximum of 2
6 is greater than the maximum of 3
6 is greater than the maximum of 4
6 is greater than the maximum of 5
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: ignoring, error in schema: allOf: 1: then: properties: reg-names
Documentation/devicetree/bindings/net/altr,tse.example.dtb:0:0: /example-0/ethernet@1,00001000: failed to match any schema with compatible: ['altr,tse-msgdma-1.0']
Documentation/devicetree/bindings/net/altr,tse.example.dtb:0:0: /example-0/ethernet@1,00001000/mdio: failed to match any schema with compatible: ['altr,tse-mdio']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Andrew Lunn <andrew@lunn.ch>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, Heiner Kallweit <hkallweit1@gmail.com>,
devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH net-next 1/5] dt-bindings: net: Convert Altera TSE bindings to yaml
Date: Sun, 28 Aug 2022 09:21:16 -0500 [thread overview]
Message-ID: <1661696476.844936.3159698.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220826135451.526756-2-maxime.chevallier@bootlin.com>
On Fri, 26 Aug 2022 15:54:47 +0200, Maxime Chevallier wrote:
> This converts the bindings for the Altera Triple-Speed Ethernet to yaml.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> .../devicetree/bindings/net/altera_tse.txt | 113 ---------------
> .../devicetree/bindings/net/altr,tse.yaml | 134 ++++++++++++++++++
> 2 files changed, 134 insertions(+), 113 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/altera_tse.txt
> create mode 100644 Documentation/devicetree/bindings/net/altr,tse.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: allOf:1:then:properties:reg-names: {'maxItems': 4, 'items': [{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'tx_csr'}, {'const': 's1'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: allOf:2:then:properties:reg-names: 'oneOf' conditional failed, one must be fixed:
[{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'rx_desc'}, {'const': 'rx_resp'}, {'const': 'tx_csr'}, {'const': 'tx_desc'}] is too long
[{'const': 'control_port'}, {'const': 'rx_csr'}, {'const': 'rx_desc'}, {'const': 'rx_resp'}, {'const': 'tx_csr'}, {'const': 'tx_desc'}] is too short
False schema does not allow 6
1 was expected
6 is greater than the maximum of 2
6 is greater than the maximum of 3
6 is greater than the maximum of 4
6 is greater than the maximum of 5
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/altr,tse.yaml: ignoring, error in schema: allOf: 1: then: properties: reg-names
Documentation/devicetree/bindings/net/altr,tse.example.dtb:0:0: /example-0/ethernet@1,00001000: failed to match any schema with compatible: ['altr,tse-msgdma-1.0']
Documentation/devicetree/bindings/net/altr,tse.example.dtb:0:0: /example-0/ethernet@1,00001000/mdio: failed to match any schema with compatible: ['altr,tse-mdio']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-08-28 14:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 13:54 [PATCH net-next 0/5] net: altera: tse: phylink conversion Maxime Chevallier
2022-08-26 13:54 ` Maxime Chevallier
2022-08-26 13:54 ` [PATCH net-next 1/5] dt-bindings: net: Convert Altera TSE bindings to yaml Maxime Chevallier
2022-08-26 13:54 ` Maxime Chevallier
2022-08-28 14:21 ` Rob Herring [this message]
2022-08-28 14:21 ` Rob Herring
2022-08-26 13:54 ` [PATCH net-next 2/5] net: altera: tse: cosmetic change to use reverse xmas tree ordering Maxime Chevallier
2022-08-26 13:54 ` Maxime Chevallier
2022-08-26 13:54 ` [PATCH net-next 3/5] net: pcs: add new PCS driver for altera TSE PCS Maxime Chevallier
2022-08-26 13:54 ` Maxime Chevallier
2022-08-26 16:45 ` Russell King (Oracle)
2022-08-26 16:45 ` Russell King (Oracle)
2022-08-27 9:13 ` Maxime Chevallier
2022-08-27 9:13 ` Maxime Chevallier
2022-08-26 13:54 ` [PATCH net-next 4/5] net: altera: tse: convert to phylink Maxime Chevallier
2022-08-26 13:54 ` Maxime Chevallier
2022-08-26 13:54 ` [PATCH net-next 5/5] dt-bindings: net: altera: tse: add an optional pcs register range Maxime Chevallier
2022-08-26 13:54 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1661696476.844936.3159698.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.