From: patchwork-bot+netdevbpf@kernel.org
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, liorna@nvidia.com, raeds@nvidia.com,
saeedm@nvidia.com
Subject: Re: [PATCH net-next] macsec: don't free NULL metadata_dst
Date: Mon, 26 Sep 2022 18:20:15 +0000 [thread overview]
Message-ID: <166421641543.6513.1281254546537565542.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <60f2a1965fe553e2cade9472407d0fafff8de8ce.1663923580.git.sd@queasysnail.net>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 23 Sep 2022 11:07:09 +0200 you wrote:
> Commit 0a28bfd4971f added a metadata_dst to each tx_sc, but that's
> only allocated when macsec_add_dev has run, which happens after device
> registration. If the requested or computed SCI already exists, or if
> linking to the lower device fails, we will panic because
> metadata_dst_free can't handle NULL.
>
> Reproducer:
> ip link add link $lower type macsec
> ip link add link $lower type macsec
>
> [...]
Here is the summary with links:
- [net-next] macsec: don't free NULL metadata_dst
https://git.kernel.org/netdev/net-next/c/c52add61c27e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-09-26 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 9:07 [PATCH net-next] macsec: don't free NULL metadata_dst Sabrina Dubroca
2022-09-25 7:29 ` Raed Salem
2022-09-26 16:40 ` Jakub Kicinski
2022-09-26 18:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166421641543.6513.1281254546537565542.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=liorna@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.