From: Jakub Kicinski <kuba@kernel.org>
To: Raed Salem <raeds@nvidia.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Lior Nahmanson <liorna@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH net-next] macsec: don't free NULL metadata_dst
Date: Mon, 26 Sep 2022 09:40:50 -0700 [thread overview]
Message-ID: <20220926094050.30a4fe59@kernel.org> (raw)
In-Reply-To: <DM4PR12MB5357EB2AF3F1AA4184DBF7B2C9539@DM4PR12MB5357.namprd12.prod.outlook.com>
On Sun, 25 Sep 2022 07:29:36 +0000 Raed Salem wrote:
> >Commit 0a28bfd4971f added a metadata_dst to each tx_sc, but that's only
> >allocated when macsec_add_dev has run, which happens after device
> >registration. If the requested or computed SCI already exists, or if linking to
> >the lower device fails, we will panic because metadata_dst_free can't handle
> >NULL.
> >
> >Reproducer:
> > ip link add link $lower type macsec
> > ip link add link $lower type macsec
> >
> >Fixes: 0a28bfd4971f ("net/macsec: Add MACsec skb_metadata_dst Tx Data
> >path support")
> >Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
>
> Acked by me
Thanks a lot for the review! Please prefer the full:
Acked-by: Raed Salem <raeds@nvidia.com>
format in the future, this way it will be picked up by the automation.
next prev parent reply other threads:[~2022-09-26 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 9:07 [PATCH net-next] macsec: don't free NULL metadata_dst Sabrina Dubroca
2022-09-25 7:29 ` Raed Salem
2022-09-26 16:40 ` Jakub Kicinski [this message]
2022-09-26 18:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926094050.30a4fe59@kernel.org \
--to=kuba@kernel.org \
--cc=liorna@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.