From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com,development@efficientek.com
Subject: Re: [PATCH] tests: Add pathological iso9660 filesystem tests
Date: Sun, 05 Feb 2023 09:24:21 +0100 [thread overview]
Message-ID: <16652393890953890042@scdbackup.webframe.org> (raw)
In-Reply-To: <20230205002831.1940679-1-development@efficientek.com>
Hi,
Glenn Washburn wrote:
> --- a/tests/iso9660_test.in
> +++ b/tests/iso9660_test.in
> @@ -12,4 +12,13 @@ fi
> "@builddir@/grub-fs-tester" rockridge_joliet
> "@builddir@/grub-fs-tester" joliet_1999
> "@builddir@/grub-fs-tester" rockridge_1999
> -"@builddir@/grub-fs-tester" rockridge_joliet_1999
> \ No newline at end of file
> +"@builddir@/grub-fs-tester" rockridge_joliet_1999
> +
> +for fs in iso9660_ce_loop iso9660_ce_loop2; do
> + tempdir=`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date
> '+%Y%m%d%H%M%S%N').${fs}.XXX"` ||
> + { echo "Failed to make temporary directory"; exit 99; }
> + gunzip <"$srcdir"/tests/${fs}.iso.gz >"${tempdir}/${fs}.iso"
> + output=$(LC_ALL=C timeout -s KILL "60" \
> + "@builddir@/grub-fstest" "${tempdir}/${fs}.iso" ls / )
> + test "$?" -eq 0 -a -z "$output"
> +done
Shouldn't the decompressed files and the temporary directory be removed
afterwards ?
Have a nice day :)
Thomas
next prev parent reply other threads:[~2023-02-05 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 0:28 [PATCH] tests: Add pathological iso9660 filesystem tests Glenn Washburn
2023-02-05 8:24 ` Thomas Schmitt [this message]
2023-02-06 16:46 ` Glenn Washburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16652393890953890042@scdbackup.webframe.org \
--to=scdbackup@gmx.net \
--cc=daniel.kiper@oracle.com \
--cc=development@efficientek.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.