Re: [PATCH 1/2] input: st1232: Add reset pin handling

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Bastian,

On Monday 08 April 2013 14:43:26 Bastian Hecht wrote:
> 2013/4/7 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> > On Saturday 06 April 2013 15:18:45 Bastian Hecht wrote:
> >> We add the possiblity to hand over a GPIO number for the reset pin.
> >> This way we can remove existing board code that takes care of it and
> >> group this information properly in the platform data or in the device
> >> tree confguration.
> >> 
> >> The implementation is analogous to the cy8ctmg110 driver, thanks.
> >> 
> >> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
> >> ---
> >> 
> >>  .../bindings/input/touchscreen/sitronix-st1232.txt |   24 ++++++++++
> >>  drivers/input/touchscreen/st1232.c                 |   47 ++++++++++++--
> >>  include/linux/input/st1232_pdata.h                 |   13 ++++++
> >>  3 files changed, 81 insertions(+), 3 deletions(-)
> >>  create mode 100644
> >> 
> >> Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt
> >> create mode 100644 include/linux/input/st1232_pdata.h
> >> 
> >> diff --git
> >> a/Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt
> >> b/Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt
> >> new file mode 100644
> >> index 0000000..1936969
> >> --- /dev/null
> >> +++
> >> b/Documentation/devicetree/bindings/input/touchscreen/sitronix-st1232.txt
> >> @@ -0,0 +1,24 @@
> >> +* Sitronix st1232 touchscreen controller
> >> +
> >> +Required properties:
> >> +- compatible: must be "sitronix,st1232"
> >> +- reg: I2C address of the chip
> >> +- interrupts: interrupt to which the chip is connected
> >> +
> >> +Optional properties:
> >> +- sitronix,reset-pin: GPIO number of the reset pin
> > 
> > GPIO bindings use phandles, please see
> > Documentation/devicetree/bindings/gpio/gpio.txt.
> 
> Ok done. I haven't tested that part yet as the pfc is not set up via the DT.
> I saw in topic/pinmux-dt that you added OF support for the pfc, but I
> couldn't apply the patch without conflicts. Do you think this part is going
> to be merged to next any time soon?

I need to rework the patches, I hope to get them merged in v3.11

> >> +Example:
> >> +
> >> +     i2c@00000000 {
> >> +             /* ... */
> >> +
> >> +             touchscreen@55 {
> >> +                     compatible = "sitronix,st1232";
> >> +                     reg = <0x55>;
> >> +                     interrupts = <2 0>;
> >> +                     sitronix,reset-pin = <166>;
> >> +             };
> >> +
> >> +             /* ... */
> >> +     };

-- 
Regards,

Laurent Pinchart