From: David Howells <dhowells@redhat.com>
To: Justin Chen <jchen@hpdst41.cup.hp.com>
Cc: dhowells@redhat.com, linux-arch@vger.kernel.org,
bjorn.helgaas@hp.com, justin.chen@hp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv]
Date: Wed, 25 Feb 2009 12:37:10 +0000 [thread overview]
Message-ID: <16693.1235565430@redhat.com> (raw)
In-Reply-To: <200902250452.UAA12902@hpdst41.cup.hp.com>
Justin Chen <jchen@hpdst41.cup.hp.com> wrote:
> Change the index to unsigned long in all bitops for [frv]
>
> Signed-off-by: Justin Chen <justin.chen@hp.com>
> Reviewed-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Mostly okay, apart from:
> -static inline int __constant_test_bit(int nr, const volatile void * addr)
> +static inline int
> +__constant_test_bit(unsigned long nr, const volatile void *addr)
Please move the return type onto the next line also. Other than that:
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2009-02-25 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 4:52 [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv] Justin Chen
2009-02-25 12:37 ` David Howells [this message]
2009-02-25 22:33 ` H. Peter Anvin
2009-02-25 23:50 ` David Howells
2009-02-26 0:55 ` H. Peter Anvin
2009-02-26 1:37 ` David Howells
2009-02-26 1:43 ` H. Peter Anvin
2009-02-26 0:57 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16693.1235565430@redhat.com \
--to=dhowells@redhat.com \
--cc=bjorn.helgaas@hp.com \
--cc=jchen@hpdst41.cup.hp.com \
--cc=justin.chen@hp.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.