All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Mark Brown <broonie@kernel.org>,
	Kalesh Singh <kaleshsingh@google.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Marc Zyngier <maz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>
Subject: [PATCH 0/3] arm64: kprobes: Fix bugs in kprobes for arm64
Date: Thu,  1 Dec 2022 23:38:52 +0900	[thread overview]
Message-ID: <166990553243.253128.13594802750635478633.stgit@devnote3> (raw)

Hi,

I found some bugs in kprobes for arm64. One is a critical issue, which
will cause a kernel crach easily with lockdep[1/3]. Others are minor
issues and rare cases. [2/3] let do_page_fault() fixup the page fault
in kprobes user handler, and [3/3] is more like code cleanup and
returns DBG_HOOK_ERROR if it can not handle kprobe's BRK (but that
should not happen.)

Thank you,

---

Masami Hiramatsu (Google) (3):
      arm64: Prohibit probing on arch_stack_walk()
      arm64: kprobes: Let arch do_page_fault() fix up page fault in user handler
      arm64: kprobes: Return DBG_HOOK_ERROR if kprobes can not handle a BRK


 arch/arm64/kernel/probes/kprobes.c |   87 +++++++++++++++---------------------
 arch/arm64/kernel/stacktrace.c     |    7 ++-
 2 files changed, 41 insertions(+), 53 deletions(-)

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Mark Brown <broonie@kernel.org>,
	Kalesh Singh <kaleshsingh@google.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Marc Zyngier <maz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>
Subject: [PATCH 0/3] arm64: kprobes: Fix bugs in kprobes for arm64
Date: Thu,  1 Dec 2022 23:38:52 +0900	[thread overview]
Message-ID: <166990553243.253128.13594802750635478633.stgit@devnote3> (raw)

Hi,

I found some bugs in kprobes for arm64. One is a critical issue, which
will cause a kernel crach easily with lockdep[1/3]. Others are minor
issues and rare cases. [2/3] let do_page_fault() fixup the page fault
in kprobes user handler, and [3/3] is more like code cleanup and
returns DBG_HOOK_ERROR if it can not handle kprobe's BRK (but that
should not happen.)

Thank you,

---

Masami Hiramatsu (Google) (3):
      arm64: Prohibit probing on arch_stack_walk()
      arm64: kprobes: Let arch do_page_fault() fix up page fault in user handler
      arm64: kprobes: Return DBG_HOOK_ERROR if kprobes can not handle a BRK


 arch/arm64/kernel/probes/kprobes.c |   87 +++++++++++++++---------------------
 arch/arm64/kernel/stacktrace.c     |    7 ++-
 2 files changed, 41 insertions(+), 53 deletions(-)

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>

             reply	other threads:[~2022-12-01 14:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 14:38 Masami Hiramatsu (Google) [this message]
2022-12-01 14:38 ` [PATCH 0/3] arm64: kprobes: Fix bugs in kprobes for arm64 Masami Hiramatsu (Google)
2022-12-01 14:39 ` [PATCH 1/3] arm64: Prohibit probing on arch_stack_walk() Masami Hiramatsu (Google)
2022-12-01 14:39   ` Masami Hiramatsu (Google)
2022-12-01 14:47   ` Mark Rutland
2022-12-01 14:47     ` Mark Rutland
2022-12-01 15:54     ` Masami Hiramatsu
2022-12-01 15:54       ` Masami Hiramatsu
2022-12-01 14:39 ` [PATCH 2/3] arm64: kprobes: Let arch do_page_fault() fix up page fault in user handler Masami Hiramatsu (Google)
2022-12-01 14:39   ` Masami Hiramatsu (Google)
2022-12-01 14:56   ` Mark Rutland
2022-12-01 14:56     ` Mark Rutland
2022-12-01 14:39 ` [PATCH 3/3] arm64: kprobes: Return DBG_HOOK_ERROR if kprobes can not handle a BRK Masami Hiramatsu (Google)
2022-12-01 14:39   ` Masami Hiramatsu (Google)
2022-12-01 15:08   ` Mark Rutland
2022-12-01 15:08     ` Mark Rutland
2022-12-01 16:07     ` Masami Hiramatsu
2022-12-01 16:07       ` Masami Hiramatsu
2022-12-01 17:21       ` Mark Rutland
2022-12-01 17:21         ` Mark Rutland
2022-12-02  0:42         ` Masami Hiramatsu
2022-12-02  0:42           ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166990553243.253128.13594802750635478633.stgit@devnote3 \
    --to=mhiramat@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kaleshsingh@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=sandeepa.s.prabhu@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.