* [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:19 ` Dmitry Baryshkov
2025-09-15 7:20 ` Konrad Dybcio
2025-09-13 23:56 ` [PATCH 02/11] arm64: dts: qcom sdm845-lg-judyln: Add battery and charger Paul Sajna
` (10 subsequent siblings)
11 siblings, 2 replies; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
uart9 is debug serial on USB SBU1/2
uart6 is bluetooth
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 47 ++++++++++++++++++++++++++
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 10 ++++++
2 files changed, 57 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 99dafc6716e76e25aad0755e6004dc952779689f..1acc418b943443f3ba4f8a8a1cfe2c575da11876 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -31,6 +31,8 @@ chosen {
#address-cells = <2>;
#size-cells = <2>;
ranges;
+
+ stdout-path = "serial0:115200n8";
};
reserved-memory {
@@ -159,6 +161,11 @@ vreg_s4a_1p8: pm8998-smps4-regulator {
vin-supply = <&vph_pwr>;
};
+
+ aliases {
+ serial0 = &uart9;
+ serial1 = &uart6;
+ };
};
&adsp_pas {
@@ -595,3 +602,43 @@ vol_up_pin_a: vol-up-active-state {
qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
};
};
+
+&qupv3_id_0 {
+ status = "okay";
+};
+
+&qupv3_id_1 {
+ status = "okay";
+};
+
+&qup_uart9_rx {
+ drive-strength = <2>;
+ bias-pull-up;
+};
+
+&qup_uart9_tx {
+ drive-strength = <2>;
+ bias-disable;
+};
+
+&uart6 {
+ pinctrl-0 = <&qup_uart6_4pin>;
+
+ status = "okay";
+
+ bluetooth {
+ compatible = "qcom,wcn3990-bt";
+
+ vddio-supply = <&vreg_s4a_1p8>;
+ vddxo-supply = <&vreg_l7a_1p8>;
+ vddrf-supply = <&vreg_l17a_1p3>;
+ vddch0-supply = <&vreg_l25a_3p3>;
+ max-speed = <3200000>;
+ };
+};
+
+&uart9 {
+ label = "LS-UART1";
+
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index a12723310c8b630a4961de671ea8b60f1f8b512b..49225e4fa80e5f45a36964d5d733dc238e4413f8 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -66,3 +66,13 @@ thinq_key_default: thinq-key-default-state {
bias-pull-up;
};
};
+
+&uart6 {
+ bluetooth {
+ /*
+ * This path is relative to the qca/
+ * subdir under lib/firmware.
+ */
+ firmware-name = "judyln/crnv21.bin";
+ };
+};
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
2025-09-13 23:56 ` [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
@ 2025-09-15 0:19 ` Dmitry Baryshkov
2025-09-15 0:28 ` Paul Sajna
2025-09-15 7:20 ` Konrad Dybcio
1 sibling, 1 reply; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:19 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:34PM -0700, Paul Sajna wrote:
> uart9 is debug serial on USB SBU1/2
> uart6 is bluetooth
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 47 ++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 10 ++++++
> 2 files changed, 57 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 99dafc6716e76e25aad0755e6004dc952779689f..1acc418b943443f3ba4f8a8a1cfe2c575da11876 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -31,6 +31,8 @@ chosen {
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> +
> + stdout-path = "serial0:115200n8";
> };
>
> reserved-memory {
> @@ -159,6 +161,11 @@ vreg_s4a_1p8: pm8998-smps4-regulator {
>
> vin-supply = <&vph_pwr>;
> };
> +
> + aliases {
Please keep the file sorted. 'aliases' < 'chosen', etc.
> + serial0 = &uart9;
> + serial1 = &uart6;
> + };
> };
>
> &adsp_pas {
> @@ -595,3 +602,43 @@ vol_up_pin_a: vol-up-active-state {
> qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
> };
> };
> +
> +&qupv3_id_0 {
> + status = "okay";
> +};
> +
> +&qupv3_id_1 {
> + status = "okay";
> +};
> +
> +&qup_uart9_rx {
> + drive-strength = <2>;
> + bias-pull-up;
> +};
> +
> +&qup_uart9_tx {
> + drive-strength = <2>;
> + bias-disable;
> +};
> +
> +&uart6 {
> + pinctrl-0 = <&qup_uart6_4pin>;
> +
> + status = "okay";
> +
> + bluetooth {
> + compatible = "qcom,wcn3990-bt";
> +
> + vddio-supply = <&vreg_s4a_1p8>;
> + vddxo-supply = <&vreg_l7a_1p8>;
> + vddrf-supply = <&vreg_l17a_1p3>;
> + vddch0-supply = <&vreg_l25a_3p3>;
> + max-speed = <3200000>;
> + };
> +};
> +
> +&uart9 {
> + label = "LS-UART1";
> +
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index a12723310c8b630a4961de671ea8b60f1f8b512b..49225e4fa80e5f45a36964d5d733dc238e4413f8 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -66,3 +66,13 @@ thinq_key_default: thinq-key-default-state {
> bias-pull-up;
> };
> };
> +
> +&uart6 {
> + bluetooth {
> + /*
> + * This path is relative to the qca/
> + * subdir under lib/firmware.
Why do you need a special NV file? Please include BT information into
the commit message. Also, if qca_read_fw_board_id() returns a sensible
information on this board, it would be better to fix btqca driver to
apply board ID on WCN399x boards too.
> + */
> + firmware-name = "judyln/crnv21.bin";
> + };
> +};
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
2025-09-15 0:19 ` Dmitry Baryshkov
@ 2025-09-15 0:28 ` Paul Sajna
0 siblings, 0 replies; 29+ messages in thread
From: Paul Sajna @ 2025-09-15 0:28 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
>
> Why do you need a special NV file? Please include BT information into
> the commit message. Also, if qca_read_fw_board_id() returns a sensible
> information on this board, it would be better to fix btqca driver to
> apply board ID on WCN399x boards too.
>
> >
> > + */
> > + firmware-name = "judyln/crnv21.bin";
> > + };
> > +};
> >
> > --
> > 2.51.0
> >
> --
> With best wishes
> Dmitry
>
I'm not sure if it's necessary, but it seems to be standard practice for all the devices to have their own NV.
https://i.imgur.com/MD3o3k2.png
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
2025-09-13 23:56 ` [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
2025-09-15 0:19 ` Dmitry Baryshkov
@ 2025-09-15 7:20 ` Konrad Dybcio
1 sibling, 0 replies; 29+ messages in thread
From: Konrad Dybcio @ 2025-09-15 7:20 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown
On 9/14/25 1:56 AM, Paul Sajna wrote:
> uart9 is debug serial on USB SBU1/2
> uart6 is bluetooth
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
[...]
> +&uart9 {
> + label = "LS-UART1";
This is what the name of the output is on 96boards products, I
doubt it makes sense in your case
Konrad
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 02/11] arm64: dts: qcom sdm845-lg-judyln: Add battery and charger
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-09-13 23:56 ` [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-14 10:20 ` Krzysztof Kozlowski
2025-09-13 23:56 ` [PATCH 03/11] arm64: dts: qcom: sdm845-lg-common: Add leds Paul Sajna
` (9 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
Values based on lineageos kernel
Co-authored-by: Christopher Brown <crispybrown@gmail.com>
Signed-off-by: Christopher Brown <crispybrown@gmail.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 49225e4fa80e5f45a36964d5d733dc238e4413f8..da093b581c857c5acc9f0e72c9d3519977e13eab 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -37,6 +37,16 @@ key-thinq {
interrupts = <89 IRQ_TYPE_LEVEL_LOW>;
};
};
+
+ battery: battery {
+ compatible = "simple-battery";
+
+ status = "okay";
+
+ charge-full-design-microamp-hours = <3000000>;
+ voltage-min-design-microvolt = <3200000>;
+ voltage-max-design-microvolt = <4400000>;
+ };
};
&adsp_pas {
@@ -57,6 +67,11 @@ &mss_pil {
firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
};
+&pmi8998_charger {
+ status = "okay";
+ monitored-battery = <&battery>;
+};
+
&tlmm {
thinq_key_default: thinq-key-default-state {
pins = "gpio89";
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 02/11] arm64: dts: qcom sdm845-lg-judyln: Add battery and charger
2025-09-13 23:56 ` [PATCH 02/11] arm64: dts: qcom sdm845-lg-judyln: Add battery and charger Paul Sajna
@ 2025-09-14 10:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 29+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-14 10:20 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown
On 14/09/2025 01:56, Paul Sajna wrote:
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 49225e4fa80e5f45a36964d5d733dc238e4413f8..da093b581c857c5acc9f0e72c9d3519977e13eab 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -37,6 +37,16 @@ key-thinq {
> interrupts = <89 IRQ_TYPE_LEVEL_LOW>;
> };
> };
> +
> + battery: battery {
> + compatible = "simple-battery";
> +
> + status = "okay";
Drop.
> +
> + charge-full-design-microamp-hours = <3000000>;
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 03/11] arm64: dts: qcom: sdm845-lg-common: Add leds
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-09-13 23:56 ` [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
2025-09-13 23:56 ` [PATCH 02/11] arm64: dts: qcom sdm845-lg-judyln: Add battery and charger Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:24 ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
` (8 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
Add the multicolor status led in the phone's notch
Co-authored-by: Amir Dahan <system64fumo@protonmail.com>
Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 1acc418b943443f3ba4f8a8a1cfe2c575da11876..d6129ce03f537f0c8c78c2ae5f39be6146cab7dc 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -6,6 +6,7 @@
*/
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -603,6 +604,31 @@ vol_up_pin_a: vol-up-active-state {
};
};
+&pmi8998_lpg {
+ status = "okay";
+
+ led@0 {
+ label = "blue";
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ default-state = "off";
+ };
+
+ led@1 {
+ label = "green";
+ reg = <4>;
+ color = <LED_COLOR_ID_GREEN>;
+ default-state = "off";
+ };
+
+ led@2 {
+ label = "red";
+ reg = <5>;
+ color = <LED_COLOR_ID_RED>;
+ default-state = "off";
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 03/11] arm64: dts: qcom: sdm845-lg-common: Add leds
2025-09-13 23:56 ` [PATCH 03/11] arm64: dts: qcom: sdm845-lg-common: Add leds Paul Sajna
@ 2025-09-15 0:24 ` Dmitry Baryshkov
0 siblings, 0 replies; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:24 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:36PM -0700, Paul Sajna wrote:
> Add the multicolor status led in the phone's notch
>
> Co-authored-by: Amir Dahan <system64fumo@protonmail.com>
> Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 1acc418b943443f3ba4f8a8a1cfe2c575da11876..d6129ce03f537f0c8c78c2ae5f39be6146cab7dc 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -6,6 +6,7 @@
> */
>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>
> @@ -603,6 +604,31 @@ vol_up_pin_a: vol-up-active-state {
> };
> };
>
> +&pmi8998_lpg {
> + status = "okay";
This should be described as a multi-led. See msm8998-sony-xperia-yoshino
for an example.
> +
> + led@0 {
> + label = "blue";
> + reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> + default-state = "off";
> + };
> +
> + led@1 {
> + label = "green";
> + reg = <4>;
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "off";
> + };
> +
> + led@2 {
> + label = "red";
> + reg = <5>;
> + color = <LED_COLOR_ID_RED>;
> + default-state = "off";
> + };
> +};
> +
> &qupv3_id_0 {
> status = "okay";
> };
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (2 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 03/11] arm64: dts: qcom: sdm845-lg-common: Add leds Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:25 ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 05/11] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
` (7 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
Add the camera flash so it can be used as a flashlight
Co-authored-by: Amir Dahan <system64fumo@protonmail.com>
Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index d6129ce03f537f0c8c78c2ae5f39be6146cab7dc..df826bca2bef5e3f85cf49708020a47b8d6bd8bb 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -604,6 +604,20 @@ vol_up_pin_a: vol-up-active-state {
};
};
+&pmi8998_flash {
+ status = "okay";
+
+ led-0 {
+ label = "flash";
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <1>;
+ led-max-microamp = <850000>;
+ flash-max-microamp = <850000>;
+ flash-max-timeout-us = <500000>;
+ };
+};
+
&pmi8998_lpg {
status = "okay";
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash
2025-09-13 23:56 ` [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
@ 2025-09-15 0:25 ` Dmitry Baryshkov
2025-09-15 0:34 ` Dmitry Baryshkov
0 siblings, 1 reply; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:25 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:37PM -0700, Paul Sajna wrote:
> Add the camera flash so it can be used as a flashlight
>
> Co-authored-by: Amir Dahan <system64fumo@protonmail.com>
> Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index d6129ce03f537f0c8c78c2ae5f39be6146cab7dc..df826bca2bef5e3f85cf49708020a47b8d6bd8bb 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -604,6 +604,20 @@ vol_up_pin_a: vol-up-active-state {
> };
> };
>
> +&pmi8998_flash {
> + status = "okay";
> +
> + led-0 {
> + label = "flash";
Not allowed, please drop.
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + led-sources = <1>;
> + led-max-microamp = <850000>;
> + flash-max-microamp = <850000>;
> + flash-max-timeout-us = <500000>;
> + };
> +};
> +
> &pmi8998_lpg {
> status = "okay";
>
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash
2025-09-15 0:25 ` Dmitry Baryshkov
@ 2025-09-15 0:34 ` Dmitry Baryshkov
0 siblings, 0 replies; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:34 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Mon, Sep 15, 2025 at 03:25:45AM +0300, Dmitry Baryshkov wrote:
> On Sat, Sep 13, 2025 at 04:56:37PM -0700, Paul Sajna wrote:
> > Add the camera flash so it can be used as a flashlight
> >
> > Co-authored-by: Amir Dahan <system64fumo@protonmail.com>
> > Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
> > Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > index d6129ce03f537f0c8c78c2ae5f39be6146cab7dc..df826bca2bef5e3f85cf49708020a47b8d6bd8bb 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > @@ -604,6 +604,20 @@ vol_up_pin_a: vol-up-active-state {
> > };
> > };
> >
> > +&pmi8998_flash {
> > + status = "okay";
> > +
> > + led-0 {
> > + label = "flash";
>
> Not allowed, please drop.
Okay, allowed, but still please drop. See how it's handled for other
boards.
>
> > + function = LED_FUNCTION_FLASH;
> > + color = <LED_COLOR_ID_WHITE>;
> > + led-sources = <1>;
> > + led-max-microamp = <850000>;
> > + flash-max-microamp = <850000>;
> > + flash-max-timeout-us = <500000>;
> > + };
> > +};
> > +
> > &pmi8998_lpg {
> > status = "okay";
> >
> >
> > --
> > 2.51.0
> >
>
> --
> With best wishes
> Dmitry
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 05/11] arm64: dts: qcom: sdm845-lg-judyln: Add display panel
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (3 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:28 ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node Paul Sajna
` (6 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
And supporting msm drm nodes, including backlight
Depends on https://lore.kernel.org/all/20250910-judyln-panel-v1-1-825c74403bbb@postmarketos.org/T/#r9a976ca01e309b6c03100e984a26a0ffc2fe2002
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
Co-authored-by: Amir Dahan <system64fumo@protonmail.com>
Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 4 +-
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 99 ++++++++++++++++++++++++++
2 files changed, 101 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index df826bca2bef5e3f85cf49708020a47b8d6bd8bb..1bf2f2b0e85de174959ec2467076a95f471a59d4 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -461,8 +461,8 @@ &cdsp_pas {
status = "okay";
};
-&dispcc {
- status = "disabled";
+&gmu {
+ status = "okay";
};
&gcc {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index da093b581c857c5acc9f0e72c9d3519977e13eab..fae85d4c1520e044d8166bb22a8f5762fda250b2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -23,6 +23,13 @@ framebuffer@9d400000 {
format = "a8r8g8b8";
lab-supply = <&lab>;
ibb-supply = <&ibb>;
+
+ panel = <&fb_panel>;
+
+ fb_panel: fb-panel {
+ width-mm = <72>;
+ height-mm = <153>;
+ };
};
};
@@ -72,6 +79,70 @@ &pmi8998_charger {
monitored-battery = <&battery>;
};
+&ibb {
+ regulator-min-microvolt = <4600000>;
+ regulator-max-microvolt = <6000000>;
+ regulator-over-current-protection;
+ regulator-pull-down;
+ regulator-soft-start;
+ regulator-always-on;
+ qcom,discharge-resistor-kohms = <300>;
+};
+
+&lab {
+ regulator-min-microvolt = <4600000>;
+ regulator-max-microvolt = <6000000>;
+ regulator-over-current-protection;
+ regulator-pull-down;
+ regulator-soft-start;
+};
+
+&mdss {
+ status = "okay";
+};
+
+&mdss_dsi0 {
+ vdda-supply = <&vdda_mipi_dsi0_1p2>;
+
+ status = "okay";
+
+ display_panel: panel@0 {
+ reg = <0>;
+ compatible = "lg,sw49410";
+
+ ibb-supply = <&ibb>;
+ lab-supply = <&lab>;
+
+ backlight = <&pmi8998_wled>;
+ reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sde_dsi_active &sde_te_active>;
+ pinctrl-1 = <&sde_dsi_sleep &sde_te_sleep>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_phy {
+ vdds-supply = <&vdda_mipi_dsi0_pll>;
+
+ status = "okay";
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&panel_in>;
+ data-lanes = <0 1 2 3>;
+};
+
+&pmi8998_wled {
+ status = "okay";
+};
+
&tlmm {
thinq_key_default: thinq-key-default-state {
pins = "gpio89";
@@ -80,6 +151,34 @@ thinq_key_default: thinq-key-default-state {
drive-strength = <2>;
bias-pull-up;
};
+
+ sde_dsi_active: sde-dsi-active-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ sde_dsi_sleep: sde-dsi-sleep-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ sde_te_active: sde-te-active-state {
+ pins = "gpio10";
+ function = "mdp_vsync";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ sde_te_sleep: sde-te-sleep-state {
+ pins = "gpio10";
+ function = "mdp_vsync";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
};
&uart6 {
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 05/11] arm64: dts: qcom: sdm845-lg-judyln: Add display panel
2025-09-13 23:56 ` [PATCH 05/11] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
@ 2025-09-15 0:28 ` Dmitry Baryshkov
0 siblings, 0 replies; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:28 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:38PM -0700, Paul Sajna wrote:
> And supporting msm drm nodes, including backlight
> Depends on https://lore.kernel.org/all/20250910-judyln-panel-v1-1-825c74403bbb@postmarketos.org/T/#r9a976ca01e309b6c03100e984a26a0ffc2fe2002
This should be a part of the cover letter. Once this commit lands, there
is not point in having this information in the commit message.
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> Co-authored-by: Amir Dahan <system64fumo@protonmail.com>
> Signed-off-by: Amir Dahan <system64fumo@protonmail.com>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 4 +-
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 99 ++++++++++++++++++++++++++
> 2 files changed, 101 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index df826bca2bef5e3f85cf49708020a47b8d6bd8bb..1bf2f2b0e85de174959ec2467076a95f471a59d4 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -461,8 +461,8 @@ &cdsp_pas {
> status = "okay";
> };
>
> -&dispcc {
> - status = "disabled";
> +&gmu {
> + status = "okay";
> };
It's enabled by default, no need to reenable it again.
>
> &gcc {
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index da093b581c857c5acc9f0e72c9d3519977e13eab..fae85d4c1520e044d8166bb22a8f5762fda250b2 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -23,6 +23,13 @@ framebuffer@9d400000 {
> format = "a8r8g8b8";
> lab-supply = <&lab>;
> ibb-supply = <&ibb>;
> +
> + panel = <&fb_panel>;
> +
> + fb_panel: fb-panel {
> + width-mm = <72>;
> + height-mm = <153>;
> + };
This is independent, please split to a separate patch.
> };
> };
>
> @@ -72,6 +79,70 @@ &pmi8998_charger {
> monitored-battery = <&battery>;
> };
>
> +&ibb {
Please keep entries sorted out.
> + regulator-min-microvolt = <4600000>;
> + regulator-max-microvolt = <6000000>;
> + regulator-over-current-protection;
> + regulator-pull-down;
> + regulator-soft-start;
> + regulator-always-on;
> + qcom,discharge-resistor-kohms = <300>;
> +};
> +
> +&lab {
> + regulator-min-microvolt = <4600000>;
> + regulator-max-microvolt = <6000000>;
> + regulator-over-current-protection;
> + regulator-pull-down;
> + regulator-soft-start;
> +};
> +
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dsi0 {
> + vdda-supply = <&vdda_mipi_dsi0_1p2>;
> +
> + status = "okay";
> +
> + display_panel: panel@0 {
> + reg = <0>;
> + compatible = "lg,sw49410";
> +
> + ibb-supply = <&ibb>;
> + lab-supply = <&lab>;
> +
> + backlight = <&pmi8998_wled>;
> + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
> +
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sde_dsi_active &sde_te_active>;
> + pinctrl-1 = <&sde_dsi_sleep &sde_te_sleep>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> + };
> +};
> +
> +&mdss_dsi0_phy {
> + vdds-supply = <&vdda_mipi_dsi0_pll>;
> +
> + status = "okay";
> +};
> +
> +&mdss_dsi0_out {
> + remote-endpoint = <&panel_in>;
> + data-lanes = <0 1 2 3>;
> +};
> +
> +&pmi8998_wled {
> + status = "okay";
> +};
> +
> &tlmm {
> thinq_key_default: thinq-key-default-state {
> pins = "gpio89";
> @@ -80,6 +151,34 @@ thinq_key_default: thinq-key-default-state {
> drive-strength = <2>;
> bias-pull-up;
> };
> +
> + sde_dsi_active: sde-dsi-active-state {
And here too.
> + pins = "gpio6";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-disable;
> + };
> +
> + sde_dsi_sleep: sde-dsi-sleep-state {
> + pins = "gpio6";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + sde_te_active: sde-te-active-state {
> + pins = "gpio10";
> + function = "mdp_vsync";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + sde_te_sleep: sde-te-sleep-state {
> + pins = "gpio10";
> + function = "mdp_vsync";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> };
>
> &uart6 {
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (4 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 05/11] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:32 ` Dmitry Baryshkov
2025-09-15 7:18 ` Konrad Dybcio
2025-09-13 23:56 ` [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes Paul Sajna
` (5 subsequent siblings)
11 siblings, 2 replies; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
Wi-Fi now works with this patch and relevant firmware
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 1bf2f2b0e85de174959ec2467076a95f471a59d4..585582ff4e0bbe8c994328278d5e5dd3a280ddb6 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -682,3 +682,16 @@ &uart9 {
status = "okay";
};
+
+&wifi {
+ vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+ vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+ vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+ vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+ vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
+
+ qcom,snoc-host-cap-skip-quirk;
+ qcom,ath10k-calibration-variant = "lg_judy";
+
+ status = "okay";
+};
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node
2025-09-13 23:56 ` [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node Paul Sajna
@ 2025-09-15 0:32 ` Dmitry Baryshkov
2025-09-15 3:57 ` Paul Sajna
2025-09-15 7:18 ` Konrad Dybcio
1 sibling, 1 reply; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:32 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:39PM -0700, Paul Sajna wrote:
> Wi-Fi now works with this patch and relevant firmware
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 1bf2f2b0e85de174959ec2467076a95f471a59d4..585582ff4e0bbe8c994328278d5e5dd3a280ddb6 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -682,3 +682,16 @@ &uart9 {
>
> status = "okay";
> };
> +
> +&wifi {
> + vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
> + vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> + vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> + vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
> +
> + qcom,snoc-host-cap-skip-quirk;
> + qcom,ath10k-calibration-variant = "lg_judy";
Was it submitted for inclusion? Please follow the process described at
https://wireless.docs.kernel.org/en/latest/en/users/drivers/ath10k/boardfiles.html
> +
> + status = "okay";
> +};
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node
2025-09-15 0:32 ` Dmitry Baryshkov
@ 2025-09-15 3:57 ` Paul Sajna
0 siblings, 0 replies; 29+ messages in thread
From: Paul Sajna @ 2025-09-15 3:57 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
September 15, 2025 at 12:32 AM, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com mailto:dmitry.baryshkov@oss.qualcomm.com?to=%22Dmitry%20Baryshkov%22%20%3Cdmitry.baryshkov%40oss.qualcomm.com%3E > wrote:
>
> Was it submitted for inclusion? Please follow the process described at
> https://wireless.docs.kernel.org/en/latest/en/users/drivers/ath10k/boardfiles.html
>
> >
> > +
> > + status = "okay";
> > +};
> >
> > --
> > 2.51.0
> >
> --
> With best wishes
> Dmitry
>
Will do in a separate patch.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node
2025-09-13 23:56 ` [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node Paul Sajna
2025-09-15 0:32 ` Dmitry Baryshkov
@ 2025-09-15 7:18 ` Konrad Dybcio
1 sibling, 0 replies; 29+ messages in thread
From: Konrad Dybcio @ 2025-09-15 7:18 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown
On 9/14/25 1:56 AM, Paul Sajna wrote:
> Wi-Fi now works with this patch and relevant firmware
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 1bf2f2b0e85de174959ec2467076a95f471a59d4..585582ff4e0bbe8c994328278d5e5dd3a280ddb6 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -682,3 +682,16 @@ &uart9 {
>
> status = "okay";
> };
> +
> +&wifi {
> + vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
> + vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> + vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> + vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
> +
> + qcom,snoc-host-cap-skip-quirk;
> + qcom,ath10k-calibration-variant = "lg_judy";
This is deprecated, use qcom,calibration-variant instead
Konrad
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (5 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:33 ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id Paul Sajna
` (4 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
Firmware nodes added for ipa, modem, bluetooth, venus
adsp and cdsp enabled
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 8 ++++++++
2 files changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 585582ff4e0bbe8c994328278d5e5dd3a280ddb6..cc1c78162eedd50d30a70810ac3790efe6c0492f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -173,6 +173,10 @@ &adsp_pas {
status = "okay";
};
+&cdsp_pas {
+ status = "okay";
+};
+
&apps_rsc {
regulators-0 {
compatible = "qcom,pm8998-rpmh-regulators";
@@ -483,6 +487,8 @@ zap-shader {
&ipa {
qcom,gsi-loader = "modem";
+ memory-region = <&ipa_fw_mem>;
+
status = "okay";
};
@@ -683,6 +689,10 @@ &uart9 {
status = "okay";
};
+&venus {
+ status = "okay";
+};
+
&wifi {
vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index fae85d4c1520e044d8166bb22a8f5762fda250b2..1596a3408659323d60f1b7c395098ed628782dfa 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -70,6 +70,10 @@ zap-shader {
};
};
+&ipa {
+ firmware-name = "qcom/sdm845/judyln/ipa_fws.mbn";
+};
+
&mss_pil {
firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
};
@@ -190,3 +194,7 @@ bluetooth {
firmware-name = "judyln/crnv21.bin";
};
};
+
+&venus {
+ firmware-name = "qcom/sdm845/judyln/venus.mbn";
+};
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes
2025-09-13 23:56 ` [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes Paul Sajna
@ 2025-09-15 0:33 ` Dmitry Baryshkov
0 siblings, 0 replies; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:33 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:40PM -0700, Paul Sajna wrote:
> Firmware nodes added for ipa, modem, bluetooth, venus
>
> adsp and cdsp enabled
I'm not sure what is written here. Please describe the change according
to Documentation/process/submitting-patches.rst
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 8 ++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 585582ff4e0bbe8c994328278d5e5dd3a280ddb6..cc1c78162eedd50d30a70810ac3790efe6c0492f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -173,6 +173,10 @@ &adsp_pas {
> status = "okay";
> };
>
> +&cdsp_pas {
> + status = "okay";
> +};
> +
> &apps_rsc {
> regulators-0 {
> compatible = "qcom,pm8998-rpmh-regulators";
> @@ -483,6 +487,8 @@ zap-shader {
>
> &ipa {
> qcom,gsi-loader = "modem";
> + memory-region = <&ipa_fw_mem>;
> +
> status = "okay";
> };
>
> @@ -683,6 +689,10 @@ &uart9 {
> status = "okay";
> };
>
> +&venus {
> + status = "okay";
> +};
> +
> &wifi {
> vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
> vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index fae85d4c1520e044d8166bb22a8f5762fda250b2..1596a3408659323d60f1b7c395098ed628782dfa 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -70,6 +70,10 @@ zap-shader {
> };
> };
>
> +&ipa {
> + firmware-name = "qcom/sdm845/judyln/ipa_fws.mbn";
Note: it should be qcom/sdm845/lg/judyln/.... (or qcom/sdm845/LG/judyln)
Would you mind fixing it to follow the convention?
> +};
> +
> &mss_pil {
> firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
> };
> @@ -190,3 +194,7 @@ bluetooth {
> firmware-name = "judyln/crnv21.bin";
> };
> };
> +
> +&venus {
> + firmware-name = "qcom/sdm845/judyln/venus.mbn";
> +};
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (6 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-14 10:22 ` Krzysztof Kozlowski
2025-09-13 23:56 ` [PATCH 09/11] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
` (3 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
SDM845 msm-id and board-id added
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 3 +++
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 1 +
2 files changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index cc1c78162eedd50d30a70810ac3790efe6c0492f..3853f0e5d89ca87b6fe7882e50ab9421a42efb0d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -5,6 +5,7 @@
* Copyright (c) 2022, The Linux Foundation. All rights reserved.
*/
+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
@@ -28,6 +29,8 @@
/delete-node/ &wlan_msa_mem;
/ {
+ qcom,msm-id = <QCOM_ID_SDM845 0x20001>;
+
chosen {
#address-cells = <2>;
#size-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 1596a3408659323d60f1b7c395098ed628782dfa..467aa0fd0ef3938e4a8c08b2240d4dca2f74dbcd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -12,6 +12,7 @@
/ {
model = "LG G7 ThinQ";
compatible = "lg,judyln", "qcom,sdm845";
+ qcom,board-id = <0x020C0008 0>;
chosen {
framebuffer@9d400000 {
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id
2025-09-13 23:56 ` [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id Paul Sajna
@ 2025-09-14 10:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 29+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-14 10:22 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown
On 14/09/2025 01:56, Paul Sajna wrote:
> SDM845 msm-id and board-id added
We see this from the diff. Don't repeat the diff in the commit msg,
that's not its purpose. You need to explain why. Especially that these
properties are deprecated and should not be used in general.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 09/11] arm64: dts: qcom: sdm845-lg-common: Add chassis-type
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (7 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:34 ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 10/11] arm64: dts: qcom: sdm845-lg-judyln: Sort and cleanup nodes Paul Sajna
` (2 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
The sdm845-lg devices are all phones, therefore handset chassis
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 3853f0e5d89ca87b6fe7882e50ab9421a42efb0d..1f4427194fddea238c1b97afd8494d08b006a40a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -30,6 +30,7 @@
/ {
qcom,msm-id = <QCOM_ID_SDM845 0x20001>;
+ chassis-type = "handset";
chosen {
#address-cells = <2>;
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 09/11] arm64: dts: qcom: sdm845-lg-common: Add chassis-type
2025-09-13 23:56 ` [PATCH 09/11] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
@ 2025-09-15 0:34 ` Dmitry Baryshkov
0 siblings, 0 replies; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:34 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:42PM -0700, Paul Sajna wrote:
> The sdm845-lg devices are all phones, therefore handset chassis
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 10/11] arm64: dts: qcom: sdm845-lg-judyln: Sort and cleanup nodes
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (8 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 09/11] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-15 0:35 ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: " Paul Sajna
2025-11-18 20:13 ` [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Pavel Machek
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
Fix style issues and sort alphabetically
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 467aa0fd0ef3938e4a8c08b2240d4dca2f74dbcd..493b8554ad8ef083d836a6664435010ea915f2e8 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -75,15 +75,6 @@ &ipa {
firmware-name = "qcom/sdm845/judyln/ipa_fws.mbn";
};
-&mss_pil {
- firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
-};
-
-&pmi8998_charger {
- status = "okay";
- monitored-battery = <&battery>;
-};
-
&ibb {
regulator-min-microvolt = <4600000>;
regulator-max-microvolt = <6000000>;
@@ -144,6 +135,16 @@ &mdss_dsi0_out {
data-lanes = <0 1 2 3>;
};
+&mss_pil {
+ firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
+};
+
+&pmi8998_charger {
+ monitored-battery = <&battery>;
+
+ status = "okay";
+};
+
&pmi8998_wled {
status = "okay";
};
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 10/11] arm64: dts: qcom: sdm845-lg-judyln: Sort and cleanup nodes
2025-09-13 23:56 ` [PATCH 10/11] arm64: dts: qcom: sdm845-lg-judyln: Sort and cleanup nodes Paul Sajna
@ 2025-09-15 0:35 ` Dmitry Baryshkov
0 siblings, 0 replies; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-09-15 0:35 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
On Sat, Sep 13, 2025 at 04:56:43PM -0700, Paul Sajna wrote:
> Fix style issues and sort alphabetically
Please perform cleanups before actual changes. In this case, however, I
think this patch should be folded into the MDSS patch, making the nodes
sorted from the beginning.
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 467aa0fd0ef3938e4a8c08b2240d4dca2f74dbcd..493b8554ad8ef083d836a6664435010ea915f2e8 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -75,15 +75,6 @@ &ipa {
> firmware-name = "qcom/sdm845/judyln/ipa_fws.mbn";
> };
>
> -&mss_pil {
> - firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
> -};
> -
> -&pmi8998_charger {
> - status = "okay";
> - monitored-battery = <&battery>;
> -};
> -
> &ibb {
> regulator-min-microvolt = <4600000>;
> regulator-max-microvolt = <6000000>;
> @@ -144,6 +135,16 @@ &mdss_dsi0_out {
> data-lanes = <0 1 2 3>;
> };
>
> +&mss_pil {
> + firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
> +};
> +
> +&pmi8998_charger {
> + monitored-battery = <&battery>;
> +
> + status = "okay";
> +};
> +
> &pmi8998_wled {
> status = "okay";
> };
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: Sort and cleanup nodes
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (9 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 10/11] arm64: dts: qcom: sdm845-lg-judyln: Sort and cleanup nodes Paul Sajna
@ 2025-09-13 23:56 ` Paul Sajna
2025-09-14 10:24 ` Krzysztof Kozlowski
2025-11-18 20:13 ` [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Pavel Machek
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-09-13 23:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown, Paul Sajna
Fix style issues and sort alphabetically
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 226 ++++++++++++-------------
1 file changed, 113 insertions(+), 113 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 1f4427194fddea238c1b97afd8494d08b006a40a..cbdd0c537a591a4c5365b0cb3a85d85e5c1269fa 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -45,8 +45,8 @@ reserved-memory {
#size-cells = <2>;
ranges;
- qseecom_mem: memory@b2000000 {
- reg = <0 0xb2000000 0 0x1800000>;
+ ipa_fw_mem: memory@8c400000 {
+ reg = <0 0x8c400000 0 0x10000>;
no-map;
};
@@ -55,11 +55,6 @@ gpu_mem: memory@8c415000 {
no-map;
};
- ipa_fw_mem: memory@8c400000 {
- reg = <0 0x8c400000 0 0x10000>;
- no-map;
- };
-
adsp_mem: memory@8c500000 {
reg = <0 0x8c500000 0 0x1e00000>;
no-map;
@@ -100,9 +95,8 @@ spss_mem: memory@99000000 {
no-map;
};
- /* Framebuffer region */
- memory@9d400000 {
- reg = <0x0 0x9d400000 0x0 0x2400000>;
+ qseecom_mem: memory@b2000000 {
+ reg = <0 0xb2000000 0 0x1800000>;
no-map;
};
@@ -465,11 +459,11 @@ vreg_s3c_0p6: smps3 {
};
};
-&cdsp_pas {
+&adsp_pas {
status = "okay";
};
-&gmu {
+&cdsp_pas {
status = "okay";
};
@@ -481,6 +475,10 @@ &gcc {
<GCC_LPASS_SWAY_CLK>;
};
+&gmu {
+ status = "okay";
+};
+
&gpu {
status = "okay";
@@ -500,74 +498,88 @@ &mss_pil {
status = "okay";
};
+&pm8998_gpios {
+ vol_up_pin_a: vol-up-active-state {
+ pins = "gpio6";
+ function = "normal";
+ input-enable;
+ bias-pull-up;
+ qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
+ };
+};
+
&pm8998_resin {
linux,code = <KEY_VOLUMEDOWN>;
- status = "okay";
-};
-&sdhc_2 {
status = "okay";
+};
- cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&sdc2_clk &sdc2_cmd &sdc2_data &sd_card_det_n>;
+&pmi8998_flash {
+ status = "okay";
- vmmc-supply = <&vreg_l21a_2p95>;
- vqmmc-supply = <&vddpx_2>;
+ led-0 {
+ label = "flash";
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <1>;
+ led-max-microamp = <850000>;
+ flash-max-microamp = <850000>;
+ flash-max-timeout-us = <500000>;
+ };
};
-/*
- * UFS works partially and only with clk_ignore_unused.
- * Sometimes it crashes with I/O errors.
- */
-&ufs_mem_hc {
+&pmi8998_wled {
status = "okay";
-
- reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
-
- vcc-supply = <&vreg_l20a_2p95>;
- vcc-max-microamp = <600000>;
};
-&ufs_mem_phy {
+&pmi8998_lpg {
status = "okay";
- vdda-phy-supply = <&vdda_ufs1_core>;
- vdda-pll-supply = <&vdda_ufs1_1p2>;
+ led@0 {
+ label = "blue";
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ default-state = "off";
+ };
+
+ led@1 {
+ label = "green";
+ reg = <4>;
+ color = <LED_COLOR_ID_GREEN>;
+ default-state = "off";
+ };
+
+ led@2 {
+ label = "red";
+ reg = <5>;
+ color = <LED_COLOR_ID_RED>;
+ default-state = "off";
+ };
};
-&usb_1 {
- status = "okay";
+&qup_uart9_rx {
+ drive-strength = <2>;
+ bias-pull-up;
};
-&usb_1_dwc3 {
- /* TODO: these devices have usb id pin */
- dr_mode = "peripheral";
+&qup_uart9_tx {
+ drive-strength = <2>;
+ bias-disable;
};
-&usb_1_hsphy {
- status = "okay";
+&sdhc_2 {
+ cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vdda_usb1_ss_core>;
- vdda-pll-supply = <&vdda_qusb_hs0_1p8>;
- vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdc2_clk &sdc2_cmd &sdc2_data &sd_card_det_n>;
- qcom,imp-res-offset-value = <8>;
- qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>;
- qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>;
- qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>;
-};
+ vmmc-supply = <&vreg_l21a_2p95>;
+ vqmmc-supply = <&vddpx_2>;
-&usb_1_qmpphy {
status = "okay";
-
- vdda-phy-supply = <&vdda_usb1_ss_1p2>;
- vdda-pll-supply = <&vdda_usb1_ss_core>;
};
-/* PINCTRL - additions to nodes defined in sdm845.dtsi */
-
&tlmm {
gpio-reserved-ranges = <28 4>, <81 4>;
@@ -604,91 +616,79 @@ sd_card_det_n: sd-card-det-n-state {
};
};
-&pm8998_gpios {
- vol_up_pin_a: vol-up-active-state {
- pins = "gpio6";
- function = "normal";
- input-enable;
- bias-pull-up;
- qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
- };
+&qupv3_id_0 {
+ status = "okay";
};
-&pmi8998_flash {
+&qupv3_id_1 {
status = "okay";
-
- led-0 {
- label = "flash";
- function = LED_FUNCTION_FLASH;
- color = <LED_COLOR_ID_WHITE>;
- led-sources = <1>;
- led-max-microamp = <850000>;
- flash-max-microamp = <850000>;
- flash-max-timeout-us = <500000>;
- };
};
-&pmi8998_lpg {
+&uart6 {
+ pinctrl-0 = <&qup_uart6_4pin>;
+
status = "okay";
- led@0 {
- label = "blue";
- reg = <3>;
- color = <LED_COLOR_ID_BLUE>;
- default-state = "off";
+ bluetooth {
+ compatible = "qcom,wcn3990-bt";
+ vddio-supply = <&vreg_s4a_1p8>;
+ vddxo-supply = <&vreg_l7a_1p8>;
+ vddrf-supply = <&vreg_l17a_1p3>;
+ vddch0-supply = <&vreg_l25a_3p3>;
+ max-speed = <3200000>;
};
+};
- led@1 {
- label = "green";
- reg = <4>;
- color = <LED_COLOR_ID_GREEN>;
- default-state = "off";
- };
+&uart9 {
+ label = "LS-UART1";
- led@2 {
- label = "red";
- reg = <5>;
- color = <LED_COLOR_ID_RED>;
- default-state = "off";
- };
+ status = "okay";
};
-&qupv3_id_0 {
+/*
+ * UFS works partially and only with clk_ignore_unused.
+ * Sometimes it crashes with I/O errors.
+ */
+&ufs_mem_hc {
+ reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vreg_l20a_2p95>;
+ vcc-max-microamp = <600000>;
+
status = "okay";
};
-&qupv3_id_1 {
+&ufs_mem_phy {
+ vdda-phy-supply = <&vdda_ufs1_core>;
+ vdda-pll-supply = <&vdda_ufs1_1p2>;
+
status = "okay";
};
-&qup_uart9_rx {
- drive-strength = <2>;
- bias-pull-up;
+&usb_1 {
+ status = "okay";
};
-&qup_uart9_tx {
- drive-strength = <2>;
- bias-disable;
+&usb_1_dwc3 {
+ dr_mode = "peripheral";
+ maximum-speed = "high-speed";
};
-&uart6 {
- pinctrl-0 = <&qup_uart6_4pin>;
-
- status = "okay";
+&usb_1_hsphy {
+ vdd-supply = <&vdda_usb1_ss_core>;
+ vdda-pll-supply = <&vdda_qusb_hs0_1p8>;
+ vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>;
- bluetooth {
- compatible = "qcom,wcn3990-bt";
+ qcom,imp-res-offset-value = <8>;
+ qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>;
+ qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>;
+ qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>;
- vddio-supply = <&vreg_s4a_1p8>;
- vddxo-supply = <&vreg_l7a_1p8>;
- vddrf-supply = <&vreg_l17a_1p3>;
- vddch0-supply = <&vreg_l25a_3p3>;
- max-speed = <3200000>;
- };
+ status = "okay";
};
-&uart9 {
- label = "LS-UART1";
+&usb_1_qmpphy {
+ vdda-phy-supply = <&vdda_usb1_ss_1p2>;
+ vdda-pll-supply = <&vdda_usb1_ss_core>;
status = "okay";
};
--
2.51.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: Sort and cleanup nodes
2025-09-13 23:56 ` [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: " Paul Sajna
@ 2025-09-14 10:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 29+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-14 10:24 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, Amir Dahan,
Christopher Brown
On 14/09/2025 01:56, Paul Sajna wrote:
> Fix style issues and sort alphabetically
What style issues? Why are you re-sorting this? Answer to these in the
commit msg.
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> -&uart6 {
> - pinctrl-0 = <&qup_uart6_4pin>;
> -
> - status = "okay";
> +&usb_1_hsphy {
> + vdd-supply = <&vdda_usb1_ss_core>;
> + vdda-pll-supply = <&vdda_qusb_hs0_1p8>;
> + vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>;
>
> - bluetooth {
> - compatible = "qcom,wcn3990-bt";
> + qcom,imp-res-offset-value = <8>;
> + qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>;
> + qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>;
> + qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>;
>
> - vddio-supply = <&vreg_s4a_1p8>;
> - vddxo-supply = <&vreg_l7a_1p8>;
> - vddrf-supply = <&vreg_l17a_1p3>;
> - vddch0-supply = <&vreg_l25a_3p3>;
> - max-speed = <3200000>;
You just added all these on other patch, no? Don't add code which is
knowingly incorrect or have to be immediately adjusted. Probably you
organized the patchset wrong and any sorting should be done earlier,
assuming that we want this sorting in the first place?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (10 preceding siblings ...)
2025-09-13 23:56 ` [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: " Paul Sajna
@ 2025-11-18 20:13 ` Pavel Machek
11 siblings, 0 replies; 29+ messages in thread
From: Pavel Machek @ 2025-11-18 20:13 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Amir Dahan, Christopher Brown
[-- Attachment #1: Type: text/plain, Size: 2092 bytes --]
Hi!
> Rollup of improved hardware support via devicetree for LG G7 ThinQ
> (judyln) from sdm845-mainline kernel fork
>
> Notably, this patch-series enables full DRM acceleration and wifi,
> among other small improvements in individual commits
>
> after this patch-series the main things that remain to be worked
> on include touchscreen, audio, and modem.
Thanks for doing this... and please cc phone-devel@vger.kernel.org
with phone patches :-).
(And I see this is another device similar to OnePlus 6. Good. It
should be possible to get cameras there working, too).
Best regards,
Pavel
> ---
> Paul Sajna (11):
> arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
> arm64: dts: qcom sdm845-lg-judyln: Add battery and charger
> arm64: dts: qcom: sdm845-lg-common: Add leds
> arm64: dts: qcom: sdm845-lg-common: Add camera flash
> arm64: dts: qcom: sdm845-lg-judyln: Add display panel
> arm64: dts: qcom: sdm845-lg-common: Add wifi node
> arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes
> arm64: dts: qcom: sdm845-lg-common: Add qcom id
> arm64: dts: qcom: sdm845-lg-common: Add chassis-type
> arm64: dts: qcom: sdm845-lg-judyln: Sort and cleanup nodes
> arm64: dts: qcom: sdm845-lg-common: Sort and cleanup nodes
>
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 238 ++++++++++++++++++-------
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 134 ++++++++++++++
> 2 files changed, 310 insertions(+), 62 deletions(-)
> ---
> base-commit: 590b221ed4256fd6c34d3dea77aa5bd6e741bbc1
> change-id: 20250911-judyln-dts-17c41e59dc0f
> prerequisite-message-id: <20250910-judyln-panel-v1-1-825c74403bbb@postmarketos.org>
> prerequisite-patch-id: e51151ea7f8fdad6ad7d90713febc5c6b6fc4f9c
> prerequisite-patch-id: b3dd44250da9cd12bc5b2d0d7e865dbe19ceed92
> prerequisite-patch-id: fd6c8077806cb03fcf37d0e0d730314c2760e334
>
> Best regards,
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
