[PATCH v1] RISC-V: fix incorrect type of ARCH_CANAAN_K210_DTB_SOURCE

[PATCH v1] RISC-V: fix incorrect type of ARCH_CANAAN_K210_DTB_SOURCE

[Conor Dooley]

When adding the ARCH_ symbol for the builtin K210 dtb, I erroneously
used the bool type for something that is quite obviously a string.
Unfortunately, there is no such thing as "def_string", but in this case
we can use "default" to propagate the value of
SOC_CANAAN_K210_DTB_SOURCE to ARCH_CANAAN_K210_DTB_SOURCE.
ARCH_CANAAN_K210_DTB_SOURCE is not user selectable, so using
olddefconfig etc will update ARCH_CANAAN_K210_DTB_SOURCE to reflect any
changes made to SOC_CANAAN_K210_DTB_SOURCE.

Fixes: fc43211939bb ("RISC-V: kconfig.socs: convert usage of SOC_CANAAN to ARCH_CANAAN")
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
Palmer, this one's for you btw

CC: Geert Uytterhoeven <geert+renesas@glider.be>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: Damien Le Moal <damien.lemoal@opensource.wdc.com>
CC: linux-riscv@lists.infradead.org
---
 arch/riscv/Kconfig.socs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 34a54e5310a1..d36a5f39f13a 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -79,7 +79,8 @@ config SOC_CANAAN_K210_DTB_BUILTIN
 	  If unsure, say Y.
 
 config ARCH_CANAAN_K210_DTB_SOURCE
-	def_bool SOC_CANAAN_K210_DTB_SOURCE
+	string
+	default SOC_CANAAN_K210_DTB_SOURCE
 
 config SOC_CANAAN_K210_DTB_SOURCE
 	string "Source file for the Canaan Kendryte K210 builtin DTB"
-- 
2.39.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v1] RISC-V: fix incorrect type of ARCH_CANAAN_K210_DTB_SOURCE

[Geert Uytterhoeven]

On Wed, Jan 11, 2023 at 11:50 AM Conor Dooley
<conor.dooley@microchip.com> wrote:
> When adding the ARCH_ symbol for the builtin K210 dtb, I erroneously
> used the bool type for something that is quite obviously a string.
> Unfortunately, there is no such thing as "def_string", but in this case
> we can use "default" to propagate the value of
> SOC_CANAAN_K210_DTB_SOURCE to ARCH_CANAAN_K210_DTB_SOURCE.
> ARCH_CANAAN_K210_DTB_SOURCE is not user selectable, so using
> olddefconfig etc will update ARCH_CANAAN_K210_DTB_SOURCE to reflect any
> changes made to SOC_CANAAN_K210_DTB_SOURCE.
>
> Fixes: fc43211939bb ("RISC-V: kconfig.socs: convert usage of SOC_CANAAN to ARCH_CANAAN")
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v1] RISC-V: fix incorrect type of ARCH_CANAAN_K210_DTB_SOURCE

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Wed, 11 Jan 2023 10:48:49 +0000 you wrote:
> When adding the ARCH_ symbol for the builtin K210 dtb, I erroneously
> used the bool type for something that is quite obviously a string.
> Unfortunately, there is no such thing as "def_string", but in this case
> we can use "default" to propagate the value of
> SOC_CANAAN_K210_DTB_SOURCE to ARCH_CANAAN_K210_DTB_SOURCE.
> ARCH_CANAAN_K210_DTB_SOURCE is not user selectable, so using
> olddefconfig etc will update ARCH_CANAAN_K210_DTB_SOURCE to reflect any
> changes made to SOC_CANAAN_K210_DTB_SOURCE.
> 
> [...]

Here is the summary with links:
  - [v1] RISC-V: fix incorrect type of ARCH_CANAAN_K210_DTB_SOURCE
    https://git.kernel.org/riscv/c/f1b3dc80f0bb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv