From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: lgirdwood@gmail.com, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, steev@kali.org,
johan+linaro@kernel.org, quic_bjorande@quicinc.com
Subject: Re: [PATCH 0/8] ASoC: qcom: q6dsp and lpass codec stablity fixes
Date: Thu, 09 Feb 2023 18:36:12 +0000 [thread overview]
Message-ID: <167596777266.879652.13238381832493725395.b4-ty@kernel.org> (raw)
In-Reply-To: <20230209122806.18923-1-srinivas.kandagatla@linaro.org>
On Thu, 09 Feb 2023 12:27:58 +0000, Srinivas Kandagatla wrote:
> While testing X13s audio, we found multiple stablity issues this patchset
> fixes these issues.
> From q6dsp side issues are around locking of position pointer and handle
> multiple prepare cases along with pulse audio timerbased scheduling workaround.
>
> From LPASS codec side most of the staiblity issues were around runtime pm,
> hitting various issues as the codec was firstly resetting the soundwire block
> for every clk disable/enable which is taking the slaves out of sync and
> resulting in re-enumerating. Second issue was around fsgen clk is not
> brining up the codec out of suspend as it was not added after
> runtime pm enabled. Final issue was with codec mclk rate which should
> have been 192KHz same as npl instead of 96KHz. We were getting lucky as
> wsa drivers are setting the same clk to 192KHz.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/8] ASoC: qcom: q6apm-lpass-dai: unprepare stream if its already prepared
commit: c2ac3aec474da0455df79c4a182f19687bc98d1d
[2/8] ASoC: qcom: q6apm-dai: fix race condition while updating the position pointer
commit: 84222ef54bfd8f043c23c8603fd5257a64b00780
[3/8] ASoC: qcom: q6apm-dai: Add SNDRV_PCM_INFO_BATCH flag
commit: aa759f3f9f4394a3af65ad1772fca6cb9dd9e4cc
[4/8] ASoC: qcom: audioreach: fix ADSP ready check
commit: dd33c2e7b21d72b151a87b5dafffee2c019043e5
[5/8] ASoC: codecs: lpass: register mclk after runtime pm
commit: 1dc3459009c33e335f0d62b84dd39a6bbd7fd5d2
[6/8] ASoC: codecs: lpass: fix incorrect mclk rate
commit: e7621434378c40b62ef858c14ae6415fb6469a8e
[7/8] ASoC: codecs: lpass: do not reset soundwire block on clk enable
commit: ddffe3b82849ba2774d7a06fbe1cc7e83378c4d2
[8/8] ASoC: codecs: lpass: remove not so useful verbose log
commit: 777af241a7ce6ed95f8d3fcb028c08f9b40addb6
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
steev@kali.org, johan+linaro@kernel.org,
quic_bjorande@quicinc.com
Subject: Re: [PATCH 0/8] ASoC: qcom: q6dsp and lpass codec stablity fixes
Date: Thu, 09 Feb 2023 18:36:12 +0000 [thread overview]
Message-ID: <167596777266.879652.13238381832493725395.b4-ty@kernel.org> (raw)
In-Reply-To: <20230209122806.18923-1-srinivas.kandagatla@linaro.org>
On Thu, 09 Feb 2023 12:27:58 +0000, Srinivas Kandagatla wrote:
> While testing X13s audio, we found multiple stablity issues this patchset
> fixes these issues.
> From q6dsp side issues are around locking of position pointer and handle
> multiple prepare cases along with pulse audio timerbased scheduling workaround.
>
> From LPASS codec side most of the staiblity issues were around runtime pm,
> hitting various issues as the codec was firstly resetting the soundwire block
> for every clk disable/enable which is taking the slaves out of sync and
> resulting in re-enumerating. Second issue was around fsgen clk is not
> brining up the codec out of suspend as it was not added after
> runtime pm enabled. Final issue was with codec mclk rate which should
> have been 192KHz same as npl instead of 96KHz. We were getting lucky as
> wsa drivers are setting the same clk to 192KHz.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/8] ASoC: qcom: q6apm-lpass-dai: unprepare stream if its already prepared
commit: c2ac3aec474da0455df79c4a182f19687bc98d1d
[2/8] ASoC: qcom: q6apm-dai: fix race condition while updating the position pointer
commit: 84222ef54bfd8f043c23c8603fd5257a64b00780
[3/8] ASoC: qcom: q6apm-dai: Add SNDRV_PCM_INFO_BATCH flag
commit: aa759f3f9f4394a3af65ad1772fca6cb9dd9e4cc
[4/8] ASoC: qcom: audioreach: fix ADSP ready check
commit: dd33c2e7b21d72b151a87b5dafffee2c019043e5
[5/8] ASoC: codecs: lpass: register mclk after runtime pm
commit: 1dc3459009c33e335f0d62b84dd39a6bbd7fd5d2
[6/8] ASoC: codecs: lpass: fix incorrect mclk rate
commit: e7621434378c40b62ef858c14ae6415fb6469a8e
[7/8] ASoC: codecs: lpass: do not reset soundwire block on clk enable
commit: ddffe3b82849ba2774d7a06fbe1cc7e83378c4d2
[8/8] ASoC: codecs: lpass: remove not so useful verbose log
commit: 777af241a7ce6ed95f8d3fcb028c08f9b40addb6
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
next prev parent reply other threads:[~2023-02-09 18:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 12:27 [PATCH 0/8] ASoC: qcom: q6dsp and lpass codec stablity fixes Srinivas Kandagatla
2023-02-09 12:27 ` Srinivas Kandagatla
2023-02-09 12:27 ` [PATCH 1/8] ASoC: qcom: q6apm-lpass-dai: unprepare stream if its already prepared Srinivas Kandagatla
2023-02-09 12:27 ` Srinivas Kandagatla
2023-02-09 12:28 ` [PATCH 2/8] ASoC: qcom: q6apm-dai: fix race condition while updating the position pointer Srinivas Kandagatla
2023-02-09 12:28 ` Srinivas Kandagatla
2023-02-09 12:28 ` [PATCH 3/8] ASoC: qcom: q6apm-dai: Add SNDRV_PCM_INFO_BATCH flag Srinivas Kandagatla
2023-02-09 12:28 ` Srinivas Kandagatla
2023-02-09 12:28 ` [PATCH 4/8] ASoC: qcom: audioreach: fix ADSP ready check Srinivas Kandagatla
2023-02-09 12:28 ` Srinivas Kandagatla
2023-02-09 12:28 ` [PATCH 5/8] ASoC: codecs: lpass: register mclk after runtime pm Srinivas Kandagatla
2023-02-09 12:28 ` Srinivas Kandagatla
2023-03-24 11:22 ` Luca Weiss
2023-03-24 11:22 ` Luca Weiss
2023-03-24 13:40 ` Srinivas Kandagatla
2023-03-24 13:40 ` Srinivas Kandagatla
2023-03-31 11:42 ` Luca Weiss
2023-03-31 11:42 ` Luca Weiss
2023-02-09 12:28 ` [PATCH 6/8] ASoC: codecs: lpass: fix incorrect mclk rate Srinivas Kandagatla
2023-02-09 12:28 ` Srinivas Kandagatla
2023-02-09 12:28 ` [PATCH 7/8] ASoC: codecs: lpass: do not reset soundwire block on clk enable Srinivas Kandagatla
2023-02-09 12:28 ` Srinivas Kandagatla
2023-02-09 12:28 ` [PATCH 8/8] ASoC: codecs: lpass: remove not so useful verbose log Srinivas Kandagatla
2023-02-09 12:28 ` Srinivas Kandagatla
2023-02-09 18:36 ` Mark Brown [this message]
2023-02-09 18:36 ` [PATCH 0/8] ASoC: qcom: q6dsp and lpass codec stablity fixes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167596777266.879652.13238381832493725395.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=johan+linaro@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steev@kali.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.