* [PATCH net-next] net/mlx5e: Align IPsec ASO result memory to be as required by hardware
@ 2023-02-19 9:09 Leon Romanovsky
2023-02-21 1:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2023-02-19 9:09 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski
Cc: Leon Romanovsky, Emeel Hakim, Eric Dumazet, netdev, Paolo Abeni,
Raed Salem, Saeed Mahameed, Steffen Klassert
From: Leon Romanovsky <leonro@nvidia.com>
Hardware requires an alignment to 64 bytes to return ASO data. Missing
this alignment caused to unpredictable results while ASO events were
generated.
Fixes: 8518d05b8f9a ("net/mlx5e: Create Advanced Steering Operation object for IPsec")
Reported-by: Emeel Hakim <ehakim@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h
index ddd7be05f18f..12f044330639 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h
@@ -129,7 +129,7 @@ struct mlx5e_ipsec_work {
};
struct mlx5e_ipsec_aso {
- u8 ctx[MLX5_ST_SZ_BYTES(ipsec_aso)];
+ u8 __aligned(64) ctx[MLX5_ST_SZ_BYTES(ipsec_aso)];
dma_addr_t dma_addr;
struct mlx5_aso *aso;
/* Protect ASO WQ access, as it is global to whole IPsec */
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Align IPsec ASO result memory to be as required by hardware
2023-02-19 9:09 [PATCH net-next] net/mlx5e: Align IPsec ASO result memory to be as required by hardware Leon Romanovsky
@ 2023-02-21 1:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-21 1:00 UTC (permalink / raw)
To: Leon Romanovsky
Cc: davem, kuba, leonro, ehakim, edumazet, netdev, pabeni, raeds,
saeedm, steffen.klassert
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 19 Feb 2023 11:09:10 +0200 you wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Hardware requires an alignment to 64 bytes to return ASO data. Missing
> this alignment caused to unpredictable results while ASO events were
> generated.
>
> Fixes: 8518d05b8f9a ("net/mlx5e: Create Advanced Steering Operation object for IPsec")
> Reported-by: Emeel Hakim <ehakim@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>
> [...]
Here is the summary with links:
- [net-next] net/mlx5e: Align IPsec ASO result memory to be as required by hardware
https://git.kernel.org/netdev/net-next/c/f2b6cfda76d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-21 1:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-19 9:09 [PATCH net-next] net/mlx5e: Align IPsec ASO result memory to be as required by hardware Leon Romanovsky
2023-02-21 1:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.