All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Kevin Hilman <khilman@linaro.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH] PM / Sleep: Fall back to subsystem level PM callbacks for PM domains
Date: Wed, 30 Apr 2014 00:52:17 +0200	[thread overview]
Message-ID: <1679843.u9z8cZFExt@vostro.rjw.lan> (raw)
In-Reply-To: <1753685.C73DLtyD2t@vostro.rjw.lan>

On Wednesday, April 30, 2014 12:47:28 AM Rafael J. Wysocki wrote:
> On Friday, April 25, 2014 12:44:55 PM Ulf Hansson wrote:
> > Previously once the PM core found a PM domain pointer for a device,
> > but which didn't have a valid PM callback, it falled back to try the
> > driver's PM callback.
> > 
> > In this scenario, change the behavior of the PM core to try out the
> > other subsystem level PM callbacks, before it moves on to the driver.
> > 
> > This gives provision for PM domains to easier re-use subsystem level
> > code to handle the needed operations.
> > 
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> Are you sure this is not going to break the existing PM domains?

And even if it isn't, the idea behind PM domains was to provide a mechanism to
bypass the bus types' (etc) PM callbacks, so I'm not liking this patch at all.

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

WARNING: multiple messages have this Message-ID (diff)
From: rjw@rjwysocki.net (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / Sleep: Fall back to subsystem level PM callbacks for PM domains
Date: Wed, 30 Apr 2014 00:52:17 +0200	[thread overview]
Message-ID: <1679843.u9z8cZFExt@vostro.rjw.lan> (raw)
In-Reply-To: <1753685.C73DLtyD2t@vostro.rjw.lan>

On Wednesday, April 30, 2014 12:47:28 AM Rafael J. Wysocki wrote:
> On Friday, April 25, 2014 12:44:55 PM Ulf Hansson wrote:
> > Previously once the PM core found a PM domain pointer for a device,
> > but which didn't have a valid PM callback, it falled back to try the
> > driver's PM callback.
> > 
> > In this scenario, change the behavior of the PM core to try out the
> > other subsystem level PM callbacks, before it moves on to the driver.
> > 
> > This gives provision for PM domains to easier re-use subsystem level
> > code to handle the needed operations.
> > 
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> Are you sure this is not going to break the existing PM domains?

And even if it isn't, the idea behind PM domains was to provide a mechanism to
bypass the bus types' (etc) PM callbacks, so I'm not liking this patch at all.

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2014-04-29 22:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 10:44 [PATCH] PM / Sleep: Fall back to subsystem level PM callbacks for PM domains Ulf Hansson
2014-04-25 10:44 ` Ulf Hansson
2014-04-29 22:47 ` Rafael J. Wysocki
2014-04-29 22:47   ` Rafael J. Wysocki
2014-04-29 22:52   ` Rafael J. Wysocki [this message]
2014-04-29 22:52     ` Rafael J. Wysocki
2014-04-30 12:15     ` Ulf Hansson
2014-04-30 12:15       ` Ulf Hansson
2014-05-21  9:36       ` Ulf Hansson
2014-05-21  9:36         ` Ulf Hansson
2014-05-21 11:05         ` Rafael J. Wysocki
2014-05-21 11:05           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1679843.u9z8cZFExt@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=khilman@linaro.org \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=stern@rowland.harvard.edu \
    --cc=tomasz.figa@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.