From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Soha Jin <soha@lohu.info>,
palmer@dabbelt.com, Wende Tan <twd2.me@gmail.com>,
conor@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
Hongren Zheng <i@zenithal.me>, Yangyu Chen <cyy@cyyself.name>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v1 2/2] dt-bindings: riscv: drop invalid comment about riscv,isa lower-case reasoning
Date: Thu, 27 Apr 2023 11:06:22 -0500 [thread overview]
Message-ID: <168261158214.3107331.4410018416833510357.robh@kernel.org> (raw)
In-Reply-To: <20230426-payphone-nautical-7098d15035c8@wendy>
On Wed, 26 Apr 2023 11:43:25 +0100, Conor Dooley wrote:
> "Ease of parsing" may have been the initial argument for keeping this
> string in lower-case, but parsers may have been written that expect
> lower-case only.
> For example, the one in released kernels currently does not behave
> correctly for multi-letter extensions that begin with a capital letter.
> Allowing upper-case here brings about no benefit but would break
> compatibility between new devicetrees and older kernels.
>
> Drop the comment to avoid confusing people.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/riscv/cpus.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Soha Jin <soha@lohu.info>,
palmer@dabbelt.com, Wende Tan <twd2.me@gmail.com>,
conor@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
Hongren Zheng <i@zenithal.me>, Yangyu Chen <cyy@cyyself.name>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v1 2/2] dt-bindings: riscv: drop invalid comment about riscv,isa lower-case reasoning
Date: Thu, 27 Apr 2023 11:06:22 -0500 [thread overview]
Message-ID: <168261158214.3107331.4410018416833510357.robh@kernel.org> (raw)
In-Reply-To: <20230426-payphone-nautical-7098d15035c8@wendy>
On Wed, 26 Apr 2023 11:43:25 +0100, Conor Dooley wrote:
> "Ease of parsing" may have been the initial argument for keeping this
> string in lower-case, but parsers may have been written that expect
> lower-case only.
> For example, the one in released kernels currently does not behave
> correctly for multi-letter extensions that begin with a capital letter.
> Allowing upper-case here brings about no benefit but would break
> compatibility between new devicetrees and older kernels.
>
> Drop the comment to avoid confusing people.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/riscv/cpus.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-04-27 16:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 10:43 [PATCH v1 0/2] Handle multi-letter extensions starting with caps in riscv,isa Conor Dooley
2023-04-26 10:43 ` Conor Dooley
2023-04-26 10:43 ` [PATCH v1 1/2] RISC-V: skip parsing multi-letter extensions starting with caps Conor Dooley
2023-04-26 10:43 ` Conor Dooley
2023-04-26 12:18 ` Andrew Jones
2023-04-26 12:18 ` Andrew Jones
2023-04-26 12:47 ` Conor Dooley
2023-04-26 12:47 ` Conor Dooley
2023-04-26 13:08 ` Andrew Jones
2023-04-26 13:08 ` Andrew Jones
2023-04-26 13:54 ` Andrew Jones
2023-04-26 13:54 ` Andrew Jones
2023-04-26 14:37 ` Conor Dooley
2023-04-26 14:37 ` Conor Dooley
2023-04-26 15:01 ` Andrew Jones
2023-04-26 15:01 ` Andrew Jones
2023-04-26 17:11 ` Yangyu Chen
2023-04-26 17:11 ` Yangyu Chen
2023-04-26 17:47 ` Conor Dooley
2023-04-26 17:47 ` Conor Dooley
2023-04-26 13:58 ` Conor Dooley
2023-04-26 13:58 ` Conor Dooley
2023-04-26 14:27 ` Andrew Jones
2023-04-26 14:27 ` Andrew Jones
2023-04-26 10:43 ` [PATCH v1 2/2] dt-bindings: riscv: drop invalid comment about riscv,isa lower-case reasoning Conor Dooley
2023-04-26 10:43 ` Conor Dooley
2023-04-26 12:20 ` Andrew Jones
2023-04-26 12:20 ` Andrew Jones
2023-04-27 16:06 ` Rob Herring [this message]
2023-04-27 16:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168261158214.3107331.4410018416833510357.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=i@zenithal.me \
--cc=krzk+dt@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=soha@lohu.info \
--cc=twd2.me@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.