From: patchwork-bot+f2fs@kernel.org
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode
Date: Wed, 07 Jun 2023 17:30:25 +0000 [thread overview]
Message-ID: <168615902514.7521.467509343163618820.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230531014055.3904072-1-chao@kernel.org>
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:
On Wed, 31 May 2023 09:40:55 +0800 you wrote:
> There are several issues in sanity_check_inode():
> - The code looks not clean, it checks extra_attr related condition
> dispersively.
> - It missed to check i_extra_isize w/ lower boundary
> - It missed to check feature dependency: prjquota, inode_chksum,
> inode_crtime, compression features rely on extra_attr feature.
> - It's not necessary to check i_extra_isize due to it will only
> be assigned to non-zero value if f2fs_has_extra_attr() is true
> in do_read_inode().
>
> [...]
Here is the summary with links:
- [f2fs-dev,v2] f2fs: do more sanity check on inode
https://git.kernel.org/jaegeuk/f2fs/c/3ef38938753c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+f2fs@kernel.org
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode
Date: Wed, 07 Jun 2023 17:30:25 +0000 [thread overview]
Message-ID: <168615902514.7521.467509343163618820.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230531014055.3904072-1-chao@kernel.org>
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:
On Wed, 31 May 2023 09:40:55 +0800 you wrote:
> There are several issues in sanity_check_inode():
> - The code looks not clean, it checks extra_attr related condition
> dispersively.
> - It missed to check i_extra_isize w/ lower boundary
> - It missed to check feature dependency: prjquota, inode_chksum,
> inode_crtime, compression features rely on extra_attr feature.
> - It's not necessary to check i_extra_isize due to it will only
> be assigned to non-zero value if f2fs_has_extra_attr() is true
> in do_read_inode().
>
> [...]
Here is the summary with links:
- [f2fs-dev,v2] f2fs: do more sanity check on inode
https://git.kernel.org/jaegeuk/f2fs/c/3ef38938753c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-06-07 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 1:40 [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode Chao Yu
2023-05-31 1:40 ` Chao Yu
2023-06-07 17:30 ` patchwork-bot+f2fs [this message]
2023-06-07 17:30 ` [f2fs-dev] " patchwork-bot+f2fs
2023-06-12 20:16 ` Jaegeuk Kim
2023-06-12 20:16 ` Jaegeuk Kim
2023-06-13 1:17 ` [f2fs-dev] " Chao Yu
2023-06-13 1:17 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168615902514.7521.467509343163618820.git-patchwork-notify@kernel.org \
--to=patchwork-bot+f2fs@kernel.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.