All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+f2fs@kernel.org
To: Jan Kara <jack@suse.cz>
Cc: viro@ZenIV.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
	miklos@szeredi.hu, djwong@kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	jaegeuk@kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 0/6] fs: Fix directory corruption when moving directories
Date: Thu, 06 Jul 2023 00:18:14 +0000	[thread overview]
Message-ID: <168860269498.29151.2669410551132746914.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230601104525.27897-1-jack@suse.cz>

Hello:

This series was applied to jaegeuk/f2fs.git (dev)
by Christian Brauner <brauner@kernel.org>:

On Thu,  1 Jun 2023 12:58:20 +0200 you wrote:
> Hello,
> 
> this patch set fixes a problem with cross directory renames originally reported
> in [1]. To quickly sum it up some filesystems (so far we know at least about
> ext4, udf, f2fs, ocfs2, likely also reiserfs, gfs2 and others) need to lock the
> directory when it is being renamed into another directory. This is because we
> need to update the parent pointer in the directory in that case and if that
> races with other operation on the directory (in particular a conversion from
> one directory format into another), bad things can happen.
> 
> [...]

Here is the summary with links:
  - [f2fs-dev,v2,1/6] ext4: Remove ext4 locking of moved directory
    https://git.kernel.org/jaegeuk/f2fs/c/3658840cd363
  - [f2fs-dev,v2,2/6] Revert "udf: Protect rename against modification of moved directory"
    https://git.kernel.org/jaegeuk/f2fs/c/7517ce5dc4d6
  - [f2fs-dev,v2,3/6] Revert "f2fs: fix potential corruption when moving a directory"
    https://git.kernel.org/jaegeuk/f2fs/c/cde3c9d7e2a3
  - [f2fs-dev,v2,4/6] fs: Establish locking order for unrelated directories
    (no matching commit)
  - [f2fs-dev,v2,5/6] fs: Lock moved directories
    https://git.kernel.org/jaegeuk/f2fs/c/28eceeda130f
  - [f2fs-dev,v2,6/6] fs: Restrict lock_two_nondirectories() to non-directory inodes
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+f2fs@kernel.org
To: Jan Kara <jack@suse.cz>
Cc: brauner@kernel.org, tytso@mit.edu, miklos@szeredi.hu,
	djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, viro@ZenIV.linux.org.uk,
	linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
	linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 0/6] fs: Fix directory corruption when moving directories
Date: Thu, 06 Jul 2023 00:18:14 +0000	[thread overview]
Message-ID: <168860269498.29151.2669410551132746914.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230601104525.27897-1-jack@suse.cz>

Hello:

This series was applied to jaegeuk/f2fs.git (dev)
by Christian Brauner <brauner@kernel.org>:

On Thu,  1 Jun 2023 12:58:20 +0200 you wrote:
> Hello,
> 
> this patch set fixes a problem with cross directory renames originally reported
> in [1]. To quickly sum it up some filesystems (so far we know at least about
> ext4, udf, f2fs, ocfs2, likely also reiserfs, gfs2 and others) need to lock the
> directory when it is being renamed into another directory. This is because we
> need to update the parent pointer in the directory in that case and if that
> races with other operation on the directory (in particular a conversion from
> one directory format into another), bad things can happen.
> 
> [...]

Here is the summary with links:
  - [f2fs-dev,v2,1/6] ext4: Remove ext4 locking of moved directory
    https://git.kernel.org/jaegeuk/f2fs/c/3658840cd363
  - [f2fs-dev,v2,2/6] Revert "udf: Protect rename against modification of moved directory"
    https://git.kernel.org/jaegeuk/f2fs/c/7517ce5dc4d6
  - [f2fs-dev,v2,3/6] Revert "f2fs: fix potential corruption when moving a directory"
    https://git.kernel.org/jaegeuk/f2fs/c/cde3c9d7e2a3
  - [f2fs-dev,v2,4/6] fs: Establish locking order for unrelated directories
    (no matching commit)
  - [f2fs-dev,v2,5/6] fs: Lock moved directories
    https://git.kernel.org/jaegeuk/f2fs/c/28eceeda130f
  - [f2fs-dev,v2,6/6] fs: Restrict lock_two_nondirectories() to non-directory inodes
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2023-07-06  0:18 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 10:58 [PATCH v2 0/6] fs: Fix directory corruption when moving directories Jan Kara
2023-06-01 10:58 ` [f2fs-dev] " Jan Kara
2023-06-01 10:58 ` [PATCH v2 1/6] ext4: Remove ext4 locking of moved directory Jan Kara
2023-06-01 10:58   ` [f2fs-dev] " Jan Kara
2023-06-01 14:52   ` Theodore Ts'o
2023-06-01 14:52     ` [f2fs-dev] " Theodore Ts'o
2023-06-01 15:27     ` Jan Kara
2023-06-01 15:27       ` [f2fs-dev] " Jan Kara
2023-06-01 15:58       ` Christian Brauner
2023-06-01 15:58         ` [f2fs-dev] " Christian Brauner
2023-06-01 10:58 ` [PATCH v2 2/6] Revert "udf: Protect rename against modification of moved directory" Jan Kara
2023-06-01 10:58   ` [f2fs-dev] " Jan Kara
2023-06-01 10:58 ` [PATCH v2 3/6] Revert "f2fs: fix potential corruption when moving a directory" Jan Kara
2023-06-01 10:58   ` [f2fs-dev] " Jan Kara
2023-06-01 10:58 ` [PATCH v2 4/6] fs: Establish locking order for unrelated directories Jan Kara
2023-06-01 10:58   ` [f2fs-dev] " Jan Kara
2023-06-01 13:58   ` Christian Brauner
2023-06-01 13:58     ` [f2fs-dev] " Christian Brauner
2023-06-01 15:24     ` Jan Kara
2023-06-01 15:24       ` [f2fs-dev] " Jan Kara
2023-06-01 15:37       ` David Laight
2023-06-01 15:37         ` [f2fs-dev] " David Laight
2023-06-01 16:13         ` Jan Kara
2023-06-01 16:13           ` [f2fs-dev] " Jan Kara
2023-06-01 16:21           ` Christian Brauner
2023-06-01 16:21             ` [f2fs-dev] " Christian Brauner
2023-06-01 16:33           ` David Laight
2023-06-01 16:33             ` [f2fs-dev] " David Laight
2023-06-02 12:34             ` Christian Brauner
2023-06-02 12:34               ` [f2fs-dev] " Christian Brauner
2023-06-01 15:59       ` Christian Brauner
2023-06-01 15:59         ` [f2fs-dev] " Christian Brauner
2023-06-02  1:36   ` kernel test robot
2023-06-02  1:36     ` [f2fs-dev] " kernel test robot
2023-06-01 10:58 ` [PATCH v2 5/6] fs: Lock moved directories Jan Kara
2023-06-01 10:58   ` [f2fs-dev] " Jan Kara
2023-06-01 10:58 ` [PATCH v2 6/6] fs: Restrict lock_two_nondirectories() to non-directory inodes Jan Kara
2023-06-01 10:58   ` [f2fs-dev] " Jan Kara
2023-06-02 13:05 ` [PATCH v2 0/6] fs: Fix directory corruption when moving directories Christian Brauner
2023-06-02 13:05   ` [f2fs-dev] " Christian Brauner
2023-07-06  0:18 ` patchwork-bot+f2fs [this message]
2023-07-06  0:18   ` patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168860269498.29151.2669410551132746914.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+f2fs@kernel.org \
    --cc=brauner@kernel.org \
    --cc=djwong@kernel.org \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=tytso@mit.edu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.