All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Xiang Yang <xiangyang3@huawei.com>
Cc: matthieu.baerts@tessares.net, martineau@kernel.org,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org, mptcp@lists.linux.dev
Subject: Re: [PATCH -next] mptcp: fix the incorrect judgment for msk->cb_flags
Date: Fri, 04 Aug 2023 22:40:22 +0000	[thread overview]
Message-ID: <169118882271.4114.18105742009856428701.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230803072438.1847500-1-xiangyang3@huawei.com>

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 3 Aug 2023 07:24:38 +0000 you wrote:
> Coccicheck reports the error below:
> net/mptcp/protocol.c:3330:15-28: ERROR: test of a variable/field address
> 
> Since the address of msk->cb_flags is used in __test_and_clear_bit, the
> address should not be NULL. The judgment for if (unlikely(msk->cb_flags))
> will always be true, we should check the real value of msk->cb_flags here.
> 
> [...]

Here is the summary with links:
  - [-next] mptcp: fix the incorrect judgment for msk->cb_flags
    https://git.kernel.org/netdev/net/c/17ebf8a4c38b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2023-08-04 22:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  7:24 [PATCH -next] mptcp: fix the incorrect judgment for msk->cb_flags Xiang Yang
2023-08-03  8:41 ` mptcp: fix the incorrect judgment for msk->cb_flags: Tests Results MPTCP CI
2023-08-03 16:32 ` [PATCH -next] mptcp: fix the incorrect judgment for msk->cb_flags Matthieu Baerts
2023-08-03 18:04   ` Jakub Kicinski
2023-08-03 20:18     ` Matthieu Baerts
2023-08-03 20:55       ` Jakub Kicinski
2023-08-04 22:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169118882271.4114.18105742009856428701.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=martineau@kernel.org \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xiangyang3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.