From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: Xiang Yang <xiangyang3@huawei.com>,
martineau@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org, mptcp@lists.linux.dev
Subject: Re: [PATCH -next] mptcp: fix the incorrect judgment for msk->cb_flags
Date: Thu, 3 Aug 2023 11:04:24 -0700 [thread overview]
Message-ID: <20230803110424.5ca643c9@kernel.org> (raw)
In-Reply-To: <d3fa9b41-078b-4bb5-9f5c-d8768b787f4d@tessares.net>
On Thu, 3 Aug 2023 18:32:15 +0200 Matthieu Baerts wrote:
> This Coccicheck report was useful, the optimisation in place was not
> working. But there was no impact apart from testing more conditions
> where there were no reasons to.
>
> The fix is then good to me but it should land in -net, not in net-next.
>
> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>
> I don't know if it is needed to have a re-send just to change the subject.
Looks trivial enough to apply without a repost, but are you sure
you don't want to take it into your tree? Run the selftests and all?
next prev parent reply other threads:[~2023-08-03 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 7:24 [PATCH -next] mptcp: fix the incorrect judgment for msk->cb_flags Xiang Yang
2023-08-03 8:41 ` mptcp: fix the incorrect judgment for msk->cb_flags: Tests Results MPTCP CI
2023-08-03 16:32 ` [PATCH -next] mptcp: fix the incorrect judgment for msk->cb_flags Matthieu Baerts
2023-08-03 18:04 ` Jakub Kicinski [this message]
2023-08-03 20:18 ` Matthieu Baerts
2023-08-03 20:55 ` Jakub Kicinski
2023-08-04 22:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803110424.5ca643c9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=martineau@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiangyang3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.