* [PATCH] ibmveth: Use dcbf rather than dcbfl
@ 2023-08-23 4:51 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-08-23 4:51 UTC (permalink / raw)
To: netdev; +Cc: nnac123, linuxppc-dev
When building for power4, newer binutils don't recognise the "dcbfl"
extended mnemonic.
dcbfl RA, RB is equivalent to dcbf RA, RB, 1.
Switch to "dcbf" to avoid the build error.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/net/ethernet/ibm/ibmveth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 113fcb3e353e..832a2ae01950 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -203,7 +203,7 @@ static inline void ibmveth_flush_buffer(void *addr, unsigned long length)
unsigned long offset;
for (offset = 0; offset < length; offset += SMP_CACHE_BYTES)
- asm("dcbfl %0,%1" :: "b" (addr), "r" (offset));
+ asm("dcbf %0,%1,1" :: "b" (addr), "r" (offset));
}
/* replenish the buffers for a pool. note that we don't need to
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ibmveth: Use dcbf rather than dcbfl
@ 2023-08-23 4:51 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-08-23 4:51 UTC (permalink / raw)
To: netdev; +Cc: linuxppc-dev, nnac123
When building for power4, newer binutils don't recognise the "dcbfl"
extended mnemonic.
dcbfl RA, RB is equivalent to dcbf RA, RB, 1.
Switch to "dcbf" to avoid the build error.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/net/ethernet/ibm/ibmveth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 113fcb3e353e..832a2ae01950 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -203,7 +203,7 @@ static inline void ibmveth_flush_buffer(void *addr, unsigned long length)
unsigned long offset;
for (offset = 0; offset < length; offset += SMP_CACHE_BYTES)
- asm("dcbfl %0,%1" :: "b" (addr), "r" (offset));
+ asm("dcbf %0,%1,1" :: "b" (addr), "r" (offset));
}
/* replenish the buffers for a pool. note that we don't need to
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ibmveth: Use dcbf rather than dcbfl
2023-08-23 4:51 ` Michael Ellerman
@ 2023-08-23 11:10 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-23 11:10 UTC (permalink / raw)
To: Michael Ellerman; +Cc: netdev, nnac123, linuxppc-dev
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 23 Aug 2023 14:51:39 +1000 you wrote:
> When building for power4, newer binutils don't recognise the "dcbfl"
> extended mnemonic.
>
> dcbfl RA, RB is equivalent to dcbf RA, RB, 1.
>
> Switch to "dcbf" to avoid the build error.
>
> [...]
Here is the summary with links:
- ibmveth: Use dcbf rather than dcbfl
https://git.kernel.org/netdev/net/c/bfedba3b2c77
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ibmveth: Use dcbf rather than dcbfl
@ 2023-08-23 11:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-23 11:10 UTC (permalink / raw)
To: Michael Ellerman; +Cc: netdev, linuxppc-dev, nnac123
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 23 Aug 2023 14:51:39 +1000 you wrote:
> When building for power4, newer binutils don't recognise the "dcbfl"
> extended mnemonic.
>
> dcbfl RA, RB is equivalent to dcbf RA, RB, 1.
>
> Switch to "dcbf" to avoid the build error.
>
> [...]
Here is the summary with links:
- ibmveth: Use dcbf rather than dcbfl
https://git.kernel.org/netdev/net/c/bfedba3b2c77
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-23 11:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-23 4:51 [PATCH] ibmveth: Use dcbf rather than dcbfl Michael Ellerman
2023-08-23 4:51 ` Michael Ellerman
2023-08-23 11:10 ` patchwork-bot+netdevbpf
2023-08-23 11:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.