All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: David Gstir <david@sigma-star.at>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	bridge@lists.linux-foundation.org,
	Ido Schimmel <idosch@idosch.org>,
	bernhard.thaler@wvnet.at, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH 1/1] bridge: remove BR_GROUPFWD_RESTRICTED for arbitrary forwarding of reserved addresses
Date: Tue, 02 Oct 2018 17:56:41 +0200	[thread overview]
Message-ID: <1694684.hdcNQnb4e4@blindfold> (raw)
In-Reply-To: <09307ccf-02d6-ce63-7030-fcc560e93f23@cumulusnetworks.com>

Nikolay,

Am Dienstag, 2. Oktober 2018, 16:59:31 CEST schrieb Nikolay Aleksandrov:
> Richard please check commit:
> commit 5af48b59f35c
> Author: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Date:   Wed Sep 27 16:12:44 2017 +0300
> 
>     net: bridge: add per-port group_fwd_mask with less restrictions
>     
>     We need to be able to transparently forward most link-local frames via
>     tunnels (e.g. vxlan, qinq). Currently the bridge's group_fwd_mask has a
>     mask which restricts the forwarding of STP and LACP, but we need to be able
>     to forward these over tunnels and control that forwarding on a per-port
>     basis thus add a new per-port group_fwd_mask option which only disallows
>     mac pause frames to be forwarded (they're always dropped anyway).
>     The patch does not change the current default situation - all of the others
>     are still restricted unless configured for forwarding.
>     We have successfully tested this patch with LACP and STP forwarding over
>     VxLAN and qinq tunnels.
>     
>     Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> 
> Will this work for you ?
> It's in the bridge since v4.15.

Hmm, I *think* this is exactly what I need.
To understand it correctly, I have to set per port group_fwd_mask for both slaves
of the bridge then it will forward anything (except for PAUSE frames)?

Is there a reason why this knob is not documented in Documentation/ABI/testing/sysfs-class-net?

Thanks,
//richard




WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: Ido Schimmel <idosch@idosch.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	bernhard.thaler@wvnet.at, "David S. Miller" <davem@davemloft.net>,
	bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
	David Gstir <david@sigma-star.at>,
	roopa@cumulusnetworks.com
Subject: Re: [PATCH 1/1] bridge: remove BR_GROUPFWD_RESTRICTED for arbitrary forwarding of reserved addresses
Date: Tue, 02 Oct 2018 17:56:41 +0200	[thread overview]
Message-ID: <1694684.hdcNQnb4e4@blindfold> (raw)
In-Reply-To: <09307ccf-02d6-ce63-7030-fcc560e93f23@cumulusnetworks.com>

Nikolay,

Am Dienstag, 2. Oktober 2018, 16:59:31 CEST schrieb Nikolay Aleksandrov:
> Richard please check commit:
> commit 5af48b59f35c
> Author: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Date:   Wed Sep 27 16:12:44 2017 +0300
> 
>     net: bridge: add per-port group_fwd_mask with less restrictions
>     
>     We need to be able to transparently forward most link-local frames via
>     tunnels (e.g. vxlan, qinq). Currently the bridge's group_fwd_mask has a
>     mask which restricts the forwarding of STP and LACP, but we need to be able
>     to forward these over tunnels and control that forwarding on a per-port
>     basis thus add a new per-port group_fwd_mask option which only disallows
>     mac pause frames to be forwarded (they're always dropped anyway).
>     The patch does not change the current default situation - all of the others
>     are still restricted unless configured for forwarding.
>     We have successfully tested this patch with LACP and STP forwarding over
>     VxLAN and qinq tunnels.
>     
>     Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> 
> Will this work for you ?
> It's in the bridge since v4.15.

Hmm, I *think* this is exactly what I need.
To understand it correctly, I have to set per port group_fwd_mask for both slaves
of the bridge then it will forward anything (except for PAUSE frames)?

Is there a reason why this knob is not documented in Documentation/ABI/testing/sysfs-class-net?

Thanks,
//richard

  reply	other threads:[~2018-10-02 15:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06  0:56 [Bridge] [PATCH 1/1] bridge: remove BR_GROUPFWD_RESTRICTED for arbitrary forwarding of reserved addresses Bernhard Thaler
2015-01-06  0:56 ` Bernhard Thaler
2015-01-06  6:10 ` [Bridge] " Stephen Hemminger
2015-01-06  6:10   ` Stephen Hemminger
2018-10-01 14:28   ` Richard Weinberger
2018-10-01 16:24     ` Florian Fainelli
2018-10-01 18:16       ` [Bridge] " Richard Weinberger
2018-10-01 18:16         ` Richard Weinberger
2018-10-01 18:25         ` [Bridge] " Ido Schimmel
2018-10-01 18:25           ` Ido Schimmel
2018-10-01 18:32           ` [Bridge] " Richard Weinberger
2018-10-01 18:32             ` Richard Weinberger
2018-10-01 18:48             ` [Bridge] " Ido Schimmel
2018-10-01 18:48               ` Ido Schimmel
2018-10-01 18:54               ` [Bridge] " Richard Weinberger
2018-10-01 18:54                 ` Richard Weinberger
2018-10-01 19:04                 ` [Bridge] " Ido Schimmel
2018-10-01 19:04                   ` Ido Schimmel
2018-10-01 19:10                   ` [Bridge] " Richard Weinberger
2018-10-01 19:10                     ` Richard Weinberger
2018-10-02 14:59                     ` [Bridge] " Nikolay Aleksandrov
2018-10-02 14:59                       ` Nikolay Aleksandrov
2018-10-02 15:56                       ` Richard Weinberger [this message]
2018-10-02 15:56                         ` Richard Weinberger
2018-10-02 16:10                         ` [Bridge] " Nikolay Aleksandrov
2018-10-02 16:10                           ` Nikolay Aleksandrov
2018-10-02 19:30                           ` [Bridge] " Richard Weinberger
2018-10-02 19:30                             ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1694684.hdcNQnb4e4@blindfold \
    --to=richard@nod.at \
    --cc=bernhard.thaler@wvnet.at \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=david@sigma-star.at \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@idosch.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.