All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xuyang Dong" <dongxuyang@eswincomputing.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>
Cc: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, ben-linux@fluff.org,
	ben.dooks@codethink.co.uk, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	p.zabel@pengutronix.de, daniel.lezcano@kernel.org,
	tglx@kernel.org, ningyu@eswincomputing.com,
	linmin@eswincomputing.com, xuxiang@eswincomputing.com,
	wangguosheng@eswincomputing.com, pinkesh.vaghela@einfochips.com
Subject: Re: Re: [PATCH v13 2/5] dt-bindings: pwm: dwc: Add eswin compatible
Date: Mon, 27 Jul 2026 17:26:08 +0800 (GMT+08:00)	[thread overview]
Message-ID: <1695d1d8.8bce.19fa2e55d06.Coremail.dongxuyang@eswincomputing.com> (raw)
In-Reply-To: <20260725-lurking-emotional-tarsier-ff05dc@quoll>

> >    reg:
> >      maxItems: 1
> > @@ -44,11 +43,13 @@ properties:
> >        - const: timer
> > 
> >    resets:
> > +    minItems: 1
> >      items:
> >        - description: Interface bus (presetn) reset
> >        - description: PWM timer logic (timer_N_resetn) reset
> > 
> >    reset-names:
> > +    minItems: 1
> 
> Drop minItems in such case - resets with one item won't be allowed to be
> used with reset-names
> 

Hi Krzysztof,

We will drop minItems of reset-names in the next version.

> >      items:
> >        - const: bus
> >        - const: timer
> > @@ -64,6 +65,23 @@ required:
> >    - clocks
> >    - clock-names
> > 
> > +allOf:
> > +  - $ref: pwm.yaml#
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: eswin,eic7700-pwm
> > +    then:
> > +      properties:
> > +        resets:
> > +          items:
> > +            - description: Combined APB interface and timer logic reset
> > +        reset-names: false
> > +      required:
> > +        - resets
> 
> else:
>   properties:
>     resets:
>       minItems: 2
>     reset-names:
>       minItems: 2
> 

Add the else in the next version.

Best regards,
Xuyang Dong

> > +
> >  additionalProperties: false
> > 
> >  examples:
> > @@ -75,3 +93,12 @@ examples:
> 

  reply	other threads:[~2026-07-27  9:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  8:41 [PATCH v13 0/5] Update designware pwm driver dongxuyang
2026-07-24  8:43 ` [PATCH v13 1/5] dt-bindings: pwm: dwc: Document optional resets property dongxuyang
2026-07-24  8:53   ` sashiko-bot
2026-07-27  9:25     ` Xuyang Dong
2026-07-25 15:05   ` Krzysztof Kozlowski
2026-07-24  8:43 ` [PATCH v13 2/5] dt-bindings: pwm: dwc: Add eswin compatible dongxuyang
2026-07-24  8:56   ` sashiko-bot
2026-07-27  9:25     ` Xuyang Dong
2026-07-25 15:06   ` Krzysztof Kozlowski
2026-07-27  9:26     ` Xuyang Dong [this message]
2026-07-24  8:43 ` [PATCH v13 3/5] pwm: dwc: add of/platform support dongxuyang
2026-07-24  8:57   ` sashiko-bot
2026-07-27  9:25     ` Xuyang Dong
2026-07-24  8:44 ` [PATCH v13 4/5] dt-bindings: timer: dwc: Update resets property items dongxuyang
2026-07-24  8:55   ` sashiko-bot
2026-07-24 13:55     ` Rob Herring
2026-07-24  8:44 ` [PATCH v13 5/5] clocksource: dw_apb_timer: Use reset array API to handle all resets dongxuyang
2026-07-24  8:55   ` sashiko-bot
2026-07-27  9:26     ` Xuyang Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1695d1d8.8bce.19fa2e55d06.Coremail.dongxuyang@eswincomputing.com \
    --to=dongxuyang@eswincomputing.com \
    --cc=ben-linux@fluff.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linmin@eswincomputing.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=ningyu@eswincomputing.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pinkesh.vaghela@einfochips.com \
    --cc=robh@kernel.org \
    --cc=tglx@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=wangguosheng@eswincomputing.com \
    --cc=xuxiang@eswincomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.