* [PATCH BlueZ v2 0/1] btio: Allow binding a bcast listener before accept @ 2023-10-24 11:04 Iulia Tanasescu 2023-10-24 11:04 ` [PATCH BlueZ v2 1/1] " Iulia Tanasescu 2023-10-24 18:50 ` [PATCH BlueZ v2 0/1] " patchwork-bot+bluetooth 0 siblings, 2 replies; 5+ messages in thread From: Iulia Tanasescu @ 2023-10-24 11:04 UTC (permalink / raw) To: linux-bluetooth Cc: claudia.rosu, mihai-octavian.urzica, silviu.barbulescu, vlad.pruteanu, andrei.istodorescu, luiz.dentz, Iulia Tanasescu This patch adds btio support for binding a PA sync io to a number of BISes, before proceeding with BIG Create Sync. This depends on the kernel update introduced by [PATCH v3 0/1] Bluetooth: ISO: Allow binding a PA sync socket. This patch version fixes scan-build warning. Iulia Tanasescu (1): btio: Allow binding a bcast listener before accept btio/btio.c | 55 +++++++++++++++++++++++++++++++++++++++++++- btio/btio.h | 2 +- profiles/audio/bap.c | 2 +- src/shared/bass.c | 9 ++++---- 4 files changed, 61 insertions(+), 7 deletions(-) base-commit: 0c757e8eeef69ff2b1eefa59e590f171c9fe1c88 -- 2.39.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH BlueZ v2 1/1] btio: Allow binding a bcast listener before accept 2023-10-24 11:04 [PATCH BlueZ v2 0/1] btio: Allow binding a bcast listener before accept Iulia Tanasescu @ 2023-10-24 11:04 ` Iulia Tanasescu 2023-10-24 12:09 ` bluez.test.bot 2023-10-24 18:50 ` [PATCH BlueZ v2 0/1] " patchwork-bot+bluetooth 1 sibling, 1 reply; 5+ messages in thread From: Iulia Tanasescu @ 2023-10-24 11:04 UTC (permalink / raw) To: linux-bluetooth Cc: claudia.rosu, mihai-octavian.urzica, silviu.barbulescu, vlad.pruteanu, andrei.istodorescu, luiz.dentz, Iulia Tanasescu This adds btio support for binding a PA sync io to a number of BISes, before proceeding with BIG Create Sync. --- btio/btio.c | 55 +++++++++++++++++++++++++++++++++++++++++++- btio/btio.h | 2 +- profiles/audio/bap.c | 2 +- src/shared/bass.c | 9 ++++---- 4 files changed, 61 insertions(+), 7 deletions(-) diff --git a/btio/btio.c b/btio/btio.c index d45b8240d..d30cfcac7 100644 --- a/btio/btio.c +++ b/btio/btio.c @@ -1796,14 +1796,67 @@ gboolean bt_io_accept(GIOChannel *io, BtIOConnect connect, gpointer user_data, gboolean bt_io_bcast_accept(GIOChannel *io, BtIOConnect connect, gpointer user_data, GDestroyNotify destroy, - GError * *err) + GError * *err, BtIOOption opt1, ...) { int sock; char c; struct pollfd pfd; + va_list args; + struct sockaddr_iso *addr = NULL; + uint8_t bc_num_bis = 0; + uint8_t bc_bis[ISO_MAX_NUM_BIS] = {0}; + BtIOOption opt = opt1; + + va_start(args, opt1); + + while (opt != BT_IO_OPT_INVALID) { + if (opt == BT_IO_OPT_ISO_BC_NUM_BIS) { + bc_num_bis = va_arg(args, int); + } else if (opt == BT_IO_OPT_ISO_BC_BIS) { + memcpy(bc_bis, va_arg(args, uint8_t *), + bc_num_bis); + } else { + g_set_error(err, BT_IO_ERROR, EINVAL, + "Invalid option %d", opt); + break; + } + + opt = va_arg(args, int); + } + + va_end(args); + + if (*err) + return FALSE; sock = g_io_channel_unix_get_fd(io); + if (bc_num_bis) { + addr = malloc(sizeof(*addr) + sizeof(*addr->iso_bc)); + + if (!addr) { + ERROR_FAILED(err, "poll", ENOMEM); + return FALSE; + } + + memset(addr, 0, sizeof(*addr) + sizeof(*addr->iso_bc)); + addr->iso_family = AF_BLUETOOTH; + + addr->iso_bc->bc_num_bis = bc_num_bis; + memcpy(addr->iso_bc->bc_bis, bc_bis, + addr->iso_bc->bc_num_bis); + + if (bind(sock, (struct sockaddr *)addr, + sizeof(*addr) + sizeof(*addr->iso_bc)) < 0) { + ERROR_FAILED(err, "bind", errno); + } + + free(addr); + + if (*err) + return FALSE; + } + memset(&pfd, 0, sizeof(pfd)); pfd.fd = sock; pfd.events = POLLOUT; diff --git a/btio/btio.h b/btio/btio.h index 3169bebf3..3e69092b1 100644 --- a/btio/btio.h +++ b/btio/btio.h @@ -77,7 +77,7 @@ gboolean bt_io_accept(GIOChannel *io, BtIOConnect connect, gpointer user_data, gboolean bt_io_bcast_accept(GIOChannel *io, BtIOConnect connect, gpointer user_data, GDestroyNotify destroy, - GError **err); + GError **err, BtIOOption opt1, ...); gboolean bt_io_set(GIOChannel *io, GError **err, BtIOOption opt1, ...); diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c index fa5cf1f54..b74498c4c 100644 --- a/profiles/audio/bap.c +++ b/profiles/audio/bap.c @@ -981,7 +981,7 @@ static void iso_pa_sync_confirm_cb(GIOChannel *io, void *user_data) GError *err = NULL; if (!bt_io_bcast_accept(io, iso_bcast_confirm_cb, - user_data, NULL, &err)) { + user_data, NULL, &err, BT_IO_OPT_INVALID)) { error("bt_io_bcast_accept: %s", err->message); g_error_free(err); g_io_channel_shutdown(io, TRUE, NULL); diff --git a/src/shared/bass.c b/src/shared/bass.c index 0ee3187d1..ce8b239f3 100644 --- a/src/shared/bass.c +++ b/src/shared/bass.c @@ -743,8 +743,9 @@ static void confirm_cb(GIOChannel *io, gpointer user_data) if (bass_trigger_big_sync(bcast_src)) { if (!bt_io_bcast_accept(bcast_src->pa_sync_io, - connect_cb, bcast_src, NULL, &gerr)) { - DBG(bcast_src->bass, "bt_io_accept: %s", + connect_cb, bcast_src, NULL, &gerr, + BT_IO_OPT_INVALID)) { + DBG(bcast_src->bass, "bt_io_bcast_accept: %s", gerr->message); g_error_free(gerr); } @@ -1129,8 +1130,8 @@ static void bass_handle_set_bcast_code_op(struct bt_bass *bass, } if (!bt_io_bcast_accept(bcast_src->pa_sync_io, connect_cb, - bcast_src, NULL, &gerr)) { - DBG(bcast_src->bass, "bt_io_accept: %s", gerr->message); + bcast_src, NULL, &gerr, BT_IO_OPT_INVALID)) { + DBG(bcast_src->bass, "bt_io_bcast_accept: %s", gerr->message); g_error_free(gerr); } } -- 2.39.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: btio: Allow binding a bcast listener before accept 2023-10-24 11:04 ` [PATCH BlueZ v2 1/1] " Iulia Tanasescu @ 2023-10-24 12:09 ` bluez.test.bot 0 siblings, 0 replies; 5+ messages in thread From: bluez.test.bot @ 2023-10-24 12:09 UTC (permalink / raw) To: linux-bluetooth, iulia.tanasescu [-- Attachment #1: Type: text/plain, Size: 947 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=795983 ---Test result--- Test Summary: CheckPatch PASS 0.52 seconds GitLint PASS 0.28 seconds BuildEll PASS 27.76 seconds BluezMake PASS 789.97 seconds MakeCheck PASS 11.45 seconds MakeDistcheck PASS 172.73 seconds CheckValgrind PASS 265.21 seconds CheckSmatch PASS 357.15 seconds bluezmakeextell PASS 114.79 seconds IncrementalBuild PASS 683.68 seconds ScanBuild PASS 1039.55 seconds --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH BlueZ v2 0/1] btio: Allow binding a bcast listener before accept 2023-10-24 11:04 [PATCH BlueZ v2 0/1] btio: Allow binding a bcast listener before accept Iulia Tanasescu 2023-10-24 11:04 ` [PATCH BlueZ v2 1/1] " Iulia Tanasescu @ 2023-10-24 18:50 ` patchwork-bot+bluetooth 1 sibling, 0 replies; 5+ messages in thread From: patchwork-bot+bluetooth @ 2023-10-24 18:50 UTC (permalink / raw) To: Iulia Tanasescu Cc: linux-bluetooth, claudia.rosu, mihai-octavian.urzica, silviu.barbulescu, vlad.pruteanu, andrei.istodorescu, luiz.dentz Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 24 Oct 2023 14:04:29 +0300 you wrote: > This patch adds btio support for binding a PA sync io to a number of > BISes, before proceeding with BIG Create Sync. > > This depends on the kernel update introduced by > [PATCH v3 0/1] Bluetooth: ISO: Allow binding a PA sync socket. > > This patch version fixes scan-build warning. > > [...] Here is the summary with links: - [BlueZ,v2,1/1] btio: Allow binding a bcast listener before accept https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=00fdb61d5616 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH BlueZ v2 0/1] btio: Allow binding a bcast listener before accept @ 2023-10-19 14:52 Iulia Tanasescu 0 siblings, 0 replies; 5+ messages in thread From: Iulia Tanasescu @ 2023-10-19 14:52 UTC (permalink / raw) To: linux-bluetooth Cc: claudia.rosu, mihai-octavian.urzica, silviu.barbulescu, vlad.pruteanu, andrei.istodorescu, luiz.dentz, Iulia Tanasescu This patch adds btio support for binding a PA sync io to a number of BISes, before proceeding with BIG Create Sync. This depends on the kernel update introduced by [PATCH v3 0/1] Bluetooth: ISO: Allow binding a PA sync socket. This patch version fixes scan-build warning. Iulia Tanasescu (1): btio: Allow binding a bcast listener before accept btio/btio.c | 55 +++++++++++++++++++++++++++++++++++++++++++- btio/btio.h | 2 +- profiles/audio/bap.c | 2 +- src/shared/bass.c | 9 ++++---- 4 files changed, 61 insertions(+), 7 deletions(-) base-commit: 0c757e8eeef69ff2b1eefa59e590f171c9fe1c88 -- 2.39.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-24 18:50 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-24 11:04 [PATCH BlueZ v2 0/1] btio: Allow binding a bcast listener before accept Iulia Tanasescu 2023-10-24 11:04 ` [PATCH BlueZ v2 1/1] " Iulia Tanasescu 2023-10-24 12:09 ` bluez.test.bot 2023-10-24 18:50 ` [PATCH BlueZ v2 0/1] " patchwork-bot+bluetooth -- strict thread matches above, loose matches on Subject: below -- 2023-10-19 14:52 Iulia Tanasescu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.