* [PATCH v2] i915: Add option to bypass vbt table.
@ 2012-03-01 5:44 Mathias.Froehlich
2012-03-01 19:38 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Mathias.Froehlich @ 2012-03-01 5:44 UTC (permalink / raw)
To: Paul Menzel; +Cc: Mathias Fröhlich, dri-devel
From: Mathias Fröhlich <Mathias.Froehlich@web.de>
Add an option to skip reading the mode entries from
the vbt bios tables.
This change enables the use of displays where the vbt table just
contains inappropriate values, but either the vesa defaults or
the video=... modes do something sensible with the attached display.
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Signed-off-by: Mathias Froehlich <Mathias.Froehlich@web.de>
---
drivers/gpu/drm/i915/i915_drv.c | 4 ++--
drivers/gpu/drm/i915/intel_bios.c | 5 +++++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 308f819..0975895 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -89,8 +89,8 @@ MODULE_PARM_DESC(lvds_use_ssc,
int i915_vbt_sdvo_panel_type __read_mostly = -1;
module_param_named(vbt_sdvo_panel_type, i915_vbt_sdvo_panel_type, int, 0600);
MODULE_PARM_DESC(vbt_sdvo_panel_type,
- "Override selection of SDVO panel mode in the VBT "
- "(default: auto)");
+ "Override/Ignore selection of SDVO panel mode in the VBT "
+ "(-2=ignore, -1=auto [default], index in VBT BIOS table)");
static bool i915_try_reset __read_mostly = true;
module_param_named(reset, i915_try_reset, bool, 0600);
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 63880e2..7670b09 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -255,6 +255,11 @@ parse_sdvo_panel_data(struct drm_i915_private *dev_priv,
int index;
index = i915_vbt_sdvo_panel_type;
+ if (index == -2) {
+ DRM_DEBUG_KMS("Ignore SDVO panel mode from BIOS VBT tables.\n");
+ return;
+ }
+
if (index == -1) {
struct bdb_sdvo_lvds_options *sdvo_lvds_options;
--
1.7.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] i915: Add option to bypass vbt table.
2012-03-01 5:44 [PATCH v2] i915: Add option to bypass vbt table Mathias.Froehlich
@ 2012-03-01 19:38 ` Daniel Vetter
2012-03-01 21:41 ` Paul Menzel
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2012-03-01 19:38 UTC (permalink / raw)
To: Mathias.Froehlich; +Cc: dri-devel, Paul Menzel, Mathias Fröhlich
On Thu, Mar 01, 2012 at 06:44:35AM +0100, Mathias.Froehlich@gmx.net wrote:
> From: Mathias Fröhlich <Mathias.Froehlich@web.de>
>
> Add an option to skip reading the mode entries from
> the vbt bios tables.
> This change enables the use of displays where the vbt table just
> contains inappropriate values, but either the vesa defaults or
> the video=... modes do something sensible with the attached display.
>
> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
> Signed-off-by: Mathias Froehlich <Mathias.Froehlich@web.de>
Can you elaborate a bit on why this is required? Is this for a machine
(like the chrome machines) that just lack a vbios? Or do we fail to parse
the vbt in some way?
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i915: Add option to bypass vbt table.
2012-03-01 19:38 ` Daniel Vetter
@ 2012-03-01 21:41 ` Paul Menzel
2012-03-01 22:23 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Paul Menzel @ 2012-03-01 21:41 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Mathias, Fröhlich, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1384 bytes --]
Am Donnerstag, den 01.03.2012, 20:38 +0100 schrieb Daniel Vetter:
> On Thu, Mar 01, 2012 at 06:44:35AM +0100, Mathias.Froehlich@gmx.net wrote:
> > From: Mathias Fröhlich <Mathias.Froehlich@web.de>
> >
> > Add an option to skip reading the mode entries from
> > the vbt bios tables.
> > This change enables the use of displays where the vbt table just
> > contains inappropriate values, but either the vesa defaults or
> > the video=... modes do something sensible with the attached display.
> >
> > Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
> > Signed-off-by: Mathias Froehlich <Mathias.Froehlich@web.de>
>
> Can you elaborate a bit on why this is required? Is this for a machine
> (like the chrome machines) that just lack a vbios? Or do we fail to parse
> the vbt in some way?
Pasted from Mathias’ message with the first patch iteration.
Am Mittwoch, den 29.02.2012, 20:34 +0100 schrieb Mathias Fröhlich:
> Attached is a small change to i915 that fixes a customer case that I had in my
> day job.
>
> The problem happens with an embedded board that contains vbt bios tables that
> do not match the attached display.
> Using this change and the appropriate kernel boot command line they are able to
> use an otherwise completely unusable secondary display on that embedded board.
>
> Please review.
Thanks,
Paul
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i915: Add option to bypass vbt table.
2012-03-01 21:41 ` Paul Menzel
@ 2012-03-01 22:23 ` Daniel Vetter
2012-03-02 6:51 ` Mathias Fröhlich
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2012-03-01 22:23 UTC (permalink / raw)
To: Paul Menzel; +Cc: Mathias Fröhlich, dri-devel
On Thu, Mar 01, 2012 at 10:41:32PM +0100, Paul Menzel wrote:
> Am Donnerstag, den 01.03.2012, 20:38 +0100 schrieb Daniel Vetter:
> > On Thu, Mar 01, 2012 at 06:44:35AM +0100, Mathias.Froehlich@gmx.net wrote:
> > > From: Mathias Fröhlich <Mathias.Froehlich@web.de>
> > >
> > > Add an option to skip reading the mode entries from
> > > the vbt bios tables.
> > > This change enables the use of displays where the vbt table just
> > > contains inappropriate values, but either the vesa defaults or
> > > the video=... modes do something sensible with the attached display.
> > >
> > > Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
> > > Signed-off-by: Mathias Froehlich <Mathias.Froehlich@web.de>
> >
> > Can you elaborate a bit on why this is required? Is this for a machine
> > (like the chrome machines) that just lack a vbios? Or do we fail to parse
> > the vbt in some way?
>
> Pasted from Mathias’ message with the first patch iteration.
Ah, that explains things. I've added this to the commit message and queued
it for -next, thanks.
-Daniel
>
> Am Mittwoch, den 29.02.2012, 20:34 +0100 schrieb Mathias Fröhlich:
> > Attached is a small change to i915 that fixes a customer case that I had in my
> > day job.
> >
> > The problem happens with an embedded board that contains vbt bios tables that
> > do not match the attached display.
> > Using this change and the appropriate kernel boot command line they are able to
> > use an otherwise completely unusable secondary display on that embedded board.
> >
> > Please review.
>
>
> Thanks,
>
> Paul
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-02 6:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-01 5:44 [PATCH v2] i915: Add option to bypass vbt table Mathias.Froehlich
2012-03-01 19:38 ` Daniel Vetter
2012-03-01 21:41 ` Paul Menzel
2012-03-01 22:23 ` Daniel Vetter
2012-03-02 6:51 ` Mathias Fröhlich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.