* [PATCH net] tools: ynl: fix header path for nfsd
@ 2023-11-23 3:06 Jakub Kicinski
2023-11-23 16:12 ` Chuck Lever
2023-11-23 17:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-11-23 3:06 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, pabeni, Jakub Kicinski, chuck.lever
The makefile dependency is trying to include the wrong header:
<command-line>: fatal error: ../../../../include/uapi//linux/nfsd.h: No such file or directory
The guard also looks wrong.
Fixes: f14122b2c2ac ("tools: ynl: Add source files for nfsd netlink protocol")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: chuck.lever@oracle.com
---
tools/net/ynl/Makefile.deps | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
index 64d139400db1..3110f84dd029 100644
--- a/tools/net/ynl/Makefile.deps
+++ b/tools/net/ynl/Makefile.deps
@@ -18,4 +18,4 @@ CFLAGS_devlink:=$(call get_hdr_inc,_LINUX_DEVLINK_H_,devlink.h)
CFLAGS_ethtool:=$(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_H_,ethtool_netlink.h)
CFLAGS_handshake:=$(call get_hdr_inc,_LINUX_HANDSHAKE_H,handshake.h)
CFLAGS_netdev:=$(call get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
-CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_H,nfsd.h)
+CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] tools: ynl: fix header path for nfsd
2023-11-23 3:06 [PATCH net] tools: ynl: fix header path for nfsd Jakub Kicinski
@ 2023-11-23 16:12 ` Chuck Lever
2023-11-23 17:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Chuck Lever @ 2023-11-23 16:12 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni
On Wed, Nov 22, 2023 at 07:06:24PM -0800, Jakub Kicinski wrote:
> The makefile dependency is trying to include the wrong header:
>
> <command-line>: fatal error: ../../../../include/uapi//linux/nfsd.h: No such file or directory
>
> The guard also looks wrong.
>
> Fixes: f14122b2c2ac ("tools: ynl: Add source files for nfsd netlink protocol")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: chuck.lever@oracle.com
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
With apologies.
> ---
> tools/net/ynl/Makefile.deps | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
> index 64d139400db1..3110f84dd029 100644
> --- a/tools/net/ynl/Makefile.deps
> +++ b/tools/net/ynl/Makefile.deps
> @@ -18,4 +18,4 @@ CFLAGS_devlink:=$(call get_hdr_inc,_LINUX_DEVLINK_H_,devlink.h)
> CFLAGS_ethtool:=$(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_H_,ethtool_netlink.h)
> CFLAGS_handshake:=$(call get_hdr_inc,_LINUX_HANDSHAKE_H,handshake.h)
> CFLAGS_netdev:=$(call get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
> -CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_H,nfsd.h)
> +CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
> --
> 2.42.0
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] tools: ynl: fix header path for nfsd
2023-11-23 3:06 [PATCH net] tools: ynl: fix header path for nfsd Jakub Kicinski
2023-11-23 16:12 ` Chuck Lever
@ 2023-11-23 17:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-23 17:00 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, chuck.lever
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 22 Nov 2023 19:06:24 -0800 you wrote:
> The makefile dependency is trying to include the wrong header:
>
> <command-line>: fatal error: ../../../../include/uapi//linux/nfsd.h: No such file or directory
>
> The guard also looks wrong.
>
> Fixes: f14122b2c2ac ("tools: ynl: Add source files for nfsd netlink protocol")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net] tools: ynl: fix header path for nfsd
https://git.kernel.org/netdev/net/c/2be35a619482
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-23 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 3:06 [PATCH net] tools: ynl: fix header path for nfsd Jakub Kicinski
2023-11-23 16:12 ` Chuck Lever
2023-11-23 17:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.