All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next,v3] ipvlan: implement .parse_protocol hook function in ipvlan_header_ops
@ 2023-12-02 13:04 Zhengchao Shao
  2023-12-05 14:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Zhengchao Shao @ 2023-12-02 13:04 UTC (permalink / raw)
  To: netdev, davem, edumazet, kuba, pabeni
  Cc: willemb, luwei32, shaozhengchao, willemdebruijn.kernel,
	weiyongjun1, yuehaibing

The .parse_protocol hook function in the ipvlan_header_ops structure is
not implemented. As a result, when the AF_PACKET family is used to send
packets, skb->protocol will be set to 0.
Ipvlan is a device of type ARPHRD_ETHER (ether_setup). Therefore, use
eth_header_parse_protocol function to obtain the protocol.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
---
v3: remove Fixes tag, it fixes nothing
v2: modify commit info and add Fixes tag
---
 drivers/net/ipvlan/ipvlan_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 57c79f5f2991..f28fd7b6b708 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -387,6 +387,7 @@ static const struct header_ops ipvlan_header_ops = {
 	.parse		= eth_header_parse,
 	.cache		= eth_header_cache,
 	.cache_update	= eth_header_cache_update,
+	.parse_protocol	= eth_header_parse_protocol,
 };
 
 static void ipvlan_adjust_mtu(struct ipvl_dev *ipvlan, struct net_device *dev)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next,v3] ipvlan: implement .parse_protocol hook function in ipvlan_header_ops
  2023-12-02 13:04 [PATCH net-next,v3] ipvlan: implement .parse_protocol hook function in ipvlan_header_ops Zhengchao Shao
@ 2023-12-05 14:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-12-05 14:40 UTC (permalink / raw)
  To: Zhengchao Shao
  Cc: netdev, davem, edumazet, kuba, pabeni, willemb, luwei32,
	willemdebruijn.kernel, weiyongjun1, yuehaibing

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Sat, 2 Dec 2023 21:04:38 +0800 you wrote:
> The .parse_protocol hook function in the ipvlan_header_ops structure is
> not implemented. As a result, when the AF_PACKET family is used to send
> packets, skb->protocol will be set to 0.
> Ipvlan is a device of type ARPHRD_ETHER (ether_setup). Therefore, use
> eth_header_parse_protocol function to obtain the protocol.
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v3] ipvlan: implement .parse_protocol hook function in ipvlan_header_ops
    https://git.kernel.org/netdev/net-next/c/fb70136ded2e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-05 14:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-02 13:04 [PATCH net-next,v3] ipvlan: implement .parse_protocol hook function in ipvlan_header_ops Zhengchao Shao
2023-12-05 14:40 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.