[PATCH BlueZ v1] shared/vcp: Fix notification endianness

[PATCH BlueZ v1] shared/vcp: Fix notification endianness

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

4db4d5fa1c4f ("shared/vcp: Fix endianness errors") does attempt to fix
the endianness of stored volume offset but in the process it broke the
notification since the value is no longer stored in the Bluetooth byte
order (Little Endian) but instead in the cpu byte order which is then
used in the notification as is, to fix this instead of notifying using
the stored value it now uses a dedicated variable which does use the
value from the request itself.
---
 src/shared/vcp.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/shared/vcp.c b/src/shared/vcp.c
index 5d163266b480..e3451fa2a095 100644
--- a/src/shared/vcp.c
+++ b/src/shared/vcp.c
@@ -683,7 +683,7 @@ static uint8_t vocs_set_vol_offset(struct bt_vocs *vocs, struct bt_vcp *vcp,
 				struct iovec *iov)
 {
 	struct bt_vcp_db *vdb;
-	struct vol_offset_state *vstate;
+	struct vol_offset_state *vstate, state;
 	struct bt_vocs_set_vol_off *req;
 
 	DBG(vcp, "Set Volume Offset");
@@ -720,9 +720,13 @@ static uint8_t vocs_set_vol_offset(struct bt_vocs *vocs, struct bt_vcp *vcp,
 	/* Increment Change Counter */
 	vstate->counter = -~vstate->counter;
 
-	gatt_db_attribute_notify(vdb->vocs->vos, (void *)vstate,
-				 sizeof(struct vol_offset_state),
+	/* Notify change */
+	state.vol_offset = req->set_vol_offset;
+	state.counter = vstate->counter;
+
+	gatt_db_attribute_notify(vdb->vocs->vos, (void *)&state, sizeof(state),
 				 bt_vcp_get_att(vcp));
+
 	return 0;
 }
 
-- 
2.43.0

RE: [BlueZ,v1] shared/vcp: Fix notification endianness

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=808878

---Test result---

Test Summary:
CheckPatch                    PASS      0.47 seconds
GitLint                       PASS      0.33 seconds
BuildEll                      PASS      23.84 seconds
BluezMake                     PASS      696.67 seconds
MakeCheck                     PASS      11.47 seconds
MakeDistcheck                 PASS      153.50 seconds
CheckValgrind                 PASS      215.13 seconds
CheckSmatch                   PASS      318.62 seconds
bluezmakeextell               PASS      100.52 seconds
IncrementalBuild              PASS      641.15 seconds
ScanBuild                     PASS      907.11 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] shared/vcp: Fix notification endianness

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 11 Dec 2023 12:11:35 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> 4db4d5fa1c4f ("shared/vcp: Fix endianness errors") does attempt to fix
> the endianness of stored volume offset but in the process it broke the
> notification since the value is no longer stored in the Bluetooth byte
> order (Little Endian) but instead in the cpu byte order which is then
> used in the notification as is, to fix this instead of notifying using
> the stored value it now uses a dedicated variable which does use the
> value from the request itself.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] shared/vcp: Fix notification endianness
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=95838efc07d3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html