From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Zero out fallocated blocks in fallocate_chunk
Date: Thu, 29 Mar 2018 10:12:42 -0400 (EDT) [thread overview]
Message-ID: <1702795937.14837153.1522332762084.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180328180106.31007-1-agruenba@redhat.com>
----- Original Message -----
| Instead of zeroing out fallocated blocks in gfs2_iomap_alloc, zero them
| out in fallocate_chunk, much higher up the call stack. This gets rid of
| gfs2's abuse of the IOMAP_ZERO flag as well as the gfs2 specific zeronew
| buffer flag. I can't think of a reason why zeroing out the blocks in
| gfs2_iomap_alloc would have any benefits: there is no additional locking
| at that level that would add protection to the newly allocated blocks.
|
| While at it, change fallocate over from gs2_block_map to gfs2_iomap_begin.
|
| Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
| ---
Hi,
Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=fffb64127adc3eea6a19ceefdc88d171f68b9d34
Regards,
Bob Peterson
Red Hat File Systems
WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] gfs2: Zero out fallocated blocks in fallocate_chunk
Date: Thu, 29 Mar 2018 10:12:42 -0400 (EDT) [thread overview]
Message-ID: <1702795937.14837153.1522332762084.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180328180106.31007-1-agruenba@redhat.com>
----- Original Message -----
| Instead of zeroing out fallocated blocks in gfs2_iomap_alloc, zero them
| out in fallocate_chunk, much higher up the call stack. This gets rid of
| gfs2's abuse of the IOMAP_ZERO flag as well as the gfs2 specific zeronew
| buffer flag. I can't think of a reason why zeroing out the blocks in
| gfs2_iomap_alloc would have any benefits: there is no additional locking
| at that level that would add protection to the newly allocated blocks.
|
| While at it, change fallocate over from gs2_block_map to gfs2_iomap_begin.
|
| Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
| ---
Hi,
Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=fffb64127adc3eea6a19ceefdc88d171f68b9d34
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2018-03-29 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 18:01 [Cluster-devel] [PATCH] gfs2: Zero out fallocated blocks in fallocate_chunk Andreas Gruenbacher
2018-03-28 18:01 ` Andreas Gruenbacher
2018-03-29 9:01 ` [Cluster-devel] " Christoph Hellwig
2018-03-29 9:01 ` Christoph Hellwig
2018-03-29 14:12 ` Bob Peterson [this message]
2018-03-29 14:12 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1702795937.14837153.1522332762084.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.