Re: [PATCH] arm64: dts: rockchip: vdd_log is not an i2c slave

Re: [PATCH] arm64: dts: rockchip: vdd_log is not an i2c slave

[Heiko Stuebner]

Am Sonntag, 18. Februar 2018, 16:43:59 CET schrieb Vicente Bergas:
> The vdd_log power supply is controlled by a PWM pin, not by i2c register access.
> There is a boot message that reports an error about not being able to bring that supply up.
> Also, the eMMC is not detected and /dev/mmcblk2 does not exist.
> 
> References:
> [1]
> Schematic page 16, search for LOG_DVS_PWM
> https://dl.vamrs.com/products/sapphire_excavator/RK_SAPPHIRE_SOCBOARD_RK3399_LPDDR3D178P232SD8_V12_20161109HXS.pdf
> (alternate link)
> http://opensource.rock-chips.com/images/f/f0/RK_Sapphire_RK3399.rar
> 
> [2]
> arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> 
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

I've adapted the commit message a bit and applied the patch
for 4.17

For the emmc, that is a separate issue and you'll need to look at the logs
to see if there is anything shown. Especially device-numbering
(your mmcblk2) is not guaranteed, so this could very well also be
mmcblk0 or mmcblk1


Thanks
Heiko

Re: [PATCH] arm64: dts: rockchip: vdd_log is not an i2c slave

[Vicente Bergas]

On Mon, Feb 19, 2018 at 7:01 AM, Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote:
> Am Sonntag, 18. Februar 2018, 16:43:59 CET schrieb Vicente Bergas:
>> The vdd_log power supply is controlled by a PWM pin, not by i2c register access.
>> There is a boot message that reports an error about not being able to bring that supply up.
>> Also, the eMMC is not detected and /dev/mmcblk2 does not exist.
>>
>> References:
>> [1]
>> Schematic page 16, search for LOG_DVS_PWM
>> https://dl.vamrs.com/products/sapphire_excavator/RK_SAPPHIRE_SOCBOARD_RK3399_LPDDR3D178P232SD8_V12_20161109HXS.pdf
>> (alternate link)
>> http://opensource.rock-chips.com/images/f/f0/RK_Sapphire_RK3399.rar
>>
>> [2]
>> arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
>>
>> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> I've adapted the commit message a bit and applied the patch
> for 4.17
>
> For the emmc, that is a separate issue and you'll need to look at the logs
> to see if there is anything shown. Especially device-numbering
> (your mmcblk2) is not guaranteed, so this could very well also be
> mmcblk0 or mmcblk1
>
>
> Thanks
> Heiko

Sorry, I did not mention it because I thought it was implicit:
 both issues, the one related to the vdd_log and the other related to
eMMC, are fixed with this patch.
Anyways, thanks for applying it!

Regards,
  Vicente.