All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: catalin.marinas@arm.com, nathan@kernel.org, mark.rutland@arm.com,
	broonie@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	Puranjay Mohan <puranjay12@gmail.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] arm64: prohibit probing on arch_kunwind_consume_entry()
Date: Mon,  4 Mar 2024 13:41:16 +0000	[thread overview]
Message-ID: <170955720098.2136218.47711104039103934.b4-ty@kernel.org> (raw)
In-Reply-To: <20240229231620.24846-1-puranjay12@gmail.com>

On Thu, 29 Feb 2024 23:16:20 +0000, Puranjay Mohan wrote:
> Make arch_kunwind_consume_entry() as __always_inline otherwise the
> compiler might not inline it and allow attaching probes to it.
> 
> Without this, just probing arch_kunwind_consume_entry() via
> <tracefs>/kprobe_events will crash the kernel on arm64.
> 
> The crash can be reproduced using the following compiler and kernel
> combination:
> clang version 19.0.0git (https://github.com/llvm/llvm-project.git d68d29516102252f6bf6dc23fb22cef144ca1cb3)
> commit 87adedeba51a ("Merge tag 'net-6.8-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: prohibit probing on arch_kunwind_consume_entry()
      https://git.kernel.org/arm64/c/2c79bd34af13

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: catalin.marinas@arm.com, nathan@kernel.org, mark.rutland@arm.com,
	broonie@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	Puranjay Mohan <puranjay12@gmail.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] arm64: prohibit probing on arch_kunwind_consume_entry()
Date: Mon,  4 Mar 2024 13:41:16 +0000	[thread overview]
Message-ID: <170955720098.2136218.47711104039103934.b4-ty@kernel.org> (raw)
In-Reply-To: <20240229231620.24846-1-puranjay12@gmail.com>

On Thu, 29 Feb 2024 23:16:20 +0000, Puranjay Mohan wrote:
> Make arch_kunwind_consume_entry() as __always_inline otherwise the
> compiler might not inline it and allow attaching probes to it.
> 
> Without this, just probing arch_kunwind_consume_entry() via
> <tracefs>/kprobe_events will crash the kernel on arm64.
> 
> The crash can be reproduced using the following compiler and kernel
> combination:
> clang version 19.0.0git (https://github.com/llvm/llvm-project.git d68d29516102252f6bf6dc23fb22cef144ca1cb3)
> commit 87adedeba51a ("Merge tag 'net-6.8-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: prohibit probing on arch_kunwind_consume_entry()
      https://git.kernel.org/arm64/c/2c79bd34af13

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-03-04 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 23:16 [PATCH] arm64: prohibit probing on arch_kunwind_consume_entry() Puranjay Mohan
2024-02-29 23:16 ` Puranjay Mohan
2024-03-01 11:24 ` Mark Rutland
2024-03-01 11:24   ` Mark Rutland
2024-03-04 13:41 ` Will Deacon [this message]
2024-03-04 13:41   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170955720098.2136218.47711104039103934.b4-ty@kernel.org \
    --to=will@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=nathan@kernel.org \
    --cc=puranjay12@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.