From: Steve Grubb <sgrubb@redhat.com>
To: Eugene Syromiatnikov <esyr@redhat.com>,
Paul Cercueil <paul@crapouillou.net>
Cc: Cai Huoqing <caihuoqing@baidu.com>,
linux-audit@redhat.com,
strace development discussions <strace-devel@lists.strace.io>,
linux-api@vger.kernel.org, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv@strace.io
Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
Date: Wed, 22 Sep 2021 13:25:29 -0400 [thread overview]
Message-ID: <1710508.VLH7GnMWUR@x2> (raw)
In-Reply-To: <AZHUZQ.4E5G2GAEGJ0U@crapouillou.net>
On Wednesday, September 22, 2021 1:01:58 PM EDT Paul Cercueil wrote:
> >> IPX is marked obsolete for serveral years. so remove it and the
> >> dependency in linux tree.
> >> I'm sorry to not thinking about linux-audit and strace.
> >> Might you remove the dependency or make the part of the code.
> >> Many thanks.
> >
> > Unfortunately, that is not how UAPI works. That change breaks
> > building
> > of the existing code; one cannot change already released versions
> > of either audit, strace, or any other userspace program that happens
> > to unconditionally include <linux/ipx.h> without any fallback (like
> > <netipx/ipx.h> provided by glibc).
>
> Also, the <netipx/ipx.h> fallback is only provided by glibc (and maybe
> uclibc?). With this patch, it is now impossible to compile even the
> very latest version of "strace" with a musl toolchain.
I've made support for ipx optional in audit user space a couple weeks back.
It's no longer a problem for us.
-Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steve Grubb <sgrubb@redhat.com>
To: Eugene Syromiatnikov <esyr@redhat.com>,
Paul Cercueil <paul@crapouillou.net>
Cc: yoshfuji@linux-ipv6.org, linux-api@vger.kernel.org,
dsahern@kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io,
linux-audit@redhat.com, Cai Huoqing <caihuoqing@baidu.com>,
netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
strace development discussions <strace-devel@lists.strace.io>
Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
Date: Wed, 22 Sep 2021 13:25:29 -0400 [thread overview]
Message-ID: <1710508.VLH7GnMWUR@x2> (raw)
In-Reply-To: <AZHUZQ.4E5G2GAEGJ0U@crapouillou.net>
On Wednesday, September 22, 2021 1:01:58 PM EDT Paul Cercueil wrote:
> >> IPX is marked obsolete for serveral years. so remove it and the
> >> dependency in linux tree.
> >> I'm sorry to not thinking about linux-audit and strace.
> >> Might you remove the dependency or make the part of the code.
> >> Many thanks.
> >
> > Unfortunately, that is not how UAPI works. That change breaks
> > building
> > of the existing code; one cannot change already released versions
> > of either audit, strace, or any other userspace program that happens
> > to unconditionally include <linux/ipx.h> without any fallback (like
> > <netipx/ipx.h> provided by glibc).
>
> Also, the <netipx/ipx.h> fallback is only provided by glibc (and maybe
> uclibc?). With this patch, it is now impossible to compile even the
> very latest version of "strace" with a musl toolchain.
I've made support for ipx optional in audit user space a couple weeks back.
It's no longer a problem for us.
-Steve
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2021-09-22 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 12:08 [PATCH 0/2] net: Remove the ipx network layer header files Cai Huoqing
2021-08-13 12:08 ` [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h " Cai Huoqing
2021-09-01 16:02 ` Eugene Syromiatnikov
2021-09-01 16:52 ` Eugene Syromiatnikov
2021-09-01 17:36 ` Steve Grubb
2021-09-01 17:36 ` Steve Grubb
2021-09-02 13:35 ` Cai Huoqing
2021-09-02 13:35 ` Cai Huoqing
2021-09-02 16:08 ` Eugene Syromiatnikov
2021-09-02 16:08 ` Eugene Syromiatnikov
2021-09-22 17:01 ` Paul Cercueil
2021-09-22 17:01 ` Paul Cercueil
2021-09-22 17:25 ` Steve Grubb [this message]
2021-09-22 17:25 ` Steve Grubb
2021-08-13 12:08 ` [PATCH 2/2] MAINTAINERS: Remove the ipx network layer info Cai Huoqing
2021-08-14 19:30 ` [PATCH 0/2] net: Remove the ipx network layer header files patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1710508.VLH7GnMWUR@x2 \
--to=sgrubb@redhat.com \
--cc=caihuoqing@baidu.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=esyr@redhat.com \
--cc=kuba@kernel.org \
--cc=ldv@strace.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=strace-devel@lists.strace.io \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.