From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <mripard@kernel.org>,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: allwinner,sun6i-a31-prcm: Use hyphens in node names
Date: Wed, 24 Apr 2024 14:55:47 -0500 [thread overview]
Message-ID: <171398853223.372037.811685185869412352.robh@kernel.org> (raw)
In-Reply-To: <20240424045521.31857-1-krzysztof.kozlowski@linaro.org>
On Wed, 24 Apr 2024 06:55:21 +0200, Krzysztof Kozlowski wrote:
> Underscores should not be used in node names (dtc with W=2 warns about
> them), so replace them with hyphens. This should have no impact on
> known users: Linux MFD driver does not care about children node names.
> DTS was already adjusted in commit 0f47ef3ff1bd ("arm: dts: allwinner: drop
> underscore in node names"), so without this change, we observe
> dtbs_check warnings:
>
> sun6i-a31s-colorfly-e708-q1.dtb: prcm@1f01400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk', 'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes: '^.*_(clk|rst)$', 'pinctrl-[0-9]+'
>
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/all/CAL_JsqJfT-jui5P56CO4Fr37kr5iNN8dpxt8ecKeFmdVGnRYbA@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/mfd/allwinner,sun6i-a31-prcm.yaml | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <mripard@kernel.org>,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: allwinner,sun6i-a31-prcm: Use hyphens in node names
Date: Wed, 24 Apr 2024 14:55:47 -0500 [thread overview]
Message-ID: <171398853223.372037.811685185869412352.robh@kernel.org> (raw)
In-Reply-To: <20240424045521.31857-1-krzysztof.kozlowski@linaro.org>
On Wed, 24 Apr 2024 06:55:21 +0200, Krzysztof Kozlowski wrote:
> Underscores should not be used in node names (dtc with W=2 warns about
> them), so replace them with hyphens. This should have no impact on
> known users: Linux MFD driver does not care about children node names.
> DTS was already adjusted in commit 0f47ef3ff1bd ("arm: dts: allwinner: drop
> underscore in node names"), so without this change, we observe
> dtbs_check warnings:
>
> sun6i-a31s-colorfly-e708-q1.dtb: prcm@1f01400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk', 'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes: '^.*_(clk|rst)$', 'pinctrl-[0-9]+'
>
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/all/CAL_JsqJfT-jui5P56CO4Fr37kr5iNN8dpxt8ecKeFmdVGnRYbA@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/mfd/allwinner,sun6i-a31-prcm.yaml | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-24 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 4:55 [PATCH] dt-bindings: mfd: allwinner,sun6i-a31-prcm: Use hyphens in node names Krzysztof Kozlowski
2024-04-24 4:55 ` Krzysztof Kozlowski
2024-04-24 18:58 ` Jernej Škrabec
2024-04-24 18:58 ` Jernej Škrabec
2024-04-24 19:55 ` Rob Herring [this message]
2024-04-24 19:55 ` Rob Herring
2024-05-02 17:00 ` (subset) " Lee Jones
2024-05-02 17:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171398853223.372037.811685185869412352.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.