All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Rich Felker <dalias@libc.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 2/2] clocksource: add J-Core timer/clocksource driver
Date: Wed, 27 Jul 2016 07:59:43 +0000	[thread overview]
Message-ID: <17153052.5VBjvy6GiN@wuerfel> (raw)
In-Reply-To: <2cc63c8ecc2653f71bf9aec02501871e2407aae0.1469594844.git.dalias@libc.org>

On Wednesday, July 27, 2016 5:35:09 AM CEST Rich Felker wrote:
> +
> +static void __init jcore_pit_init(struct device_node *node)
> +{
> +       int err;
> +       __iomem void *pit_base;
> +       unsigned pit_irq;
> +       unsigned cpu;
> +       struct jcore_pit_nb *nb = 0;
> +       struct jcore_clocksource *cs = 0;
> +       struct jcore_pit __percpu *pit_percpu = 0;
> 

This no longer applies, as the return type of the init function is
now 'int', not 'void'.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Rich Felker <dalias@libc.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 2/2] clocksource: add J-Core timer/clocksource driver
Date: Wed, 27 Jul 2016 09:59:43 +0200	[thread overview]
Message-ID: <17153052.5VBjvy6GiN@wuerfel> (raw)
In-Reply-To: <2cc63c8ecc2653f71bf9aec02501871e2407aae0.1469594844.git.dalias@libc.org>

On Wednesday, July 27, 2016 5:35:09 AM CEST Rich Felker wrote:
> +
> +static void __init jcore_pit_init(struct device_node *node)
> +{
> +       int err;
> +       __iomem void *pit_base;
> +       unsigned pit_irq;
> +       unsigned cpu;
> +       struct jcore_pit_nb *nb = 0;
> +       struct jcore_clocksource *cs = 0;
> +       struct jcore_pit __percpu *pit_percpu = 0;
> 

This no longer applies, as the return type of the init function is
now 'int', not 'void'.

	Arnd

  reply	other threads:[~2016-07-27  7:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  5:35 [PATCH v4 0/2] J-Core timer support Rich Felker
2016-07-27  5:35 ` Rich Felker
2016-07-27  5:35 ` Rich Felker
2016-07-27  5:35 ` [PATCH v4 1/2] of: add J-Core timer bindings Rich Felker
2016-07-27  5:35 ` [PATCH v4 2/2] clocksource: add J-Core timer/clocksource driver Rich Felker
2016-07-27  5:35   ` Rich Felker
2016-07-27  7:59   ` Arnd Bergmann [this message]
2016-07-27  7:59     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17153052.5VBjvy6GiN@wuerfel \
    --to=arnd@arndb.de \
    --cc=dalias@libc.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.